Issue/use material alert dialog#11505
Merged
planarvoid merged 10 commits intofeature/material-themefrom Mar 25, 2020
Merged
Conversation
…ordpress-mobile/WordPress-Android into issue/use-material-alert-dialog
…ordpress-mobile/WordPress-Android into issue/use-material-alert-dialog
|
You can test the changes on this Pull Request by downloading the APK here. |
wpmobilebot
reviewed
Mar 23, 2020
WordPress/src/main/java/org/wordpress/android/ui/publicize/PublicizeErrorDialogFragment.kt
Outdated
Show resolved
Hide resolved
wpmobilebot
reviewed
Mar 23, 2020
WordPress/src/main/java/org/wordpress/android/ui/publicize/PublicizeErrorDialogFragment.kt
Outdated
Show resolved
Hide resolved
wpmobilebot
reviewed
Mar 23, 2020
WordPress/src/main/java/org/wordpress/android/widgets/AppRatingDialog.kt
Outdated
Show resolved
Hide resolved
…-mobile/WordPress-Android into issue/use-material-alert-dialog
planarvoid
approved these changes
Mar 25, 2020
Contributor
planarvoid
left a comment
There was a problem hiding this comment.
Looks great! The app in the dark mode is lit 🔥
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switched a couple of remaining AlertDialog's to material versions.
Specifically, we switched from
AlertDialog.Builder()toMaterialAlertDialogBuilder()There are no substantial visual changes or changes in dialogs' behavior.
To test:
There is no need to check all the updated dialogs, but you can check couple of easily accessible ones to confirm that they are working:
PR submission checklist:
RELEASE-NOTES.txtif necessary.