Skip to content

fix code block for consistency#8489

Merged
sarah11918 merged 2 commits intowithastro:mainfrom
ovidozio:patch-1
Jun 11, 2024
Merged

fix code block for consistency#8489
sarah11918 merged 2 commits intowithastro:mainfrom
ovidozio:patch-1

Conversation

@ovidozio
Copy link
Copy Markdown
Contributor

@ovidozio ovidozio commented Jun 11, 2024

Description (required)

Typo
inconsistent backslash in title of code-block removed
dashes removed for YAML, since there is content "above"

@ovidozio
fix code block for consistency
0126d6d 
inconsistent backslash in title removed
dashes removed, since there is content above
@vercel
Copy link
Copy Markdown

vercel bot commented Jun 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jun 11, 2024 8:26pm

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Jun 11, 2024

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Jun 11, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en tutorial/5-astro-api/2.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@yanthomasdev yanthomasdev changed the title typo: fix code block for consistency fix code block for consistency Jun 11, 2024
yanthomasdev
yanthomasdev reviewed Jun 11, 2024
View reviewed changes
@sarah11918 @yanthomasdev
proper astro file formatting
6b62f11 
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
sarah11918
sarah11918 approved these changes Jun 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the backslash, @ovidozio! As Yan noted, this code is not YAML, it's astro, and the dashes are required on both top and bottom in our file format, so I've committed his suggestion.

We appreciate your help keeping the file names consistent, and are happy to welcome you to Team Docs! 🥳

@sarah11918 sarah11918 added consistency/formatting Standardizing without changing docs content e.g. indenting, lists etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Jun 11, 2024
@sarah11918 sarah11918 merged commit ce58cde into withastro:main Jun 11, 2024
@jsparkdev jsparkdev mentioned this pull request Jun 12, 2024
Merged
@liruifengv liruifengv mentioned this pull request Jun 13, 2024
Merged
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Jun 26, 2024
@thomasbnt
i18n(fr): Update tutorial/5-astro-api/2.mdx from withastro#8489
531b50a
@thomasbnt thomasbnt mentioned this pull request Jun 26, 2024
Merged
yanthomasdev added a commit that referenced this pull request Jun 26, 2024
@thomasbnt @yanthomasdev
i18n(fr): Update tutorials (#8678)
fe54fe9 
* i18n(fr): Update `tutorial/0-introduction/1.mdx` from #8239

* i18n(fr): Update `tutorial/2-pages/2.mdx` from #8318

* i18n(fr): Update `tutorial/2-pages/2.mdx` from #8543

* i18n(fr): Update `tutorial/3-components/1.mdx` from #8300

* i18n(fr): Update `tutorial/4-layouts/1.mdx` from #8303

* i18n(fr): Update `tutorial/4-layouts/1.mdx` from #8584

* i18n(fr): Update `tutorial/4-layouts/2.mdx` from #8318

* i18n(fr): Update `tutorial/4-layouts/2.mdx` from #8543

* i18n(fr): Update `tutorial/5-astro-api/1.mdx` from #8191

* i18n(fr): Update `tutorial/5-astro-api/2.mdx` from #8327

* i18n(fr): Update `tutorial/5-astro-api/2.mdx` from #8489

* i18n(fr): Update `tutorial/5-astro-api/4.mdx` from #8419

* i18n(fr): Fix tab

Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>

---------

Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yanthomasdev yanthomasdev yanthomasdev left review comments

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees

No one assigned

Labels

consistency/formatting Standardizing without changing docs content e.g. indenting, lists etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ovidozio @astrobot-houston @sarah11918 @yanthomasdev