Skip to content

replace astro light logo with dark logo#8318

Merged
sarah11918 merged 9 commits intowithastro:mainfrom
garysassano:fix-logo
Jun 10, 2024
Merged

replace astro light logo with dark logo#8318
sarah11918 merged 9 commits intowithastro:mainfrom
garysassano:fix-logo

Conversation

@garysassano
Copy link
Copy Markdown
Contributor

@garysassano garysassano commented May 17, 2024

When you reach this part of the tutorial:
image

You will end up with this blog post page being rendered:

before

You may think something isn't working, but you are actually just displaying a white logo on a white page, which isn't ideal.

So we can just switch to the dark logo instead:

after

@vercel
Copy link
Copy Markdown

vercel bot commented May 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jun 10, 2024 1:34pm

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label May 17, 2024
@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented May 17, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en tutorial/2-pages/2.mdx Source changed, localizations will be marked as outdated.
en tutorial/4-layouts/2.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@yanthomasdev
Copy link
Copy Markdown
Member

yanthomasdev commented May 17, 2024

Nice catch @garysassano, can I just ask you to remove the translations from this PR and leave only the English changes? We have a system in-place to let translators know of this change and do it on their own 🙌

@garysassano garysassano reopened this May 17, 2024
@github-actions github-actions bot removed the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label May 17, 2024
at-the-vr
at-the-vr reviewed May 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@at-the-vr at-the-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Gary 👋 I find a similar issue with the Dark theme now: Stackblitz Instance shows a dark logo on a dark page. Its still more visible as compared to former page. letting it know before someone asks to change it back to logo-light.png 😄
image

@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented May 18, 2024

Yes, perhaps someone would hunt down a Houston image or something that will work in both modes? 😄

@at-the-vr
Copy link
Copy Markdown
Member

at-the-vr commented May 18, 2024

yeah i was worried that this is not available from Astro Press and having an unofficial logo would be uncalled for

@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented May 21, 2024

The other blog images are taken from our wallpapers, so what about snagging another one of these, uploading it to docs assets, and using it for this post!

@sarah11918 sarah11918 added the tutorial Content/UI for the Build a Blog Tutorial label May 21, 2024
sarah11918
sarah11918 reviewed Jun 10, 2024
View reviewed changes
sarah11918
sarah11918 approved these changes Jun 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the graphic! LGTM! Let's make this work for all view modes! 🚀

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Jun 10, 2024
@sarah11918 sarah11918 merged commit 202bb0f into withastro:main Jun 10, 2024
@jsparkdev jsparkdev mentioned this pull request Jun 11, 2024
Merged
@liruifengv liruifengv mentioned this pull request Jun 13, 2024
Merged
@at-the-vr at-the-vr mentioned this pull request Jun 17, 2024
Closed
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Jun 26, 2024
@thomasbnt
i18n(fr): Update tutorial/2-pages/2.mdx from withastro#8318
5a17118
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Jun 26, 2024
@thomasbnt
i18n(fr): Update tutorial/4-layouts/2.mdx from withastro#8318
7bc2d50
@thomasbnt thomasbnt mentioned this pull request Jun 26, 2024
Merged
yanthomasdev added a commit that referenced this pull request Jun 26, 2024
@thomasbnt @yanthomasdev
i18n(fr): Update tutorials (#8678)
fe54fe9 
* i18n(fr): Update `tutorial/0-introduction/1.mdx` from #8239

* i18n(fr): Update `tutorial/2-pages/2.mdx` from #8318

* i18n(fr): Update `tutorial/2-pages/2.mdx` from #8543

* i18n(fr): Update `tutorial/3-components/1.mdx` from #8300

* i18n(fr): Update `tutorial/4-layouts/1.mdx` from #8303

* i18n(fr): Update `tutorial/4-layouts/1.mdx` from #8584

* i18n(fr): Update `tutorial/4-layouts/2.mdx` from #8318

* i18n(fr): Update `tutorial/4-layouts/2.mdx` from #8543

* i18n(fr): Update `tutorial/5-astro-api/1.mdx` from #8191

* i18n(fr): Update `tutorial/5-astro-api/2.mdx` from #8327

* i18n(fr): Update `tutorial/5-astro-api/2.mdx` from #8489

* i18n(fr): Update `tutorial/5-astro-api/4.mdx` from #8419

* i18n(fr): Fix tab

Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>

---------

Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@sarah11918 sarah11918 added the feedback-improvement Response to widget/Discord feedback label Aug 14, 2024
This was referenced Jan 24, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

+1 more reviewer

@at-the-vr at-the-vr at-the-vr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feedback-improvement Response to widget/Discord feedback Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! tutorial Content/UI for the Build a Blog Tutorial

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@garysassano @astrobot-houston @yanthomasdev @sarah11918 @at-the-vr