Skip to content

fix minor detail in tutorial 3#8300

Merged
sarah11918 merged 2 commits intowithastro:mainfrom
garysassano:fix-tutorial-3
May 17, 2024
Merged

fix minor detail in tutorial 3#8300
sarah11918 merged 2 commits intowithastro:mainfrom
garysassano:fix-tutorial-3

Conversation

@garysassano
Copy link
Copy Markdown
Contributor

@garysassano garysassano commented May 16, 2024 •
edited
Loading

Description (required)

The code wasn't referencing the previous state of index.astro from tutorial 2.

@vercel
Copy link
Copy Markdown

vercel bot commented May 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 17, 2024 0:38am

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented May 16, 2024

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented May 16, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en tutorial/3-components/1.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

sarah11918
sarah11918 approved these changes May 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @garysassano !

We don't always show the full existing content in these samples or else the tutorial would get very long and complicated! This is why we have code check-ins periodically where you can compare to a full version.

But, in this case, since there is very little existing code, I think it's fine to add here! We can be complete and still not overwhelming with too much code, so let's do this!

Thank you for your submission, and welcome to Team Docs! 🥳

@sarah11918 sarah11918 added code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels May 17, 2024
@sarah11918 sarah11918 merged commit aac5085 into withastro:main May 17, 2024
@jsparkdev jsparkdev mentioned this pull request May 17, 2024
Merged
@100gle 100gle mentioned this pull request May 18, 2024
Merged
@huyikai huyikai mentioned this pull request May 20, 2024
Closed
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Jun 26, 2024
@thomasbnt
i18n(fr): Update tutorial/3-components/1.mdx from withastro#8300
d725e63
@thomasbnt thomasbnt mentioned this pull request Jun 26, 2024
Merged
yanthomasdev added a commit that referenced this pull request Jun 26, 2024
@thomasbnt @yanthomasdev
i18n(fr): Update tutorials (#8678)
fe54fe9 
* i18n(fr): Update `tutorial/0-introduction/1.mdx` from #8239

* i18n(fr): Update `tutorial/2-pages/2.mdx` from #8318

* i18n(fr): Update `tutorial/2-pages/2.mdx` from #8543

* i18n(fr): Update `tutorial/3-components/1.mdx` from #8300

* i18n(fr): Update `tutorial/4-layouts/1.mdx` from #8303

* i18n(fr): Update `tutorial/4-layouts/1.mdx` from #8584

* i18n(fr): Update `tutorial/4-layouts/2.mdx` from #8318

* i18n(fr): Update `tutorial/4-layouts/2.mdx` from #8543

* i18n(fr): Update `tutorial/5-astro-api/1.mdx` from #8191

* i18n(fr): Update `tutorial/5-astro-api/2.mdx` from #8327

* i18n(fr): Update `tutorial/5-astro-api/2.mdx` from #8489

* i18n(fr): Update `tutorial/5-astro-api/4.mdx` from #8419

* i18n(fr): Fix tab

Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>

---------

Signed-off-by: Thomas Bnt <thomasbnt@protonmail.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@trueberryless trueberryless mentioned this pull request Oct 5, 2025
Merged
@morinokami morinokami mentioned this pull request Jan 24, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees

No one assigned

Labels

code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@garysassano @astrobot-houston @sarah11918