Support fullouter join#2
Open
windtalker wants to merge 19 commits intofeature/release-8.5-materialized-viewfrom
Open
Support fullouter join#2windtalker wants to merge 19 commits intofeature/release-8.5-materialized-viewfrom
windtalker wants to merge 19 commits intofeature/release-8.5-materialized-viewfrom
Conversation
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
Add planner gate to reject ast.FullJoin with ErrNotSupportedYet("FULL OUTER JOIN") so parser/ast support does not silently fall back to inner join semantics.
Add TestFullOuterJoinFailFast to cover ON/USING/NATURAL forms all failing fast.
Update fullouter_join_dev.md with explicit phase-1 constraints, fail-fast milestone, and test mapping.
Validation:
- go test ./pkg/planner/core -run TestFullOuterJoinFailFast -tags=intest,deadlock
- make bazel_lint_changed
dc0a4b1 to
4564a41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.