Skip to content

expression/aggregation: support sum_int in NewDistAggFunc#66360

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:feature/release-8.5-materialized-viewfrom
winoros:sumint-unistore
Feb 25, 2026
Merged

expression/aggregation: support sum_int in NewDistAggFunc#66360
ti-chi-bot[bot] merged 1 commit intopingcap:feature/release-8.5-materialized-viewfrom
winoros:sumint-unistore

Conversation

@winoros
Copy link
Member

@winoros winoros commented Feb 24, 2026

What problem does this PR solve?

Issue Number: ref #66085

Problem Summary:

sum_int has been introduced and can be pushed down, but mockstore cop execution still failed when decoding pushed-down aggregate functions because aggregation.NewDistAggFunc did not handle tipb.ExprType_SumInt. This blocked unit tests for sum_int pushdown.

What changed and how does it work?

  • Add tipb.ExprType_SumInt handling in NewDistAggFunc to build sumIntFunction.
  • Add regression test TestNewDistAggFuncSumInt to verify PB decoding and result correctness.
  • Include Bazel metadata update generated by make bazel_lint_changed.

Check List

Tests

  • Unit test
    • make failpoint-enable && (pushd pkg/expression/aggregation >/dev/null && go test -run 'Test(NewDistAggFuncSumInt|CheckAggPushDownSumInt|AggFuncSumIntToPb)$' -tags=intest,deadlock && rc=$? && popd >/dev/null && make failpoint-disable && exit $rc)
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 24, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 24, 2026

@gengliqi: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tiprow
Copy link

tiprow bot commented Feb 24, 2026

@winoros: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow_for_release 6a8d40f link true /test fast_test_tiprow_for_release

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

windtalker
windtalker approved these changes Feb 25, 2026
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 25, 2026
@codecov
Copy link

codecov bot commented Feb 25, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (feature/release-8.5-materialized-view@7fe4ee1). Learn more about missing BASE report.

Additional details and impacted files 
@@                            Coverage Diff                             @@
##             feature/release-8.5-materialized-view     #66360   +/-   ##
==========================================================================
  Coverage                                         ?   57.0937%           
==========================================================================
  Files                                            ?       1788           
  Lines                                            ?     640230           
  Branches                                         ?          0           
==========================================================================
  Hits                                             ?     365531           
  Misses                                           ?     249975           
  Partials                                         ?      24724
Flag Coverage Δ
integration 36.9972% <0.0000%> (?)
unit 72.5934% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9278% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.7042% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hawkingrei
Copy link
Member

hawkingrei commented Feb 25, 2026

/retest

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 25, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, hawkingrei, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 25, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 25, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-02-25 02:46:26.940687795 +0000 UTC m=+236659.455482404: ☑️ agreed by windtalker.
  • 2026-02-25 05:55:01.688876316 +0000 UTC m=+247974.203670926: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit 0495643 into pingcap:feature/release-8.5-materialized-view Feb 25, 2026
18 of 19 checks passed
@winoros winoros deleted the sumint-unistore branch February 25, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

+1 more reviewer

@gengliqi gengliqi gengliqi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@winoros @hawkingrei @windtalker @gengliqi