Skip to content

*: add aggregate function min_count/max_count#66250

Merged
ti-chi-bot[bot] merged 13 commits intopingcap:feature/release-8.5-materialized-viewfrom
gengliqi:minmaxcount
Feb 25, 2026
Merged

*: add aggregate function min_count/max_count#66250
ti-chi-bot[bot] merged 13 commits intopingcap:feature/release-8.5-materialized-viewfrom
gengliqi:minmaxcount

Conversation

@gengliqi
Copy link
Contributor

@gengliqi gengliqi commented Feb 13, 2026

What problem does this PR solve?

Issue Number: ref #66124

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@gengliqi
implement min_count and max_count
ffc7fc6 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/planner SIG: Planner labels Feb 13, 2026
@tiprow
Copy link

tiprow bot commented Feb 13, 2026

Hi @gengliqi. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gengliqi
Copy link
Contributor Author

gengliqi commented Feb 13, 2026

/retest

@tiprow
Copy link

tiprow bot commented Feb 13, 2026

@gengliqi: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link

codecov bot commented Feb 13, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 36.66667% with 1045 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feature/release-8.5-materialized-view@0495643). Learn more about missing BASE report.

Additional details and impacted files 
@@                            Coverage Diff                             @@
##             feature/release-8.5-materialized-view     #66250   +/-   ##
==========================================================================
  Coverage                                         ?   57.0432%           
==========================================================================
  Files                                            ?       1790           
  Lines                                            ?     641902           
  Branches                                         ?          0           
==========================================================================
  Hits                                             ?     366162           
  Misses                                           ?     251007           
  Partials                                         ?      24733
Flag Coverage Δ
integration 36.9095% <0.5454%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9278% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.7293% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gengliqi
update bazel
0a82a84 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi
u
2f4ed05 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi
update
1e3fa06 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi
merge upstream
1d9acd4 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi
update
d9f0196 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi
update
7760b42 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi
add SerializePartialResult/DeserializePartialResult for min/max(Vecto…
571eae1 
…rFloat32)

Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi
u
f4320ac 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi
u
78ed7f9 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi
u
1a3c388 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi
add comments
03c6c47 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 21, 2026
windtalker
windtalker approved these changes Feb 25, 2026
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 25, 2026
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 25, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-02-21 13:16:31.278404537 +0000 UTC m=+622844.293098008: ☑️ agreed by winoros.
  • 2026-02-25 05:14:17.392562603 +0000 UTC m=+245529.907357202: ☑️ agreed by windtalker.

@tiprow
Copy link

tiprow bot commented Feb 25, 2026

@gengliqi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow_for_release 03c6c47 link true /test fast_test_tiprow_for_release

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gengliqi
merge upstream
0047e65 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 25, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: windtalker, winoros
Once this PR has been reviewed and has the lgtm label, please assign benmeadowcroft, tangenta for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the approved label Feb 25, 2026
@gengliqi
Copy link
Contributor Author

gengliqi commented Feb 25, 2026

/retest

@tiprow
Copy link

tiprow bot commented Feb 25, 2026

@gengliqi: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 78096e1 into pingcap:feature/release-8.5-materialized-view Feb 25, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@windtalker windtalker windtalker approved these changes

@winoros winoros winoros approved these changes

Assignees

No one assigned

Labels

lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gengliqi @windtalker @winoros @ti-chi-bot