pkg/ddl, pkg/executor: validate MV START WITH/NEXT expr type and remove defaults by windtalker · Pull Request #66383 · pingcap/tidb

windtalker · 2026-02-25T07:35:04Z

What problem does this PR solve?

Issue Number: ref #18023

Problem Summary:
Support START WITH / NEXT for CREATE MATERIALIZED VIEW and CREATE MATERIALIZED VIEW LOG with correct create-time semantics.

What changed and how does it work?

Removed implicit defaults during create:

For MV refresh metadata, when user does not specify START WITH or NEXT, store empty strings instead of defaulting to NOW() / 300.

Added expression type validation for schedule clauses:

Validate that START WITH / NEXT expressions in MV refresh and MV LOG purge are DATETIME / TIMESTAMP typed.
Non-datetime expressions now return DDL unsupported errors.

Updated related tests:

Replaced previous NEXT 300/NEXT 600 style SQL in affected tests with datetime expressions.
Added negative test coverage for non-datetime START WITH / NEXT.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Test command:

(find "$PWD"/ -type d | grep -vE "(\.git|tools)" | xargs tools/bin/failpoint-ctl enable) && (
  pushd pkg/executor/test/ddl >/dev/null
  go test -run 'Test(MaterializedViewDDLBasic|CreateMaterializedView.*|DropMaterializedViewLogRecheckWithConcurrentCreateMaterializedView|CreateMaterializedViewLog.*|TruncateMaterializedViewRelatedTablesRejected|MaterializedViewRelatedTablesDDLRejected)' -tags=intest,deadlock -count=1
  rc=$?
  popd >/dev/null
  find "$PWD"/ -type d | grep -vE "(\.git|tools)" | xargs tools/bin/failpoint-ctl disable
  exit $rc
)

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

tiprow · 2026-02-25T07:35:20Z

Hi @windtalker. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2026-02-25T07:53:54Z

Codecov Report

❌ Patch coverage is 68.96552% with 9 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feature/release-8.5-materialized-view@a203693). Learn more about missing BASE report.

Additional details and impacted files

@@                            Coverage Diff                             @@
##             feature/release-8.5-materialized-view     #66383   +/-   ##
==========================================================================
  Coverage                                         ?   57.6079%           
==========================================================================
  Files                                            ?       1791           
  Lines                                            ?     641911           
  Branches                                         ?          0           
==========================================================================
  Hits                                             ?     369792           
  Misses                                           ?     246961           
  Partials                                         ?      25158

Flag	Coverage Δ
integration	`38.2135% <0.0000%> (?)`
unit	`72.4926% <68.9655%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.9278% <0.0000%> (?)`
parser	`∅ <0.0000%> (?)`
br	`63.3895% <0.0000%> (?)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

windtalker · 2026-02-25T11:45:22Z

/test unit-test

tiprow · 2026-02-25T11:45:48Z

@windtalker: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

windtalker · 2026-02-26T05:35:29Z

/run check_dev_2

windtalker · 2026-02-26T05:36:38Z

/test check_dev_2

ti-chi-bot · 2026-02-26T05:36:41Z

@windtalker: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build

/test check-dev

/test check-dev2

/test mysql-test

/test pull-br-integration-test

/test pull-unit-test-ddlv1

/test unit-test

The following commands are available to trigger optional jobs:

/test pull-common-test

/test pull-e2e-test

/test pull-integration-common-test

/test pull-integration-copr-test

/test pull-integration-ddl-test

/test pull-integration-e2e-test

/test pull-integration-jdbc-test

/test pull-integration-mysql-test

/test pull-integration-nodejs-test

/test pull-integration-python-orm-test

/test pull-integration-tidb-tools-test

/test pull-lightning-integration-test

/test pull-mysql-client-test

/test pull-sqllogic-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/release-8.5/pull_br_integration_test

pingcap/tidb/release-8.5/pull_build

pingcap/tidb/release-8.5/pull_check

pingcap/tidb/release-8.5/pull_check2

pingcap/tidb/release-8.5/pull_mysql_test

pingcap/tidb/release-8.5/pull_unit_test

pingcap/tidb/release-8.5/pull_unit_test_ddlv1

Details

In response to this:

/test check_dev_2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2026-02-26T05:37:01Z

@windtalker: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/test check_dev_2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

windtalker · 2026-02-26T05:37:22Z

/test check-dev2

tiprow · 2026-02-26T05:37:46Z

@windtalker: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

xzhangxian1008

lgtm

ti-chi-bot · 2026-02-26T06:34:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wjhuang2016, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [wjhuang2016]
~~pkg/ddl/OWNERS~~ [wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2026-02-26T06:34:08Z

[LGTM Timeline notifier]

Timeline:

2026-02-26 04:20:26.393521904 +0000 UTC m=+328698.908316503: ☑️ agreed by wjhuang2016.
2026-02-26 06:34:07.180782886 +0000 UTC m=+336719.695577495: ☑️ agreed by xzhangxian1008.

ddl,executor: validate mview schedule expr type and drop defaults

c69b5bc

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 25, 2026

ddl: avoid SQL concat in mview schedule expr validation

bb55067

ddl, schematracker: validate mview schedule expr type in SchemaTracker

b7cc3ac

wjhuang2016 approved these changes Feb 26, 2026

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 26, 2026

xzhangxian1008 approved these changes Feb 26, 2026

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 26, 2026

ti-chi-bot bot merged commit e8829b0 into pingcap:feature/release-8.5-materialized-view Feb 26, 2026
20 of 21 checks passed

windtalker deleted the update_next_column_when_build_mv_and_mv_log branch February 26, 2026 06:56

Conversation

windtalker commented Feb 25, 2026

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

tiprow bot commented Feb 25, 2026

Uh oh!

codecov bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

windtalker commented Feb 25, 2026

Uh oh!

tiprow bot commented Feb 25, 2026

Uh oh!

windtalker commented Feb 26, 2026

Uh oh!

windtalker commented Feb 26, 2026

Uh oh!

ti-chi-bot bot commented Feb 26, 2026

Uh oh!

tiprow bot commented Feb 26, 2026

Uh oh!

windtalker commented Feb 26, 2026

Uh oh!

tiprow bot commented Feb 26, 2026

Uh oh!

xzhangxian1008 left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Feb 26, 2026

Uh oh!

ti-chi-bot bot commented Feb 26, 2026

[LGTM Timeline notifier]

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Feb 25, 2026 •

edited

Loading