Skip to content

WDIO-V8 tests fixes#14148

Merged
christian-bromann merged 21 commits intowebdriverio:v8from
rounak610:v8_unit_tests_fixes
Feb 5, 2025
Merged

WDIO-V8 tests fixes#14148
christian-bromann merged 21 commits intowebdriverio:v8from
rounak610:v8_unit_tests_fixes

Conversation

@rounak610
Copy link
Contributor

@rounak610 rounak610 commented Feb 4, 2025

Proposed changes

Hey @christian-bromann ,
As mentioned in this comment we went through the errors, most of them were unrelated to the PR but we were able to fix the issues on Linux and macOS. For the Windows issue, we found a related issue raised here.
We’ve added the fix for Linux and macOS in the current branch.
Please help us merge the v8 PRs based on this fix, since the github issue already exists for Windows.

Related v8 PRs:

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@erwinheitzman
Copy link
Member

Hi @rounak610 can you explain why you added the --no-sandbox? I don't see how adding this adds any value

@rounak610
Copy link
Contributor Author

Hi @rounak610 can you explain why you added the --no-sandbox? I don't see how adding this adds any value

Hey @erwinheitzman,

I ran the tests without the --no-sandbox flag, and the Linux tests failed with this error:
ERROR webdriver: Request failed with status 500 due to session not created: session not created: probably user data directory is already in use, please specify a unique value for --user-data-dir argument, or don't use --user-data-dir ERROR webdriver: session not created: session not created: probably user data directory is already in use, please specify a unique value for --user-data-dir argument, or don't use --user-data-dir
Session link: https://github.com/rounak610/webdriverio/actions/runs/13150573955/job/36697176498?pr=8
I found a similar issue here

@erwinheitzman
Copy link
Member

This would suggest that chrome is run with root privileges by the looks of it 😲

This change is fine then and perhaps we can look into the privileges later

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@christian-bromann christian-bromann merged commit 561165b into webdriverio:v8 Feb 5, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants