[v8] Accessibility Support for Browserstack app automate sessions by nishath-bs · Pull Request #14034 · webdriverio/webdriverio

nishath-bs · 2025-01-07T04:48:20Z

Proposed changes

We have added AppAccessibility Scans support for the BrowserStack app automated sessions. Previously the accessibility support was there for Web Automation alone now we have added it for App Automation as well.

Types of changes

Polish (an improvement for an existing feature)
Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update (improvements to the project's docs)
Specification changes (updates to WebDriver command specifications)
Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
I have added the necessary documentation (if appropriate)
I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

This change is solely for v9 and doesn't need to be back-ported
Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

V8

checking os version even if given in regex form

add unit test for util file changes

linux-foundation-easycla · 2025-01-07T04:48:25Z

The committers listed above are authorized under a signed CLA.

✅ login: dbs-2001 (cc07ddb, 2d180b7, d118acb, bb405d5, d694c40, ee81e8a, 9ccbe96, dc49aa0, 6c76ed1, 4cdf910, 6cf77f8, 58a0d25, 9d04399, c21acfe, 81b1f77, 7f1ff67)
✅ login: nishath-bs / name: Mohamed Nishath N (b9510bd, 21e98ab, b946c98, c718c3b, 480f17e, 7972028, ddc663b, 1417b83, 7cbe45e, 3bcbefc, d760703, 785f71f, 776f512, 84ba469, 9210c70, 201003a, 0105266, 8015b47, da8b32e, 7e180eb, 915eb0b, ba14582)
✅ login: christian-bromann / name: Christian Bromann (2f6cd33)

packages/wdio-browserstack-service/src/util.ts

packages/wdio-browserstack-service/tests/util.test.ts

nishath-bs · 2025-01-15T17:37:22Z

@christian-bromann Is there anything pending from my side. Can we merge this?

christian-bromann · 2025-01-15T17:40:07Z

Is there anything pending from my side. Can we merge this?

I haven't been able to look into the failing e2e tests, I want to make sure to understand what is going on before merging. It would help if you could take a look at this as well. It is probably unrelated to this PR.

nishath-bs · 2025-01-16T19:44:53Z

Is there anything pending from my side. Can we merge this?

I haven't been able to look into the failing e2e tests, I want to make sure to understand what is going on before merging. It would help if you could take a look at this as well. It is probably unrelated to this PR.

@christian-bromann we checked this. But the failures are not due to our changes. And it seems it was failing from before itself

nishath-bs · 2025-01-17T10:42:29Z

@christian-bromann In the previous merges also we have skipped this checks and merged it #13926

christian-bromann · 2025-01-17T22:02:05Z

In the previous merges also we have skipped this checks and merged it #13926

This wasn't ideal either. We should not disregard the pipelines.

nishath-bs · 2025-01-20T19:53:51Z

In the previous merges also we have skipped this checks and merged it #13926

This wasn't ideal either. We should not disregard the pipelines.

@christian-bromann Do you want us to look into this? or should we wait till you fix the pipelines

christian-bromann · 2025-01-20T19:55:37Z

Do you want us to look into this?

That would be very helpful!

nishath-bs · 2025-01-20T20:04:47Z

Do you want us to look into this?

That would be very helpful!

Actually, we tried debugging that. but we didn't have enough context as the error comes from other parts of the code. That why we reverted to you

christian-bromann · 2025-01-20T20:40:36Z

Can your team raise an issue and document its findings? I am happy to provide context.

nishath-bs · 2025-02-06T05:47:50Z

@christian-bromann As per this PR we have fixed the tests that are failing. Can you please merge this now?

christian-bromann

LGTM 👍

nishath-bs · 2025-02-07T10:01:14Z

@christian-bromann since its a new feature. Can you tag a release for this

nishath-bs · 2025-02-11T05:57:27Z

@christian-bromann since its a new feature. Can you tag a release for this

@christian-bromann Can you release a version for v8. As we have to release this as a feature

nishath-bs and others added 28 commits December 18, 2024 13:07

performScan changes for app-a11y

3bcbefc

add neccessary variables for a11y in env

2d180b7

change polling timeout env

4cdf910

resolve error

81b1f77

remove unnecessary changes

6cf77f8

added polling api for app a11y results

785f71f

Merge pull request #3 from dbs-2001/v8

480f17e

V8

checking os version even if given in regex form

dc49aa0

Merge pull request #4 from nishath-bs/fix-os-version-regex

ddc663b

checking os version even if given in regex form

review comment changes

84ba469

added instrumentation

915eb0b

changed prop name for instrumentation

201003a

log message changes

da8b32e

review comment changes

776f512

removed isPageOpened

1417b83

linting fixes

7cbe45e

added math round off and moved logger inside scannerVersion check

b9510bd

add unit test for util file changes

d694c40

add test cases for app automate flow in accessibility handler

6c76ed1

add performa11yscan function testing for isappautomate true

d118acb

fix test cases in accessibility handle

ee81e8a

fix test cases in util

9ccbe96

Trigger Build

b946c98

linting fixes

21e98ab

added axios dependency

d760703

test case fixed in getAppA11yResults

cc07ddb

Trigger Build

c718c3b

Merge pull request #5 from nishath-bs/unit-test-mocha-cucumber-changes

7972028

add unit test for util file changes

nishath-bs changed the title ~~App a11y assert api~~ Accessibility Support for Browserstack app automate sessions Jan 7, 2025

compile issue fix

7e180eb

christian-bromann reviewed Jan 9, 2025

View reviewed changes

packages/wdio-browserstack-service/src/util.ts Outdated Show resolved Hide resolved

packages/wdio-browserstack-service/src/util.ts Outdated Show resolved Hide resolved

packages/wdio-browserstack-service/src/util.ts Outdated Show resolved Hide resolved

removed try catch and pollApi changes to without promise

8015b47

nishath-bs requested a review from christian-bromann January 10, 2025 08:24

christian-bromann reviewed Jan 10, 2025

View reviewed changes

packages/wdio-browserstack-service/tests/util.test.ts Outdated Show resolved Hide resolved

changed unit test for got request module

ba14582

nishath-bs requested a review from christian-bromann January 10, 2025 11:53

nishath-bs mentioned this pull request Jan 13, 2025

Accessibility Support for Browserstack app automate sessions #14069

Merged

13 tasks

nishath-bs changed the title ~~Accessibility Support for Browserstack app automate sessions~~ [v8] Accessibility Support for Browserstack app automate sessions Jan 14, 2025

dbs-2001 added 4 commits January 24, 2025 20:11

comment for got module usage

7f1ff67

remove commas

c21acfe

fix ut

58a0d25

remove format

9d04399

rounak610 mentioned this pull request Feb 4, 2025

WDIO-V8 tests fixes #14148

Merged

13 tasks

Merge branch 'v8' into app_a11y_assert_api

2f6cd33

christian-bromann approved these changes Feb 6, 2025

View reviewed changes

christian-bromann added the PR: Polish 💅 PRs that contain improvements on existing features label Feb 6, 2025

christian-bromann merged commit 3457cb7 into webdriverio:v8 Feb 6, 2025
8 of 9 checks passed

Uh oh!

Conversation

nishath-bs commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Types of changes

Checklist

Backport Request

Further comments

Reviewers: @webdriverio/project-committers

Uh oh!

linux-foundation-easycla bot commented Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nishath-bs commented Jan 15, 2025

Uh oh!

christian-bromann commented Jan 15, 2025

Uh oh!

nishath-bs commented Jan 16, 2025

Uh oh!

nishath-bs commented Jan 17, 2025

Uh oh!

christian-bromann commented Jan 17, 2025

Uh oh!

nishath-bs commented Jan 20, 2025

Uh oh!

christian-bromann commented Jan 20, 2025

Uh oh!

nishath-bs commented Jan 20, 2025

Uh oh!

christian-bromann commented Jan 20, 2025

Uh oh!

nishath-bs commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

christian-bromann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nishath-bs commented Feb 7, 2025

Uh oh!

nishath-bs commented Feb 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nishath-bs commented Jan 7, 2025 •

edited

Loading

linux-foundation-easycla bot commented Jan 7, 2025 •

edited

Loading

nishath-bs commented Feb 6, 2025 •

edited

Loading