Skip to content

Add performance instrumentation v8#14041

Merged
christian-bromann merged 24 commits intowebdriverio:v8from
07souravkunda:add_performance_instrumentation_v8
Feb 10, 2025
Merged

Add performance instrumentation v8#14041
christian-bromann merged 24 commits intowebdriverio:v8from
07souravkunda:add_performance_instrumentation_v8

Conversation

@07souravkunda
Copy link
Contributor

@07souravkunda 07souravkunda commented Jan 8, 2025

Proposed changes

Add performance measures for browserstack-service

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@christian-bromann
Copy link
Member

christian-bromann commented Jan 8, 2025

Is this feature suppose to be only released in v8?

@07souravkunda
Copy link
Contributor Author

07souravkunda commented Jan 9, 2025

Is this feature suppose to be only released in v8?

No, for v9 as well. Will create the PR once the review for v8 is done as the same will be applicable for v9 as well.

@christian-bromann
Copy link
Member

christian-bromann commented Jan 9, 2025

No, for v9 as well. Will create the PR once the review for v8 is done as the same will be applicable for v9 as well.

I suggest the other way around: first the PR for v9 , then copy the changes into v8. Please note: given limited resources we barely backport any bug fixes back into v8 so users should be recommended to upgrade to the latest major version as quick as possible.

christian-bromann
christian-bromann requested changes Jan 9, 2025
View reviewed changes
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial round of feedback

christian-bromann
christian-bromann requested changes Jan 15, 2025
View reviewed changes
@christian-bromann
Copy link
Member

christian-bromann commented Jan 17, 2025

Like the other PR we are blocked on the failing e2e tests. These should be resolved first before making releases.

@rounak610 rounak610 mentioned this pull request Feb 4, 2025
Merged
13 tasks
@christian-bromann
Copy link
Member

christian-bromann commented Feb 6, 2025

Can we resolve the conflicts and have the tests pass?

@christian-bromann christian-bromann merged commit a79077f into webdriverio:v8 Feb 10, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@07souravkunda @christian-bromann