Skip to content

fixes for percy in wdio-v8#14147

Merged
christian-bromann merged 2 commits intowebdriverio:v8from
rounak610:percy_v8_fixes
Feb 5, 2025
Merged

fixes for percy in wdio-v8#14147
christian-bromann merged 2 commits intowebdriverio:v8from
rounak610:percy_v8_fixes

Conversation

@rounak610
Copy link
Contributor

@rounak610 rounak610 commented Feb 4, 2025

Proposed changes

Percy is breaking with multiple devices on v8.

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

@rounak610 rounak610 mentioned this pull request Feb 4, 2025
13 tasks
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann merged commit a687153 into webdriverio:v8 Feb 5, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants