Include Digital Credential Issuance in the Spec#204
Conversation
marcoscaceres
left a comment
There was a problem hiding this comment.
cool stuff @mohamedamir!!!1!!!one!!! nice one.
|
@mohamedamir, see also #179 ... we need those checks too!!! |
|
There may be goodies to pilfer also from https://github.com/WICG/digital-credentials/pull/156/files |
Co-authored-by: Marcos Cáceres <marcosc@apple.com>
6638a72 to
2830f64
Compare
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com> Co-authored-by: Marcos Cáceres <marcosc@apple.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com> Co-authored-by: Marcos Cáceres <marcosc@apple.com>
|
Blocked on tests. |
TallTed
left a comment
There was a problem hiding this comment.
fix some incorrect uses of a
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
samuelgoto
left a comment
There was a problem hiding this comment.
LGTM
@marcoscaceres WDYT?
|
A couple of issues that come up during IIW the assumption of the API is that you get back the issued credential. @leecam mentioned there are situations where it may take a long time for issuance to happen and might need to happen in the background and eventually the RP gets somehow notified out-of-band. That doesn't seem great to me. It feels like issuance should complete under the user's control and not happen out of band. That seems really confusing for users (e.g., they have to wait for an email). Seems to defeat the purpose of this API somewhat. The other issue that came up with around certain protocols potentially calling home through the wallet, allowing for collusion between the RP and the issuer. We should probably deal with that. |
|
Discussed at 11 April meeting [notes]. |
Co-authored-by: Tim Cappalli <tim@cloudauth.dev>
Co-authored-by: Tim Cappalli <tim@cloudauth.dev>
|
Linked WebKit issue... seems we forgot to file one. We should see if there's a server imposed way to make sure bugs are files on each user agent as a precondition for merging normative changes. |
…entialGetRequest https://bugs.webkit.org/show_bug.cgi?id=304311 rdar://167115220 Reviewed by Anne van Kesteren. Renamed DigitalCredentialRequest to DigitalCredentialGetRequest, as per spec change: w3c-fedid/digital-credentials#204 * LayoutTests/http/tests/digital-credentials/digital-credential-console-messages.https-expected.txt: * Source/WebCore/CMakeLists.txt: * Source/WebCore/DerivedSources-input.xcfilelist: * Source/WebCore/DerivedSources-output.xcfilelist: * Source/WebCore/DerivedSources.make: * Source/WebCore/Headers.cmake: * Source/WebCore/Modules/identity/DigitalCredential.cpp: (WebCore::jsToCredentialRequest): (WebCore::DigitalCredential::convertObjectsToDigitalPresentationRequests): * Source/WebCore/Modules/identity/DigitalCredential.h: * Source/WebCore/Modules/identity/DigitalCredentialGetRequest.h: Renamed from Source/WebCore/Modules/identity/DigitalCredentialRequest.h. * Source/WebCore/Modules/identity/DigitalCredentialGetRequest.idl: Renamed from Source/WebCore/Modules/identity/DigitalCredentialRequest.idl. * Source/WebCore/Modules/identity/DigitalCredentialRequestOptions.h: * Source/WebCore/Modules/identity/DigitalCredentialRequestOptions.idl: * Source/WebCore/Sources.txt: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebKit/UIProcess/DigitalCredentials/WKDigitalCredentialsPicker.mm: * Source/WebKit/UIProcess/WebPageProxy.cpp: Canonical link: https://commits.webkit.org/305608@main
Closes #167
The following tasks have been completed:
Implementation commitment:
Documentation and checks
Preview | Diff