Skip to content

Add request validation #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marcoscaceres wants to merge 10 commits into from
Closed

Add request validation #156

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
533464b
Add request validation
marcoscaceres Aug 7, 2024
51eedfa
Merge branch 'main' into validate
marcoscaceres Jul 10, 2025
b2e78a0
Aggregate valid requests in a valid requests list
mohamedamir Jul 21, 2025
ea53d34
Collect valid requests in validRequests before proceeding
mohamedamir Jul 21, 2025
7b4cdde
Restrict validation to only json serialization
mohamedamir Jul 28, 2025
37f1a81
Merge remote-tracking branch 'refs/remotes/origin/validate' into vali…
mohamedamir Jul 28, 2025
c00d6cc
Update index.html
marcoscaceres Jul 28, 2025
ec6a7e7
Merge branch 'main' into validate
marcoscaceres Jul 28, 2025
40505d0
Merge branch 'main' into validate
marcoscaceres Aug 5, 2025
acd1878
Merge branch 'main' into validate
marcoscaceres Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,19 +756,24 @@ <h3>
<li>Let |requests| be |options|'s {{CredentialRequestOptions/digital}}'s
{{DigitalCredentialRequestOptions/requests}} member.
</li>
<li>If |requests| is empty, [=exception/throw=] a {{TypeError}}.
</li>
<li>Let |validRequests| be a new empty [=list=].
<li>[=List/For each=] |request| of |requests|:
<ol>
<li>[=serialize a JavaScript value to a JSON string|Serialize=]
|request| to a JSON string. [=exception/throw|Re-throw=] any
[=exception=].
<li>[=serialize a JavaScript value to a JSON string|Serialize=] |request|. [=exception/throw|Rethrow=] any exception.</li>.
</li>
<li>Let |protocol| be |requests|'s {{DigitalCredentialGetRequest/protocol}}.
</li>
<li>If |protocol| is not allowed by the user agent, [=exception/throw=] a {{NotSupportedError}} {{DOMException}}.
</li>
<li>[=list/Append=] |request| to |validRequests|.
</li>
</ol>
</li>
<li>If |validRequests| [=list/is empty=], [=exception/throw=] a {{TypeError}}.
</li>
<li>
<aside class="issue">
Details of how to actually get the [=digital credential=] are
Details of how to actually get the [=digital credential=] using the items in |validRequests| are
forthcoming.
</aside>
</li>
Expand Down
Loading