Add Web Platform Tests for Digital Credentials Issuance API#51492
Closed
mohamedamir wants to merge 5 commits into
Closed
Add Web Platform Tests for Digital Credentials Issuance API#51492mohamedamir wants to merge 5 commits into
mohamedamir wants to merge 5 commits into
Conversation
mohamedamir
commented
Mar 20, 2025
| crossOrigin: true, | ||
| expectIsAllowed: true, | ||
| }, | ||
| { |
Contributor
There was a problem hiding this comment.
Oh, I feel we should split this into two tests... I like the addition of action. That's a good idea.
Contributor
Author
There was a problem hiding this comment.
Sorry, but I don't understand your suggestion.
Could you please elaborate more on how you would like to split this?
marcoscaceres
requested changes
Mar 25, 2025
marcoscaceres
left a comment
Contributor
There was a problem hiding this comment.
Apart from splitting the files, the rest all looks great.
9 tasks
7f9a76c to
c55b899
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds web platform tests for Digital Credentials Issuance API (.create()) that are aligned with the set of test we have for the presentation API (.get())
tests for w3c-fedid/digital-credentials#204