Skip to content

tablet manager's ExecuteFetchAsDba does not allow multiple queries#18183

Merged
shlomi-noach merged 5 commits intovitessio:mainfrom
planetscale:execute-fetch-dba-nomulti
Jul 22, 2025
Merged

tablet manager's ExecuteFetchAsDba does not allow multiple queries#18183
shlomi-noach merged 5 commits intovitessio:mainfrom
planetscale:execute-fetch-dba-nomulti

Conversation

@shlomi-noach
Copy link
Copy Markdown
Contributor

@shlomi-noach shlomi-noach commented Apr 21, 2025 •
edited
Loading

Description

This is the last part of #15505 which spans multiple versions. In this final part ExecuteFetchAsDba reject any multi-query request. There is no code in v22 or above that will issue ExecuteFetchAsDba with multiple queries, seeing that the last such scenario was cleaned up in #17078.

No test changes required.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach
tablet manager ExecuteFetchAsDba does not allow multiple queries
16276fa 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach requested a review from a team April 21, 2025 05:01
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Apr 21, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Apr 21, 2025
@github-actions github-actions bot added this to the v23.0.0 milestone Apr 21, 2025
@shlomi-noach shlomi-noach removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Apr 21, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.48%. Comparing base (95dd11c) to head (2c91ae3).

Files with missing lines Patch % Lines
go/vt/vttablet/tabletmanager/rpc_query.go 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #18183   +/-   ##
=======================================
  Coverage   67.47%   67.48%           
=======================================
  Files        1607     1607           
  Lines      262872   262869    -3     
=======================================
+ Hits       177381   177388    +7     
+ Misses      85491    85481   -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dbussink
dbussink reviewed Apr 21, 2025
View reviewed changes
go/vt/vttablet/tabletmanager/rpc_query.go Outdated
if len(queries) > 1 && len(queries) != countCreate {
// See https://github.com/vitessio/vitess/issues/15505
if len(queries) > 1 {
return vterrors.Errorf(vtrpc.Code_INVALID_ARGUMENT, "multi statement queries are not supported in ExecuteFetchAsDba unless all are CREATE TABLE or CREATE VIEW")
Copy link
Copy Markdown
Member

@dbussink dbussink Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the error message here now?

Copy link
Copy Markdown
Contributor Author

@shlomi-noach shlomi-noach Apr 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops. Done.

@shlomi-noach
update error message
38a457c 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 22, 2025

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label May 22, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 29, 2025

This PR was closed because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this May 29, 2025
@shlomi-noach shlomi-noach removed the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Jul 3, 2025
@shlomi-noach shlomi-noach reopened this Jul 3, 2025
@shlomi-noach
Copy link
Copy Markdown
Contributor Author

shlomi-noach commented Jul 3, 2025

Seeking reviews.

@shlomi-noach shlomi-noach requested a review from a team July 3, 2025 15:15
@shlomi-noach shlomi-noach requested a review from dbussink July 21, 2025 12:05
@shlomi-noach shlomi-noach enabled auto-merge (squash) July 21, 2025 12:16
@shlomi-noach
Merge branch 'main' into execute-fetch-dba-nomulti
2e11f6d 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
adapt test: use ExecuteMultiFetchAsDba
2c91ae3 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
adapt test
bc7925e 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach merged commit 1b1f69b into vitessio:main Jul 22, 2025
99 of 102 checks passed
@shlomi-noach shlomi-noach deleted the execute-fetch-dba-nomulti branch July 22, 2025 07:39
morgo added a commit to morgo/vitess that referenced this pull request Jul 29, 2025
@morgo
Merge remote-tracking branch 'origin/master' into mtocker-virtual-sha…
1295e8b 
…rds-new2

* origin/master:
  Set up better dependency checks (vitessio#18508)
  bugfix: Plan group by only on top of derived tables correctly (vitessio#18505)
  Fix regression in v22 around new flag setup (vitessio#18507)
  Bump form-data from 4.0.1 to 4.0.4 in /web/vtadmin (vitessio#18473)
  Bump @babel/runtime from 7.26.0 to 7.27.6 in /web/vtadmin (vitessio#18467)
  Bump vite from 4.5.9 to 4.5.14 in /web/vtadmin (vitessio#18485)
  Fix for simple projection showing no fields (vitessio#18489)
  log.Info -> log.Infof in tabletserver for reloading ACLs (vitessio#18461)
  Fix scalar aggregation with literals in empty result sets (vitessio#18477)
  Avoid terminating atomic copy workflows on error if they are out of copy phase (vitessio#18475)
  Update runners to use cncf oracle vms (vitessio#18425)
  fix: handle aliases in UNIONs better (vitessio#18484)
  VReplication: Fix bug while reading _vt.vreplication record (vitessio#18478)
  Planner: Add comprehensive debug logging for query planner NoRewrite cases (vitessio#18476)
  Update email in Maintainers file (vitessio#18472)
  tablet manager's `ExecuteFetchAsDba` does not allow multiple queries (vitessio#18183)

Signed-off-by: Morgan Tocker <tocker@gmail.com>
@systay systay mentioned this pull request Aug 29, 2025
Merged
@BrewTestBot BrewTestBot mentioned this pull request Nov 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbussink dbussink dbussink approved these changes

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@deepthi deepthi Awaiting requested review from deepthi

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

Assignees

No one assigned

Labels

Component: schema management schemadiff and schema changes Component: VTTablet Type: Internal Cleanup

Projects

None yet

Milestone

v23.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@shlomi-noach @dbussink @harshit-gangal