Skip to content

Applyschema uses ExecuteMultiFetchAsDba#17078

Merged
deepthi merged 2 commits intovitessio:mainfrom
planetscale:applyschema-executemultifetchasdba
Nov 25, 2024
Merged

Applyschema uses ExecuteMultiFetchAsDba#17078
deepthi merged 2 commits intovitessio:mainfrom
planetscale:applyschema-executemultifetchasdba

Conversation

@shlomi-noach
Copy link
Copy Markdown
Contributor

@shlomi-noach shlomi-noach commented Oct 27, 2024 •
edited
Loading

Description

See context in #15505

In this PR ApplySchema uses ExecuteMultiFetchAsDba() instead of ExecuteFetchAsDba(). This is scheduled for v22. In v23 we will be able to clean up ExecuteFetchAsDba() as ApplySchema is the last use of ExecuteFetchAsDba() that is still allowed to pass multiple statements.

Note: hardly any tests changed, because the point is that the behavior is unchanged and that all the tests continue as expected when we switch from ExecuteFetchAsDba() to ExecuteMultiFetchAsDba().

Related Issue(s)

#15505

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach
Applyschema uses ExecuteMultiFetchAsDba
eaf628a 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach added Component: schema management schemadiff and schema changes Not a bug labels Oct 27, 2024
@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Oct 27, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 27, 2024
@github-actions github-actions bot added this to the v22.0.0 milestone Oct 27, 2024
@shlomi-noach shlomi-noach added Type: Bug and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required Not a bug labels Oct 27, 2024
@shlomi-noach
adapt tests
f34537d 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 67.15%. Comparing base (4e385ce) to head (f34537d).
Report is 62 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/schemamanager/local_controller.go 0.00% 4 Missing ⚠️
go/vt/schemamanager/tablet_executor.go 62.50% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17078      +/-   ##
==========================================
- Coverage   67.16%   67.15%   -0.01%     
==========================================
  Files        1571     1571              
  Lines      252097   252101       +4     
==========================================
- Hits       169318   169303      -15     
- Misses      82779    82798      +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@deepthi deepthi merged commit 0439d89 into vitessio:main Nov 25, 2024
@deepthi deepthi deleted the applyschema-executemultifetchasdba branch November 25, 2024 18:14
@shlomi-noach shlomi-noach mentioned this pull request Apr 21, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbussink dbussink dbussink approved these changes

@ajm188 ajm188 Awaiting requested review from ajm188

@notfelineit notfelineit Awaiting requested review from notfelineit

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

+1 more reviewer

@deepthi deepthi deepthi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: schema management schemadiff and schema changes Type: Bug

Projects

None yet

Milestone

v22.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@shlomi-noach @dbussink @deepthi