Skip to content

Update runners to use cncf oracle vms#18425

Merged
frouioui merged 1 commit intovitessio:mainfrom
jeefy:oracle-vm-runners
Jul 24, 2025
Merged

Update runners to use cncf oracle vms#18425
frouioui merged 1 commit intovitessio:mainfrom
jeefy:oracle-vm-runners

Conversation

@jeefy
Copy link
Copy Markdown
Contributor

@jeefy jeefy commented Jul 7, 2025 •
edited
Loading

Hello again!

Continuing work from the previous PRs (#17993 #17943 #17879)

Unlike the previous attempts, this is using a virtual machine defined directly from GitHub so the dependency and behavior-skew should be resolved.

That said, this will be the largest PR we've tested (in terms of jobs in parallel) so consider this a load test / WIP till we resolve any issues.

cc @koksay

EDIT: It all works! :D Please review and merge when able. Thanks!

@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Jul 7, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jul 7, 2025
@github-actions github-actions bot added this to the v23.0.0 milestone Jul 7, 2025
@jeefy jeefy force-pushed the oracle-vm-runners branch 4 times, most recently from 11dd4a7 to 62f0411 Compare July 10, 2025 15:11
@jeefy jeefy requested a review from notfelineit as a code owner July 10, 2025 15:11
@jeefy jeefy force-pushed the oracle-vm-runners branch 3 times, most recently from 97fac78 to c18befc Compare July 11, 2025 01:53
@jeefy jeefy removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jul 12, 2025
@jeefy
update runners to use cncf oracle vms
06d2270 
Signed-off-by: Jeffrey Sica <me@jeefy.dev>
@jeefy jeefy force-pushed the oracle-vm-runners branch from c18befc to 06d2270 Compare July 12, 2025 20:56
@jeefy jeefy changed the title WIP: update runners to use cncf oracle vms Update runners to use cncf oracle vms Jul 12, 2025
@jeefy
Copy link
Copy Markdown
Contributor Author

jeefy commented Jul 17, 2025

Ping! @rohit-nayak-ps @frouioui

@jeefy
Copy link
Copy Markdown
Contributor Author

jeefy commented Jul 21, 2025

New week new ping <3

@rohit-nayak-ps @frouioui @GuptaManan100

frouioui
frouioui approved these changes Jul 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was OOO for some time, this looks good to me!

@frouioui frouioui merged commit f4a735b into vitessio:main Jul 24, 2025
201 checks passed
morgo added a commit to morgo/vitess that referenced this pull request Jul 29, 2025
@morgo
Merge remote-tracking branch 'origin/master' into mtocker-virtual-sha…
1295e8b 
…rds-new2

* origin/master:
  Set up better dependency checks (vitessio#18508)
  bugfix: Plan group by only on top of derived tables correctly (vitessio#18505)
  Fix regression in v22 around new flag setup (vitessio#18507)
  Bump form-data from 4.0.1 to 4.0.4 in /web/vtadmin (vitessio#18473)
  Bump @babel/runtime from 7.26.0 to 7.27.6 in /web/vtadmin (vitessio#18467)
  Bump vite from 4.5.9 to 4.5.14 in /web/vtadmin (vitessio#18485)
  Fix for simple projection showing no fields (vitessio#18489)
  log.Info -> log.Infof in tabletserver for reloading ACLs (vitessio#18461)
  Fix scalar aggregation with literals in empty result sets (vitessio#18477)
  Avoid terminating atomic copy workflows on error if they are out of copy phase (vitessio#18475)
  Update runners to use cncf oracle vms (vitessio#18425)
  fix: handle aliases in UNIONs better (vitessio#18484)
  VReplication: Fix bug while reading _vt.vreplication record (vitessio#18478)
  Planner: Add comprehensive debug logging for query planner NoRewrite cases (vitessio#18476)
  Update email in Maintainers file (vitessio#18472)
  tablet manager's `ExecuteFetchAsDba` does not allow multiple queries (vitessio#18183)

Signed-off-by: Morgan Tocker <tocker@gmail.com>
@koksay koksay mentioned this pull request Aug 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frouioui frouioui frouioui approved these changes

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@deepthi deepthi Awaiting requested review from deepthi

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

+1 more reviewer

@notfelineit notfelineit notfelineit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: Build/CI Type: CI/Build

Projects

None yet

Milestone

v23.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jeefy @notfelineit @frouioui