Skip to content

Revert legacy PPR removal#90948

Merged
unstubbable merged 5 commits intocanaryfrom
hl/revert-ppr-removal
Mar 5, 2026
Merged

Revert legacy PPR removal#90948
unstubbable merged 5 commits intocanaryfrom
hl/revert-ppr-removal

Conversation

@unstubbable
Copy link
Contributor

@unstubbable unstubbable commented Mar 5, 2026 •
edited
Loading

This caused regressions. Apparently it was not a clean removal.

@unstubbable unstubbable force-pushed the hl/revert-ppr-removal branch from ee3a59f to 3559782 Compare March 5, 2026 21:45
@unstubbable unstubbable marked this pull request as ready for review March 5, 2026 22:01
@vercel
Copy link
Contributor

vercel bot commented Mar 5, 2026 •
edited
Loading

Notifying the following users due to files changed in this PR based on this repo's notify modifiers:

@timneutkens, @ijjk, @shuding, @huozhi:

packages/next/src/server/config.ts

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 5, 2026

Stats from current PR

🔴 1 regression

Metric Canary PR Change Trend
node_modules Size 476 MB 477 MB 🔴 +977 kB (+0%) ▁▁▁▁▁
📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ✓ ▇▁▁▁▁
Cold (Ready in log) 438ms 439ms ✓ ▇▁▁▁▁
Cold (First Request) 1.277s 1.251s ✓ ▇▃▁▃▁
Warm (Listen) 457ms 456ms ✓ ▇▁▁▁▁
Warm (Ready in log) 442ms 444ms ✓ ▆▁▁▁▁
Warm (First Request) 354ms 351ms ✓ ▆▂▂▁▂
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 457ms ✓ ▁▁█▁▁
Cold (Ready in log) 442ms 442ms ✓ ▅▆█▁▆
Cold (First Request) 1.961s 1.960s ✓ ▄▄█▂▄
Warm (Listen) 456ms 456ms ✓ ▁▁█▁▁
Warm (Ready in log) 442ms 441ms ✓ ▄▅█▁▄
Warm (First Request) 1.955s 1.958s ✓ ▄▄█▁▄

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 3.853s 3.798s ✓ ▆▁▃▁▃
Cached Build 3.839s 3.873s ✓ ▆▁▃▁▃
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.052s 14.145s ✓ ▂▂█▁▂
Cached Build 14.238s 14.282s ✓ ▁▂█▁▁
node_modules Size 476 MB 477 MB 🔴 +977 kB (+0%) ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **401 kB** → **402 kB** ⚠️ +483 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 767 B 765 B ✓
Total 767 B 765 B ✅ -2 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 450 B 452 B ✓
Total 450 B 452 B ⚠️ +2 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.54 kB N/A -
6280-HASH.js gzip 59.4 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.59 kB N/A -
e8aec2e4-HASH.js gzip 62.6 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 256 B 254 B ✓
main-HASH.js gzip 39.1 kB 39.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.59 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.55 kB -
6948ada0-HASH.js gzip N/A 62.6 kB -
9544-HASH.js gzip N/A 60.2 kB -
Total 233 kB 234 kB ⚠️ +733 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.51 kB 2.51 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.98 kB 7.98 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 254 kB 256 kB 🔴 +2.55 kB (+1%)
Total 378 kB 381 kB ⚠️ +2.7 kB
Middleware
Canary PR Change
middleware-b..fest.js gzip 617 B 614 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 43.7 kB 43.7 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 45.3 kB 45.3 kB ⚠️ +30 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B ✓
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 4.03 MB 4.07 MB 🔴 +37.9 kB (+1%)
index.pack gzip 103 kB 102 kB ✓
index.pack.old gzip 103 kB 103 kB ✓
Total 4.24 MB 4.28 MB ⚠️ +37.5 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 321 kB 322 kB ✓
app-page-exp..prod.js gzip 170 kB 171 kB ✓
app-page-tur...dev.js gzip 321 kB 322 kB ✓
app-page-tur..prod.js gzip 170 kB 171 kB ✓
app-page-tur...dev.js gzip 318 kB 318 kB ✓
app-page-tur..prod.js gzip 168 kB 169 kB ✓
app-page.run...dev.js gzip 318 kB 319 kB ✓
app-page.run..prod.js gzip 168 kB 169 kB ✓
app-route-ex...dev.js gzip 70.3 kB 70.9 kB ✓
app-route-ex..prod.js gzip 48.6 kB 49.3 kB 🔴 +631 B (+1%)
app-route-tu...dev.js gzip 70.4 kB 70.9 kB ✓
app-route-tu..prod.js gzip 48.7 kB 49.3 kB 🔴 +631 B (+1%)
app-route-tu...dev.js gzip 69.9 kB 70.5 kB ✓
app-route-tu..prod.js gzip 48.4 kB 49 kB 🔴 +626 B (+1%)
app-route.ru...dev.js gzip 69.9 kB 70.4 kB ✓
app-route.ru..prod.js gzip 48.4 kB 49 kB 🔴 +626 B (+1%)
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB ✓
pages-api.ru...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api.ru..prod.js gzip 32.9 kB 32.9 kB ✓
pages-turbo....dev.js gzip 52.6 kB 52.6 kB ✓
pages-turbo...prod.js gzip 38.5 kB 38.5 kB ✓
pages.runtim...dev.js gzip 52.6 kB 52.6 kB ✓
pages.runtim..prod.js gzip 38.5 kB 38.5 kB ✓
server.runti..prod.js gzip 61.8 kB 62 kB ✓
Total 2.83 MB 2.84 MB ⚠️ +11.3 kB
📝 Changed Files (17 files)

Files with changes:

  • app-page-exp..ntime.dev.js
  • app-page-exp..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page.runtime.dev.js
  • app-page.runtime.prod.js
  • app-route-ex..ntime.dev.js
  • app-route-ex..time.prod.js
  • app-route-tu..ntime.dev.js
  • app-route-tu..time.prod.js
  • app-route-tu..ntime.dev.js
  • app-route-tu..time.prod.js
  • app-route.runtime.dev.js
  • app-route.ru..time.prod.js
  • server.runtime.prod.js
View diffs
app-page-exp..ntime.dev.js 
failed to diff
app-page-exp..time.prod.js 
failed to diff
app-page-tur..ntime.dev.js 
failed to diff
app-page-tur..time.prod.js 
failed to diff
app-page-tur..ntime.dev.js 
failed to diff
app-page-tur..time.prod.js 
failed to diff
app-page.runtime.dev.js 
failed to diff
app-page.runtime.prod.js 
failed to diff
app-route-ex..ntime.dev.js

Diff too large to display

app-route-ex..time.prod.js

Diff too large to display

app-route-tu..ntime.dev.js

Diff too large to display

app-route-tu..time.prod.js

Diff too large to display

app-route-tu..ntime.dev.js

Diff too large to display

app-route-tu..time.prod.js

Diff too large to display

app-route.runtime.dev.js

Diff too large to display

app-route.ru..time.prod.js

Diff too large to display

server.runtime.prod.js

Diff too large to display

📎 Tarball URL 
https://vercel-packages.vercel.app/next/commits/35597824434b5a14b4feed60e0e28aaacad98b2b/next

@unstubbable unstubbable merged commit c2bba0e into canary Mar 5, 2026
157 of 158 checks passed
@unstubbable unstubbable deleted the hl/revert-ppr-removal branch March 5, 2026 22:15
devjiwonchoi added a commit that referenced this pull request Mar 6, 2026
@devjiwonchoi
Revert "Revert legacy PPR removal (#90948)"
3c83992 
This reverts commit c2bba0e.
@devjiwonchoi devjiwonchoi mentioned this pull request Mar 6, 2026
Draft
sokra pushed a commit that referenced this pull request Mar 6, 2026
@unstubbable @sokra
Revert legacy PPR removal (#90948)
e5db268 
This caused regressions. Apparently it was not a clean removal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devjiwonchoi devjiwonchoi devjiwonchoi approved these changes

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. tests type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@unstubbable @nextjs-bot @devjiwonchoi