Skip to content

Remove isRoutePPREnabled from render options and delete dead PPR branch#90713

Merged
devjiwonchoi merged 2 commits intocanaryfrom
jiwon-2026-03-01/segment-explorer
Mar 4, 2026
Merged

Remove isRoutePPREnabled from render options and delete dead PPR branch#90713
devjiwonchoi merged 2 commits intocanaryfrom
jiwon-2026-03-01/segment-explorer

Conversation

@devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Mar 1, 2026

Stacked on #90704

This PR replaces experimental.isRoutePPREnabled render options with cacheComponents and removes unused code.

Verified deployment tests pass on CI: https://github.com/vercel/next.js/actions/runs/22536405880

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 1, 2026

Stats from current PR

🟢 1 improvement

Metric Canary PR Change Trend
node_modules Size 476 MB 475 MB 🟢 412 kB (0%) ▁▁▁▁▁
📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 759ms 711ms ▁▃▁▇█
Cold (Ready in log) 747ms 705ms ▂▂▁▇█
Cold (First Request) 1.464s 1.409s ▃▃▁▇█
Warm (Listen) 810ms 763ms ▁▃▁▇█
Warm (Ready in log) 771ms 756ms ▁▃▁▇█
Warm (First Request) 525ms 592ms ▁▃▁▇█
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 508ms 457ms ▁▁▅▁▁
Cold (Ready in log) 468ms 451ms ▃▁▅▁▄
Cold (First Request) 2.063s 1.995s ▂▁▅▁▂
Warm (Listen) 456ms 508ms ▁▁▅▁▁
Warm (Ready in log) 453ms 469ms ▃▁▅▁▃
Warm (First Request) 2.064s 2.068s ▂▁▅▁▂

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 5.783s 5.736s ▁▄▁▆█
Cached Build 5.655s 5.868s ▁▄▁▆█
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.920s 14.678s ▁▁▄▁▁
Cached Build 14.828s 14.722s ▁▁▄▁▁
node_modules Size 476 MB 475 MB 🟢 412 kB (0%) ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **401 kB** → **401 kB** ✅ -30 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 770 B 762 B 🟢 8 B (-1%)
Total 770 B 762 B ✅ -8 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 450 B 452 B
Total 450 B 452 B ⚠️ +2 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.54 kB N/A -
6280-HASH.js gzip 58.8 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.59 kB N/A -
e8aec2e4-HASH.js gzip 62.6 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB
main-app-HASH.js gzip 256 B 255 B
main-HASH.js gzip 39.1 kB 39.1 kB
webpack-HASH.js gzip 1.68 kB 1.68 kB
262-HASH.js gzip N/A 4.59 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.55 kB -
6948ada0-HASH.js gzip N/A 62.6 kB -
9544-HASH.js gzip N/A 59.5 kB -
Total 233 kB 233 kB ⚠️ +698 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Total 39.4 kB 39.4 kB
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B
dynamic-HASH.js gzip 1.81 kB 1.81 kB
edge-ssr-HASH.js gzip 256 B 256 B
head-HASH.js gzip 351 B 352 B
hooks-HASH.js gzip 384 B 383 B
image-HASH.js gzip 580 B 581 B
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 2.51 kB 2.51 kB
routerDirect..HASH.js gzip 320 B 319 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 315 B 315 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Total 7.98 kB 7.98 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB
page.js gzip 254 kB 255 kB
Total 379 kB 380 kB ⚠️ +578 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 617 B 616 B
middleware-r..fest.js gzip 156 B 155 B
middleware.js gzip 43.9 kB 43.7 kB
edge-runtime..pack.js gzip 842 B 842 B
Total 45.5 kB 45.3 kB ✅ -244 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 4.04 MB 4.06 MB 🔴 +12.7 kB (+0%)
index.pack gzip 103 kB 102 kB
index.pack.old gzip 103 kB 102 kB 🟢 1.1 kB (-1%)
Total 4.25 MB 4.26 MB ⚠️ +10.7 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 321 kB 320 kB
app-page-exp..prod.js gzip 170 kB 170 kB
app-page-tur...dev.js gzip 320 kB 320 kB
app-page-tur..prod.js gzip 170 kB 170 kB
app-page-tur...dev.js gzip 317 kB 316 kB
app-page-tur..prod.js gzip 168 kB 168 kB
app-page.run...dev.js gzip 317 kB 317 kB
app-page.run..prod.js gzip 168 kB 168 kB
app-route-ex...dev.js gzip 70.8 kB 70.8 kB
app-route-ex..prod.js gzip 49.3 kB 49.3 kB
app-route-tu...dev.js gzip 70.9 kB 70.9 kB
app-route-tu..prod.js gzip 49.3 kB 49.3 kB
app-route-tu...dev.js gzip 70.5 kB 70.5 kB
app-route-tu..prod.js gzip 49 kB 49 kB
app-route.ru...dev.js gzip 70.4 kB 70.4 kB
app-route.ru..prod.js gzip 49 kB 49 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 43.2 kB 43.2 kB
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB
pages-api.ru...dev.js gzip 43.2 kB 43.2 kB
pages-api.ru..prod.js gzip 32.9 kB 32.9 kB
pages-turbo....dev.js gzip 52.6 kB 52.6 kB
pages-turbo...prod.js gzip 38.5 kB 38.5 kB
pages.runtim...dev.js gzip 52.6 kB 52.6 kB
pages.runtim..prod.js gzip 38.5 kB 38.5 kB
server.runti..prod.js gzip 61.9 kB 61.9 kB
Total 2.83 MB 2.83 MB ✅ -2.53 kB
📝 Changed Files (8 files)

Files with changes:

  • app-page-exp..ntime.dev.js
  • app-page-exp..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page.runtime.dev.js
  • app-page.runtime.prod.js
View diffs
app-page-exp..ntime.dev.js
failed to diff
app-page-exp..time.prod.js
failed to diff
app-page-tur..ntime.dev.js
failed to diff
app-page-tur..time.prod.js
failed to diff
app-page-tur..ntime.dev.js
failed to diff
app-page-tur..time.prod.js
failed to diff
app-page.runtime.dev.js
failed to diff
app-page.runtime.prod.js
failed to diff
📎 Tarball URL
https://vercel-packages.vercel.app/next/commits/424770b1a54c88efe52b56e21e142bd8c1b0d83c/next

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 1, 2026

Tests Passed

@devjiwonchoi devjiwonchoi changed the base branch from canary to jiwon-2026-02-28/pr-89648-review March 1, 2026 04:29
@devjiwonchoi devjiwonchoi force-pushed the jiwon-2026-03-01/segment-explorer branch from f467532 to aa68e3e Compare March 1, 2026 04:29
@nextjs-bot nextjs-bot added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Mar 1, 2026
@devjiwonchoi devjiwonchoi force-pushed the jiwon-2026-03-01/segment-explorer branch 3 times, most recently from 93ae32f to b2e4a2a Compare March 1, 2026 04:56
@devjiwonchoi devjiwonchoi removed the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Mar 1, 2026
@devjiwonchoi devjiwonchoi force-pushed the jiwon-2026-03-01/segment-explorer branch 2 times, most recently from 2d3a810 to 4db6f5c Compare March 1, 2026 05:00
@devjiwonchoi devjiwonchoi marked this pull request as ready for review March 1, 2026 07:30
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4db6f5ced9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

// base-server will strip them to opt into different rendering behavior.
const parsedRequestHeaders = parseRequestHeaders(req.headers, {
isRoutePPREnabled: renderOpts.experimental.isRoutePPREnabled === true,
isRoutePPREnabled: renderOpts.cacheComponents === true,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep edge requests out of PPR header parsing

renderToHTMLOrFlight now feeds parseRequestHeaders with isRoutePPREnabled derived from renderOpts.cacheComponents, which makes edge app requests look PPR-enabled whenever cacheComponents is on. Before this change, the edge template explicitly set experimental.isRoutePPREnabled to false, so edge stayed on the non-PPR behavior. That matters because this repo explicitly treats cache-components/PPR as unsupported on edge (see next-swc-loader.ts and cache-signal.ts), so routing edge requests through PPR-specific parsing/render behavior can trigger unsupported runtime paths for edge deployments.

Useful? React with 👍 / 👎.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edge not available in Cache Components

devjiwonchoi added a commit that referenced this pull request Mar 1, 2026
…h cases

After PR #90713 removed the rendering branch that creates `prerender-ppr`
stores, no code ever creates a store with `type: 'prerender-ppr'`. All switch
cases handling it are dead code.

- Delete `PrerenderStorePPR` interface and remove from `PrerenderStore` union
- Remove 78 `case 'prerender-ppr':` switch cases across 28 files
- Simplify `Postpone` component (dynamicTracking is always null now)
- Remove dead `postponeWithTracking()` call sites only reachable from prerender-ppr
- Clean up now-unused imports and dead functions
@devjiwonchoi devjiwonchoi requested a review from unstubbable March 1, 2026 08:17
// base-server will strip them to opt into different rendering behavior.
const parsedRequestHeaders = parseRequestHeaders(req.headers, {
isRoutePPREnabled: renderOpts.experimental.isRoutePPREnabled === true,
isRoutePPREnabled: renderOpts.cacheComponents === true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the option in ParseRequestHeadersOptions as well.

Base automatically changed from jiwon-2026-02-28/pr-89648-review to canary March 4, 2026 14:56
…anch

Remove the `isRoutePPREnabled` field from `RenderOptsPartial.experimental`
and all code gated behind it. Since `cacheComponents` is the only way to
enable PPR, the `isRoutePPREnabled`-gated rendering branch in app-render
was dead code (~240 lines deleted).

In the cache layer, rename the field to `isCacheComponentsEnabled` since
file-system-cache still needs the signal. In the render pipeline, replace
reads with `renderOpts.cacheComponents`.
@devjiwonchoi devjiwonchoi force-pushed the jiwon-2026-03-01/segment-explorer branch from 4db6f5c to d0635b0 Compare March 4, 2026 15:00
@devjiwonchoi devjiwonchoi enabled auto-merge (squash) March 4, 2026 15:03
@vercel
Copy link
Contributor

vercel bot commented Mar 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
next.js Error Error Mar 4, 2026 3:04pm

@devjiwonchoi devjiwonchoi merged commit 8dd8a95 into canary Mar 4, 2026
282 of 285 checks passed
@devjiwonchoi devjiwonchoi deleted the jiwon-2026-03-01/segment-explorer branch March 4, 2026 15:43
devjiwonchoi added a commit that referenced this pull request Mar 4, 2026
…h cases

After PR #90713 removed the rendering branch that creates `prerender-ppr`
stores, no code ever creates a store with `type: 'prerender-ppr'`. All switch
cases handling it are dead code.

- Delete `PrerenderStorePPR` interface and remove from `PrerenderStore` union
- Remove 78 `case 'prerender-ppr':` switch cases across 28 files
- Simplify `Postpone` component (dynamicTracking is always null now)
- Remove dead `postponeWithTracking()` call sites only reachable from prerender-ppr
- Clean up now-unused imports and dead functions
devjiwonchoi added a commit that referenced this pull request Mar 4, 2026
…h cases

After PR #90713 removed the rendering branch that creates `prerender-ppr`
stores, no code ever creates a store with `type: 'prerender-ppr'`. All switch
cases handling it are dead code.

- Delete `PrerenderStorePPR` interface and remove from `PrerenderStore` union
- Remove 78 `case 'prerender-ppr':` switch cases across 28 files
- Simplify `Postpone` component (dynamicTracking is always null now)
- Remove dead `postponeWithTracking()` call sites only reachable from prerender-ppr
- Clean up now-unused imports and dead functions
devjiwonchoi added a commit that referenced this pull request Mar 4, 2026
…90721)

Stacked on #90713

This PR removes `prerender-ppr` case handling in the codebase.

Verified deployment tests pass on CI:
https://github.com/vercel/next.js/actions/runs/22539297668
unstubbable added a commit that referenced this pull request Mar 5, 2026
unstubbable added a commit that referenced this pull request Mar 5, 2026
sokra pushed a commit that referenced this pull request Mar 6, 2026
…anch (#90713)

Stacked on #90704

This PR replaces `experimental.isRoutePPREnabled` render options with
`cacheComponents` and removes unused code.

Verified deployment tests pass on CI:
https://github.com/vercel/next.js/actions/runs/22536405880
sokra pushed a commit that referenced this pull request Mar 6, 2026
…90721)

Stacked on #90713

This PR removes `prerender-ppr` case handling in the codebase.

Verified deployment tests pass on CI:
https://github.com/vercel/next.js/actions/runs/22539297668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants