Skip to content

Clean up legacy PPR references in test fixtures#90725

Merged
devjiwonchoi merged 1 commit intocanaryfrom
jiwon-2026-03-01/cleanup-ppr-test-fixtures
Mar 4, 2026
Merged

Clean up legacy PPR references in test fixtures#90725
devjiwonchoi merged 1 commit intocanaryfrom
jiwon-2026-03-01/cleanup-ppr-test-fixtures

Conversation

@devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Mar 1, 2026 •
edited
Loading

Migrate legacy PPR tests to Cache Components

@nextjs-bot nextjs-bot added created-by: Next.js team PRs by the Next.js team. tests labels Mar 1, 2026
@devjiwonchoi devjiwonchoi force-pushed the jiwon-2026-03-01/cleanup-ppr-test-fixtures branch from 6007781 to 380ba83 Compare March 1, 2026 09:56
@devjiwonchoi devjiwonchoi changed the base branch from jiwon-2026-03-01/remove-prerender-ppr to jiwon-2026-03-01/remove-postpone-cluster March 1, 2026 09:56
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 1, 2026 •
edited
Loading

Tests Passed

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 1, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 559ms 558ms ✓ █▁▂▁▁
Cold (Ready in log) 534ms 535ms ✓ █▁▂▁▁
Cold (First Request) 1.155s 1.139s ✓ █▃▂▃▃
Warm (Listen) 559ms 558ms ✓ █▁▂▁▁
Warm (Ready in log) 529ms 532ms ✓ █▁▂▁▁
Warm (First Request) 416ms 423ms ✓ █▁▁▂▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 456ms ✓ ▁▁▁▁▁
Cold (Ready in log) 438ms 437ms ✓ ▆▆▅▅▅
Cold (First Request) 1.936s 1.955s ✓ ▃▄▂▂▃
Warm (Listen) 456ms 456ms ✓ ▁▁▁▁▁
Warm (Ready in log) 438ms 438ms ✓ ▅▅▆▅▆
Warm (First Request) 1.965s 1.941s ✓ ▃▄▃▃▃

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.938s 4.968s ✓ █▁▃▁▁
Cached Build 4.872s 4.857s ✓ █▁▃▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.001s 13.954s ✓ ▁▄▁▁▁
Cached Build 14.091s 14.022s ✓ ▁▄▁▁▁
node_modules Size 475 MB 475 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **401 kB** → **401 kB** ✅ -27 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 771 B 765 B ✓
Total 771 B 765 B ✅ -6 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 450 B 452 B ✓
Total 450 B 452 B ⚠️ +2 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.54 kB N/A -
6280-HASH.js gzip 59 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.59 kB N/A -
e8aec2e4-HASH.js gzip 62.6 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 256 B 254 B ✓
main-HASH.js gzip 39.1 kB 39.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.59 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.55 kB -
6948ada0-HASH.js gzip N/A 62.6 kB -
9544-HASH.js gzip N/A 59.8 kB -
Total 233 kB 234 kB ⚠️ +741 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.51 kB 2.51 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.98 kB 7.98 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 254 kB 255 kB ✓
Total 379 kB 380 kB ⚠️ +933 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 616 B 617 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 43.8 kB 43.9 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 45.4 kB 45.5 kB ⚠️ +58 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B ✓
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 4.05 MB 4.06 MB 🔴 +6.77 kB (+0%)
index.pack gzip 103 kB 101 kB 🟢 1.89 kB (-2%)
index.pack.old gzip 103 kB 103 kB ✓
Total 4.26 MB 4.26 MB ⚠️ +4.61 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 321 kB 321 kB ✓
app-page-exp..prod.js gzip 170 kB 170 kB ✓
app-page-tur...dev.js gzip 321 kB 321 kB ✓
app-page-tur..prod.js gzip 170 kB 170 kB ✓
app-page-tur...dev.js gzip 317 kB 317 kB ✓
app-page-tur..prod.js gzip 168 kB 168 kB ✓
app-page.run...dev.js gzip 318 kB 318 kB ✓
app-page.run..prod.js gzip 168 kB 168 kB ✓
app-route-ex...dev.js gzip 70.8 kB 70.8 kB ✓
app-route-ex..prod.js gzip 49.3 kB 49.3 kB ✓
app-route-tu...dev.js gzip 70.9 kB 70.9 kB ✓
app-route-tu..prod.js gzip 49.3 kB 49.3 kB ✓
app-route-tu...dev.js gzip 70.5 kB 70.5 kB ✓
app-route-tu..prod.js gzip 49 kB 49 kB ✓
app-route.ru...dev.js gzip 70.4 kB 70.4 kB ✓
app-route.ru..prod.js gzip 49 kB 49 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB ✓
pages-api.ru...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api.ru..prod.js gzip 32.9 kB 32.9 kB ✓
pages-turbo....dev.js gzip 52.6 kB 52.6 kB ✓
pages-turbo...prod.js gzip 38.5 kB 38.5 kB ✓
pages.runtim...dev.js gzip 52.6 kB 52.6 kB ✓
pages.runtim..prod.js gzip 38.5 kB 38.5 kB ✓
server.runti..prod.js gzip 61.9 kB 61.9 kB ✓
Total 2.83 MB 2.83 MB ✅ -2 B
📎 Tarball URL 
https://vercel-packages.vercel.app/next/commits/fb53a2d27b80bf88090b202d28d9780c607997d3/next

@devjiwonchoi devjiwonchoi marked this pull request as ready for review March 1, 2026 14:08
@devjiwonchoi devjiwonchoi requested a review from unstubbable March 1, 2026 14:08
@devjiwonchoi devjiwonchoi changed the base branch from jiwon-2026-03-01/remove-postpone-cluster to canary March 4, 2026 16:06
@devjiwonchoi devjiwonchoi force-pushed the jiwon-2026-03-01/cleanup-ppr-test-fixtures branch from 380ba83 to 65f8b9a Compare March 4, 2026 16:10
@devjiwonchoi
Clean up legacy PPR references in test fixtures
fb53a2d 
Replace `experimental: { ppr: 'incremental' }` with `cacheComponents: true`,
remove `export const experimental_ppr = true`, delete dead `it.skip` test for
`ppr: 'incremental'`, and add Suspense boundaries for cacheComponents compat.
@devjiwonchoi devjiwonchoi force-pushed the jiwon-2026-03-01/cleanup-ppr-test-fixtures branch from 65f8b9a to fb53a2d Compare March 4, 2026 16:12
@devjiwonchoi devjiwonchoi enabled auto-merge (squash) March 4, 2026 16:12
@devjiwonchoi devjiwonchoi merged commit d52d933 into canary Mar 4, 2026
412 of 416 checks passed
@devjiwonchoi devjiwonchoi deleted the jiwon-2026-03-01/cleanup-ppr-test-fixtures branch March 4, 2026 17:28
unstubbable added a commit that referenced this pull request Mar 5, 2026
@unstubbable
Revert "Clean up legacy PPR references in test fixtures (#90725)"
eec8d57 
This reverts commit d52d933.
sokra pushed a commit that referenced this pull request Mar 6, 2026
@devjiwonchoi @sokra
Clean up legacy PPR references in test fixtures (#90725)
65083c4 
Stacked on #90726

Migrate legacy PPR tests to Cache Components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@unstubbable unstubbable unstubbable approved these changes

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. tests type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devjiwonchoi @nextjs-bot @unstubbable