Skip to content

ci: add node-stream test coverage workflow#89861

Merged
timneutkens merged 6 commits intocanaryfrom
feedthejim/node-stream-05-ci
Mar 19, 2026
Merged

ci: add node-stream test coverage workflow#89861
timneutkens merged 6 commits intocanaryfrom
feedthejim/node-stream-05-ci

Conversation

@feedthejim
Copy link
Copy Markdown
Contributor

@feedthejim feedthejim commented Feb 11, 2026 •
edited by timneutkens
Loading

Summary

Run existing app-dir tests with __NEXT_USE_NODE_STREAMS=true in CI to validate the node stream rendering path alongside the default web stream path.

  • New CI job in build_and_test.yml that runs a curated set of app-dir tests with the flag enabled
  • test/use-node-streams-tests-manifest.json: manifest of tests to run in node-stream mode

Test plan

  • CI job triggers and runs tests successfully
  • Does not affect existing CI jobs

This was referenced Feb 11, 2026
Merged
Merged
Draft
@feedthejim Graphite App
Copy link
Copy Markdown
Contributor Author

feedthejim commented Feb 11, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@feedthejim feedthejim mentioned this pull request Feb 11, 2026
Draft
5 tasks
@feedthejim feedthejim force-pushed the feedthejim/node-stream-04-pipeline branch from 635593b to ba0aa8d Compare February 11, 2026 21:35
@feedthejim feedthejim force-pushed the feedthejim/node-stream-05-ci branch from 0151f68 to 898feba Compare February 11, 2026 21:35
@nextjs-bot
Copy link
Copy Markdown
Collaborator

nextjs-bot commented Feb 11, 2026 •
edited
Loading

Tests Passed

@feedthejim feedthejim force-pushed the feedthejim/node-stream-05-ci branch from 898feba to 8a01361 Compare February 11, 2026 21:41
@feedthejim feedthejim force-pushed the feedthejim/node-stream-04-pipeline branch 2 times, most recently from 4f8168c to c4c989d Compare February 11, 2026 21:46
@feedthejim feedthejim force-pushed the feedthejim/node-stream-05-ci branch from 8a01361 to e53b44e Compare February 11, 2026 21:46
This was referenced Feb 11, 2026
Merged
Merged
@feedthejim feedthejim force-pushed the feedthejim/node-stream-04-pipeline branch from c4c989d to 9efcb95 Compare February 11, 2026 21:50
@feedthejim feedthejim force-pushed the feedthejim/node-stream-05-ci branch from e53b44e to 19ee1a3 Compare February 11, 2026 21:50
@feedthejim feedthejim mentioned this pull request Feb 11, 2026
Merged
2 tasks
@feedthejim feedthejim force-pushed the feedthejim/node-stream-05-ci branch from 19ee1a3 to 437884d Compare February 11, 2026 21:56
@feedthejim feedthejim force-pushed the feedthejim/node-stream-04-pipeline branch 2 times, most recently from c7f7e91 to f7db683 Compare February 11, 2026 22:34
@feedthejim feedthejim force-pushed the feedthejim/node-stream-05-ci branch 2 times, most recently from ac80f1d to 71129f2 Compare February 11, 2026 22:45
@feedthejim feedthejim force-pushed the feedthejim/node-stream-04-pipeline branch from f7db683 to 0665da4 Compare February 11, 2026 22:45
@nextjs-bot
Copy link
Copy Markdown
Collaborator

nextjs-bot commented Feb 11, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 457ms 455ms ✓ ▅█▁▁▁
Cold (Ready in log) 456ms 455ms ✓ ▄█▁▁▁
Cold (First Request) 945ms 948ms ✓ ▃█▁▁▁
Warm (Listen) 456ms 455ms ✓ ▅█▁▁▁
Warm (Ready in log) 455ms 455ms ✓ ▃█▁▁▁
Warm (First Request) 376ms 382ms ✓ ▃█▁▁▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ✓ █▁▁▁▁
Cold (Ready in log) 436ms 437ms ✓ █▁▄▆▅
Cold (First Request) 1.920s 1.914s ✓ █▁▃▄▃
Warm (Listen) 456ms 456ms ✓ █▁▁▁▁
Warm (Ready in log) 435ms 436ms ✓ █▁▅▄▃
Warm (First Request) 1.911s 1.916s ✓ █▁▃▃▃

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.269s 4.276s ✓ ▃█▁▁▁
Cached Build 4.276s 4.255s ✓ ▃█▁▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 13.932s 13.887s ✓ █▁▁▁▁
Cached Build 13.979s 13.977s ✓ █▁▁▁▁
node_modules Size 477 MB 477 MB ✓ ██▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **402 kB** → **402 kB** ⚠️ +31 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 766 B 767 B ✓
Total 766 B 767 B ⚠️ +1 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 446 B 450 B ✓
Total 446 B 450 B ⚠️ +4 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.54 kB N/A -
6280-HASH.js gzip 59.4 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.59 kB N/A -
e8aec2e4-HASH.js gzip 62.6 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 256 B 255 B ✓
main-HASH.js gzip 39.1 kB 39.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.59 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.55 kB -
6948ada0-HASH.js gzip N/A 62.6 kB -
9544-HASH.js gzip N/A 60.2 kB -
Total 233 kB 234 kB ⚠️ +734 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.51 kB 2.51 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.98 kB 7.98 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 256 kB 256 kB ✓
Total 380 kB 381 kB ⚠️ +965 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 617 B 615 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 43.5 kB 43.7 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 45.1 kB 45.3 kB ⚠️ +212 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B ✓
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 4.06 MB 4.07 MB 🔴 +8.81 kB (+0%)
index.pack gzip 103 kB 104 kB ✓
index.pack.old gzip 103 kB 105 kB 🔴 +1.64 kB (+2%)
Total 4.27 MB 4.28 MB ⚠️ +10.9 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 322 kB 322 kB ✓
app-page-exp..prod.js gzip 171 kB 171 kB ✓
app-page-tur...dev.js gzip 322 kB 322 kB ✓
app-page-tur..prod.js gzip 171 kB 171 kB ✓
app-page-tur...dev.js gzip 318 kB 318 kB ✓
app-page-tur..prod.js gzip 169 kB 169 kB ✓
app-page.run...dev.js gzip 319 kB 319 kB ✓
app-page.run..prod.js gzip 169 kB 169 kB ✓
app-route-ex...dev.js gzip 70.9 kB 70.9 kB ✓
app-route-ex..prod.js gzip 49.3 kB 49.3 kB ✓
app-route-tu...dev.js gzip 70.9 kB 70.9 kB ✓
app-route-tu..prod.js gzip 49.3 kB 49.3 kB ✓
app-route-tu...dev.js gzip 70.5 kB 70.5 kB ✓
app-route-tu..prod.js gzip 49 kB 49 kB ✓
app-route.ru...dev.js gzip 70.4 kB 70.4 kB ✓
app-route.ru..prod.js gzip 49 kB 49 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB ✓
pages-api.ru...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api.ru..prod.js gzip 32.9 kB 32.9 kB ✓
pages-turbo....dev.js gzip 52.6 kB 52.6 kB ✓
pages-turbo...prod.js gzip 38.5 kB 38.5 kB ✓
pages.runtim...dev.js gzip 52.6 kB 52.6 kB ✓
pages.runtim..prod.js gzip 38.5 kB 38.5 kB ✓
server.runti..prod.js gzip 62 kB 62 kB ✓
Total 2.84 MB 2.84 MB ⚠️ +241 B
📝 Changed Files (9 files)

Files with changes:

  • app-page-exp..ntime.dev.js
  • app-page-exp..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page.runtime.dev.js
  • app-page.runtime.prod.js
  • server.runtime.prod.js
View diffs
app-page-exp..ntime.dev.js 
failed to diff
app-page-exp..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js 
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js 
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page.runtime.dev.js 
failed to diff
app-page.runtime.prod.js

Diff too large to display

server.runtime.prod.js

Diff too large to display

📎 Tarball URL 
https://vercel-packages.vercel.app/next/commits/449ef4c1a59723a8f4a94738eed924a2b9a9f551/next

@feedthejim feedthejim force-pushed the feedthejim/node-stream-05-ci branch from 71129f2 to c3a3b5d Compare February 12, 2026 00:59
@feedthejim feedthejim force-pushed the feedthejim/node-stream-04-pipeline branch from 0665da4 to 43acaf9 Compare February 12, 2026 00:59
@feedthejim feedthejim changed the title ci: add node-stream test coverage workflow (8/8) ci: add node-stream test coverage workflow Feb 12, 2026
@timneutkens timneutkens force-pushed the feedthejim/node-stream-05-ci branch 2 times, most recently from e2d2012 to 5aa9640 Compare February 24, 2026 14:20
@timneutkens timneutkens force-pushed the 02-24-feat_node-streams_add_config_flag_define-env_and_env_precedence_test branch from 87b3b57 to 84a63ed Compare February 24, 2026 15:05
@timneutkens timneutkens force-pushed the feedthejim/node-stream-05-ci branch from 5aa9640 to 09f55e4 Compare February 24, 2026 15:05
@timneutkens timneutkens mentioned this pull request Feb 25, 2026
Draft
@timneutkens timneutkens force-pushed the 02-24-feat_node-streams_add_config_flag_define-env_and_env_precedence_test branch from 84a63ed to f429f30 Compare March 3, 2026 11:29
@timneutkens timneutkens force-pushed the feedthejim/node-stream-05-ci branch 2 times, most recently from 2653f7a to 24f561b Compare March 3, 2026 14:56
@timneutkens timneutkens force-pushed the 02-24-feat_node-streams_add_config_flag_define-env_and_env_precedence_test branch from f429f30 to 0a8cc66 Compare March 3, 2026 14:56
@timneutkens timneutkens force-pushed the feedthejim/node-stream-05-ci branch from 24f561b to 4101209 Compare March 4, 2026 09:49
@timneutkens timneutkens force-pushed the 02-24-feat_node-streams_add_config_flag_define-env_and_env_precedence_test branch from 0a8cc66 to 4c1d651 Compare March 4, 2026 09:49
@timneutkens timneutkens force-pushed the feedthejim/node-stream-05-ci branch from 4101209 to c8e8ea6 Compare March 4, 2026 10:09
@timneutkens timneutkens force-pushed the 02-24-feat_node-streams_add_config_flag_define-env_and_env_precedence_test branch from 4c1d651 to 7cb4ec9 Compare March 4, 2026 10:09
@timneutkens timneutkens force-pushed the feedthejim/node-stream-05-ci branch from b0ba55d to 89ef013 Compare March 5, 2026 09:05
@timneutkens timneutkens force-pushed the 02-24-feat_node-streams_add_config_flag_define-env_and_env_precedence_test branch 2 times, most recently from 020652c to 8a6df95 Compare March 5, 2026 14:25
@timneutkens timneutkens force-pushed the feedthejim/node-stream-05-ci branch 2 times, most recently from 114e0d2 to 449ef4c Compare March 6, 2026 09:43
@timneutkens timneutkens force-pushed the 02-24-feat_node-streams_add_config_flag_define-env_and_env_precedence_test branch from 8a6df95 to 453658f Compare March 6, 2026 09:43
gnoff
gnoff approved these changes Mar 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gnoff gnoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can tweak which tests run easily enough so this doesn't have to block

@timneutkens timneutkens force-pushed the 02-24-feat_node-streams_add_config_flag_define-env_and_env_precedence_test branch from 453658f to e168968 Compare March 19, 2026 12:53
@timneutkens timneutkens force-pushed the feedthejim/node-stream-05-ci branch 2 times, most recently from ac0d14a to 40ba601 Compare March 19, 2026 12:56
feedthejim and others added 6 commits March 19, 2026 16:41
@feedthejim @timneutkens
ci: add node-stream test coverage workflow
e79485f 
Adds a CI job that re-runs the app-dir e2e suite with
__NEXT_USE_NODE_STREAMS=true to verify the node stream path.

Includes a test manifest that selects the relevant test globs.
@timneutkens
Remove unrelated changes
fa95159 
Moved into #90428
@timneutkens
Revert unrelated change
f36fd05
@timneutkens
Update build_and_test.yml
d22fe57
@timneutkens
Test Turbopack only
05ead21
@timneutkens
Update build_and_test.yml
87616dd
@timneutkens timneutkens mentioned this pull request Mar 19, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnoff gnoff gnoff approved these changes

@timneutkens timneutkens timneutkens approved these changes

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. tests type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@feedthejim @nextjs-bot @gnoff @timneutkens