Skip to content

test: add cache DCE guard test#90428

Open
timneutkens wants to merge 1 commit intocanaryfrom
02-24-test_add_cache_dce_guard_test
Open

test: add cache DCE guard test#90428
timneutkens wants to merge 1 commit intocanaryfrom
02-24-test_add_cache_dce_guard_test

Conversation

@timneutkens
Copy link
Copy Markdown
Member

@timneutkens timneutkens commented Feb 24, 2026 •
edited
Loading

What?

Test split out from this stack of changes: #89861. The fix has been merged already, so the test should pass as-is.

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. tests labels Feb 24, 2026
@timneutkens Graphite App
Copy link
Copy Markdown
Member Author

timneutkens commented Feb 24, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@timneutkens timneutkens marked this pull request as ready for review February 24, 2026 12:44
timneutkens added a commit that referenced this pull request Feb 24, 2026
@timneutkens
Remove unrelated changes
cded6ef 
Moved into #90428
timneutkens added a commit that referenced this pull request Feb 24, 2026
@timneutkens
Remove unrelated changes
98a4040 
Moved into #90428
vercel[bot]
vercel bot reviewed Feb 24, 2026
View reviewed changes
test/e2e/app-dir/cache-dce-guard/cache-dce-guard.test.ts
expect(exitCode).toBe(0)

// Read all sourcemaps from browser chunks and extract their source paths.
const sourcemaps = await next.readFiles('.next/static/chunks', (filename) =>
Copy link
Copy Markdown
Contributor

@vercel vercel bot Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test only reads sourcemaps from top-level .next/static/chunks directory, missing app router chunks in subdirectories like app/, which can cause false negative test results.

Fix on Vercel

timneutkens added a commit that referenced this pull request Feb 24, 2026
@timneutkens
Remove unrelated changes
7ba07fa 
Moved into #90428
@nextjs-bot
Copy link
Copy Markdown
Collaborator

nextjs-bot commented Feb 24, 2026

Failing test suites

Commit: eaa4c38 | About building and testing Next.js

pnpm test-dev test/development/app-dir/cache-only-toggle/cache-only-toggle.test.ts (job)

  • instant-mode-toggle > should show loading skeleton during SPA navigation when instant mode is on (DD)
Expand output

● instant-mode-toggle › should show loading skeleton during SPA navigation when instant mode is on

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  146 |         '[data-testid="comments-skeleton"]'
  147 |       )
> 148 |       expect(skeleton).toBe(true)
      |                        ^
  149 |     })
  150 |
  151 |     // Clean up

  at toBe (development/app-dir/cache-only-toggle/cache-only-toggle.test.ts:148:24)
  at retry (lib/next-test-utils.ts:831:14)
  at Object.<anonymous> (development/app-dir/cache-only-toggle/cache-only-toggle.test.ts:144:5)

@nextjs-bot
Copy link
Copy Markdown
Collaborator

nextjs-bot commented Feb 24, 2026

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 558ms 558ms ✓ ▁▁██▁
Cold (Ready in log) 515ms 514ms ✓ ▆▁▇█▇
Cold (First Request) 1.104s 1.113s ✓ ▇▁▅▅█
Warm (Listen) 557ms 509ms ✓ ▁▁▅█▁
Warm (Ready in log) 513ms 512ms ✓ ▁▁▇█▁
Warm (First Request) 390ms 426ms ✓ ▁▃█▇▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 507ms 507ms ✓ ████▁
Cold (Ready in log) 484ms 484ms ✓ ▅▅▆██
Cold (First Request) 2.186s 2.164s ✓ ██▃▄▅
Warm (Listen) 508ms 508ms ✓ ▅█▁▅▅
Warm (Ready in log) 485ms 482ms ✓ ▅▃▅▆▆
Warm (First Request) 2.198s 2.205s ✓ █▇▂▃▄

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.971s 5.032s ✓ ▁▂██▁
Cached Build 4.949s 4.973s ✓ ▁▂██▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 15.824s 15.857s ✓ ██▁▁▂
Cached Build 15.954s 15.978s ✓ ██▁▂▂
node_modules Size 474 MB 474 MB ✓ █████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **399 kB** → **399 kB** ✅ -23 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 769 B 763 B ✓
Total 769 B 763 B ✅ -6 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 451 B 450 B ✓
Total 451 B 450 B ✅ -1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.48 kB N/A -
6280-HASH.js gzip 57.5 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.53 kB N/A -
e8aec2e4-HASH.js gzip 62.6 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 255 B 254 B ✓
main-HASH.js gzip 39.1 kB 39.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.53 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.49 kB -
6948ada0-HASH.js gzip N/A 62.6 kB -
9544-HASH.js gzip N/A 58.3 kB -
Total 231 kB 232 kB ⚠️ +755 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.5 kB 2.5 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.97 kB ✅ -2 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 252 kB 253 kB ✓
Total 377 kB 378 kB ⚠️ +500 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 614 B 612 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 43.8 kB 43.9 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 45.4 kB 45.5 kB ⚠️ +86 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B ✓
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 3.98 MB 3.99 MB 🔴 +10.1 kB (+0%)
index.pack gzip 103 kB 102 kB ✓
index.pack.old gzip 102 kB 102 kB ✓
Total 4.18 MB 4.19 MB ⚠️ +9.12 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 318 kB 318 kB ✓
app-page-exp..prod.js gzip 168 kB 168 kB ✓
app-page-tur...dev.js gzip 318 kB 318 kB ✓
app-page-tur..prod.js gzip 168 kB 168 kB ✓
app-page-tur...dev.js gzip 314 kB 314 kB ✓
app-page-tur..prod.js gzip 166 kB 166 kB ✓
app-page.run...dev.js gzip 315 kB 315 kB ✓
app-page.run..prod.js gzip 167 kB 167 kB ✓
app-route-ex...dev.js gzip 70.7 kB 70.7 kB ✓
app-route-ex..prod.js gzip 49.1 kB 49.1 kB ✓
app-route-tu...dev.js gzip 70.7 kB 70.7 kB ✓
app-route-tu..prod.js gzip 49.2 kB 49.2 kB ✓
app-route-tu...dev.js gzip 70.3 kB 70.3 kB ✓
app-route-tu..prod.js gzip 48.9 kB 48.9 kB ✓
app-route.ru...dev.js gzip 70.2 kB 70.2 kB ✓
app-route.ru..prod.js gzip 48.9 kB 48.9 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB ✓
pages-api.ru...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api.ru..prod.js gzip 32.8 kB 32.8 kB ✓
pages-turbo....dev.js gzip 52.5 kB 52.5 kB ✓
pages-turbo...prod.js gzip 38.5 kB 38.5 kB ✓
pages.runtim...dev.js gzip 52.5 kB 52.5 kB ✓
pages.runtim..prod.js gzip 38.4 kB 38.4 kB ✓
server.runti..prod.js gzip 62 kB 62 kB ✓
Total 2.81 MB 2.81 MB ✅ -2 B
📎 Tarball URL 
next@https://vercel-packages.vercel.app/next/prs/90428/next

timneutkens added a commit that referenced this pull request Feb 24, 2026
@timneutkens
Remove unrelated changes
3d08798 
Moved into #90428
timneutkens added a commit that referenced this pull request Feb 24, 2026
@timneutkens
Remove unrelated changes
1f8bd5f 
Moved into #90428
timneutkens added a commit that referenced this pull request Feb 24, 2026
@timneutkens
Remove unrelated changes
1ed5d00 
Moved into #90428
timneutkens added a commit that referenced this pull request Feb 24, 2026
@timneutkens
Remove unrelated changes
3dca6f3 
Moved into #90428
zonacryptocoin pushed a commit to zonacryptocoin/portofolio that referenced this pull request Mar 11, 2026
@timneutkens
Remove unrelated changes
2ebee7c 
Moved into vercel/next.js#90428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vercel vercel[bot] vercel[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timneutkens @nextjs-bot