Skip to content

feat(node-streams): add config flag, define-env, and env precedence test#90427

Merged
timneutkens merged 7 commits intocanaryfrom
02-24-feat_node-streams_add_config_flag_define-env_and_env_precedence_test
Mar 19, 2026
Merged

feat(node-streams): add config flag, define-env, and env precedence test#90427
timneutkens merged 7 commits intocanaryfrom
02-24-feat_node-streams_add_config_flag_define-env_and_env_precedence_test

Conversation

@timneutkens
Copy link
Copy Markdown
Member

@timneutkens timneutkens commented Feb 24, 2026 •
edited
Loading

What?

Split out these changes from #89859. Only adds more plumbing for future Node.js streams feature.

@timneutkens timneutkens mentioned this pull request Feb 24, 2026
Merged
@timneutkens Graphite App
Copy link
Copy Markdown
Member Author

timneutkens commented Feb 24, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@timneutkens timneutkens mentioned this pull request Feb 24, 2026
Closed
@timneutkens timneutkens marked this pull request as ready for review February 24, 2026 12:34
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Feb 24, 2026 •
edited
Loading

Notifying the following users due to files changed in this PR based on this repo's notify modifiers:

@ijjk, @shuding, @huozhi:

packages/next/src/server/config.ts

This was referenced Feb 24, 2026
Closed
Merged
@timneutkens timneutkens force-pushed the 02-24-refactor_update_module.compiled.js_for_node_stream_support branch from 89eb403 to 7c95707 Compare February 24, 2026 13:16
@timneutkens timneutkens force-pushed the 02-24-feat_node-streams_add_config_flag_define-env_and_env_precedence_test branch 2 times, most recently from 54d7ab5 to e9d98ed Compare February 24, 2026 13:46
@nextjs-bot
Copy link
Copy Markdown
Collaborator

nextjs-bot commented Feb 24, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ✓ ▅█▁▁▁
Cold (Ready in log) 456ms 457ms ✓ ▄█▁▁▁
Cold (First Request) 943ms 938ms ✓ ▃█▁▁▁
Warm (Listen) 456ms 456ms ✓ ▅█▁▁▁
Warm (Ready in log) 458ms 457ms ✓ ▃█▁▁▁
Warm (First Request) 383ms 379ms ✓ ▃█▁▁▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ✓ █▁▁▁▁
Cold (Ready in log) 438ms 438ms ✓ █▁▄▆▅
Cold (First Request) 1.941s 1.942s ✓ █▁▃▄▃
Warm (Listen) 457ms 456ms ✓ █▁▁▁▁
Warm (Ready in log) 437ms 436ms ✓ █▁▅▄▃
Warm (First Request) 1.935s 1.941s ✓ █▁▃▃▃

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.191s 4.208s ✓ ▃█▁▁▁
Cached Build 4.206s 4.207s ✓ ▃█▁▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.045s 14.034s ✓ █▁▁▁▁
Cached Build 14.099s 14.114s ✓ █▁▁▁▁
node_modules Size 477 MB 477 MB ✓ ██▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **402 kB** → **402 kB** ⚠️ +31 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 766 B 767 B ✓
Total 766 B 767 B ⚠️ +1 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 446 B 450 B ✓
Total 446 B 450 B ⚠️ +4 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.54 kB N/A -
6280-HASH.js gzip 59.4 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.59 kB N/A -
e8aec2e4-HASH.js gzip 62.6 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 255 B 254 B ✓
main-HASH.js gzip 39.1 kB 39.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.59 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.55 kB -
6948ada0-HASH.js gzip N/A 62.6 kB -
9544-HASH.js gzip N/A 60.2 kB -
Total 233 kB 234 kB ⚠️ +734 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.51 kB 2.51 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.98 kB 7.98 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 256 kB 256 kB ✓
Total 380 kB 381 kB ⚠️ +968 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 618 B 614 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 43.5 kB 43.7 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 45.2 kB 45.3 kB ⚠️ +137 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B ✓
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 4.07 MB 4.07 MB ✓
index.pack gzip 103 kB 103 kB ✓
index.pack.old gzip 103 kB 102 kB 🟢 1.2 kB (-1%)
Total 4.27 MB 4.27 MB ⚠️ +1.24 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 322 kB 322 kB ✓
app-page-exp..prod.js gzip 171 kB 171 kB ✓
app-page-tur...dev.js gzip 322 kB 322 kB ✓
app-page-tur..prod.js gzip 171 kB 171 kB ✓
app-page-tur...dev.js gzip 318 kB 318 kB ✓
app-page-tur..prod.js gzip 169 kB 169 kB ✓
app-page.run...dev.js gzip 319 kB 319 kB ✓
app-page.run..prod.js gzip 169 kB 169 kB ✓
app-route-ex...dev.js gzip 70.9 kB 70.9 kB ✓
app-route-ex..prod.js gzip 49.3 kB 49.3 kB ✓
app-route-tu...dev.js gzip 70.9 kB 70.9 kB ✓
app-route-tu..prod.js gzip 49.3 kB 49.3 kB ✓
app-route-tu...dev.js gzip 70.5 kB 70.5 kB ✓
app-route-tu..prod.js gzip 49 kB 49 kB ✓
app-route.ru...dev.js gzip 70.4 kB 70.4 kB ✓
app-route.ru..prod.js gzip 49 kB 49 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB ✓
pages-api.ru...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api.ru..prod.js gzip 32.9 kB 32.9 kB ✓
pages-turbo....dev.js gzip 52.6 kB 52.6 kB ✓
pages-turbo...prod.js gzip 38.5 kB 38.5 kB ✓
pages.runtim...dev.js gzip 52.6 kB 52.6 kB ✓
pages.runtim..prod.js gzip 38.5 kB 38.5 kB ✓
server.runti..prod.js gzip 62 kB 62 kB ✓
Total 2.84 MB 2.84 MB ⚠️ +235 B
📝 Changed Files (9 files)

Files with changes:

  • app-page-exp..ntime.dev.js
  • app-page-exp..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page.runtime.dev.js
  • app-page.runtime.prod.js
  • server.runtime.prod.js
View diffs
app-page-exp..ntime.dev.js 
failed to diff
app-page-exp..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js 
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js 
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page.runtime.dev.js 
failed to diff
app-page.runtime.prod.js

Diff too large to display

server.runtime.prod.js

Diff too large to display

📎 Tarball URL 
https://vercel-packages.vercel.app/next/commits/453658f8f4492f3e5e7e9ffccd2bf305ae258021/next

@timneutkens timneutkens changed the base branch from 02-24-refactor_update_module.compiled.js_for_node_stream_support to graphite-base/90427 February 24, 2026 15:05
@timneutkens timneutkens force-pushed the 02-24-feat_node-streams_add_config_flag_define-env_and_env_precedence_test branch from 87b3b57 to 84a63ed Compare February 24, 2026 15:05
@timneutkens timneutkens mentioned this pull request Feb 25, 2026
Draft
@timneutkens timneutkens force-pushed the 02-24-feat_node-streams_add_config_flag_define-env_and_env_precedence_test branch from 84a63ed to f429f30 Compare March 3, 2026 11:29
@timneutkens timneutkens force-pushed the graphite-base/90427 branch from 5502bf8 to 8e99bd2 Compare March 3, 2026 11:29
@timneutkens timneutkens changed the base branch from graphite-base/90427 to 02-24-refactor_extract_build_infra_and_alias_changes March 3, 2026 11:29
@timneutkens timneutkens requested review from feedthejim and gnoff March 3, 2026 11:53
@timneutkens timneutkens force-pushed the 02-24-refactor_extract_build_infra_and_alias_changes branch from 8e99bd2 to 93323a7 Compare March 3, 2026 14:56
@timneutkens timneutkens force-pushed the 02-24-feat_node-streams_add_config_flag_define-env_and_env_precedence_test branch 2 times, most recently from 0a8cc66 to 4c1d651 Compare March 4, 2026 09:49
@timneutkens timneutkens force-pushed the 02-24-refactor_extract_build_infra_and_alias_changes branch from 93323a7 to 3f69081 Compare March 4, 2026 09:49
@timneutkens timneutkens force-pushed the 02-24-feat_node-streams_add_config_flag_define-env_and_env_precedence_test branch from 4c1d651 to 7cb4ec9 Compare March 4, 2026 10:09
@timneutkens timneutkens force-pushed the 02-24-refactor_extract_build_infra_and_alias_changes branch from bf78de1 to 77c6ffb Compare March 5, 2026 09:05
@timneutkens timneutkens force-pushed the 02-24-feat_node-streams_add_config_flag_define-env_and_env_precedence_test branch from 7cb4ec9 to 020652c Compare March 5, 2026 09:05
@timneutkens timneutkens force-pushed the 02-24-refactor_extract_build_infra_and_alias_changes branch from 77c6ffb to d520893 Compare March 5, 2026 14:25
@timneutkens timneutkens force-pushed the 02-24-feat_node-streams_add_config_flag_define-env_and_env_precedence_test branch from 020652c to 8a6df95 Compare March 5, 2026 14:25
@timneutkens timneutkens force-pushed the 02-24-refactor_extract_build_infra_and_alias_changes branch from d520893 to 50efa89 Compare March 6, 2026 09:43
@timneutkens timneutkens force-pushed the 02-24-feat_node-streams_add_config_flag_define-env_and_env_precedence_test branch from 8a6df95 to 453658f Compare March 6, 2026 09:43
Base automatically changed from 02-24-refactor_extract_build_infra_and_alias_changes to canary March 19, 2026 12:36
@timneutkens timneutkens force-pushed the 02-24-feat_node-streams_add_config_flag_define-env_and_env_precedence_test branch from 453658f to e168968 Compare March 19, 2026 12:53
@timneutkens timneutkens enabled auto-merge (squash) March 19, 2026 13:09
@nextjs-bot
Copy link
Copy Markdown
Collaborator

nextjs-bot commented Mar 19, 2026 •
edited
Loading

Tests Passed

@timneutkens timneutkens merged commit c597272 into canary Mar 19, 2026
402 of 412 checks passed
@timneutkens timneutkens deleted the 02-24-feat_node-streams_add_config_flag_define-env_and_env_precedence_test branch March 19, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gnoff gnoff gnoff approved these changes

@feedthejim feedthejim Awaiting requested review from feedthejim

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. tests type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timneutkens @nextjs-bot @gnoff