Skip to content

Turbopack: MappedReadRef should be Send and Sync #88558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sokra wants to merge 3 commits into
base: sokra/remove-reverse-task-cache
Choose a base branch
from
Open

Turbopack: MappedReadRef should be Send and Sync #88558

sokra wants to merge 3 commits into from
+7 −3

Conversation

@sokra
Copy link
Member

@sokra sokra commented Jan 14, 2026 •
edited
Loading

What?

To be able to used MappedReadRefs in async context, they need to be Send.

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jan 14, 2026
This was referenced Jan 14, 2026
Open
Open
Open
Open
Open
Open
@sokra Graphite App
Copy link
Member Author

sokra commented Jan 14, 2026 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 14, 2026
Open
Open
Open
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 14, 2026

Allow CI Workflow Run

  • approve CI run for commit: 2f6fcdc

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 14, 2026

Allow CI Workflow Run

  • approve CI run for commit: 2f6fcdc

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

vercel[bot]
vercel bot reviewed Jan 14, 2026
View reviewed changes
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 14, 2026 •
edited
Loading

Stats from current PR

🟢 2 improvements

Metric Canary PR Change Trend
Cold (First Request) 1.107s 888ms 🟢 219ms (-20%) ▇█▇█▇
Webpack Warm (First Request) 2.064s 1.942s 🟢 122ms (-6%) ▃▂▂▃▂
📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 455ms 454ms ✓ ▁█▁▁▁
Cold (Ready in log) 438ms 449ms ✓ ▆█▆▆▅
Cold (First Request) 1.107s 888ms 🟢 219ms (-20%) ▇█▇█▇
Warm (Listen) 456ms 456ms ✓ ▁▅▁▁▁
Warm (Ready in log) 444ms 446ms ✓ ▁▃▁▁▁
Warm (First Request) 351ms 357ms ✓ ▂▆▁▆▆
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 507ms 508ms ✓ ▁▁▁▁▁
Cold (Ready in log) 486ms 486ms ✓ ▅▄▅▄▄
Cold (First Request) 1.990s 1.950s ✓ ▃▂▃▂▂
Warm (Listen) 509ms 506ms ✓ ▁▁▁▁▁
Warm (Ready in log) 486ms 464ms ✓ ▅▃▄▅▄
Warm (First Request) 2.064s 1.942s 🟢 122ms (-6%) ▃▂▂▃▂

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 3.986s 3.999s ✓ ▁▄▁▂▁
Cached Build 3.930s 4.024s ✓ ▁▄▁▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 15.173s 15.011s ✓ ▁▁▁▁▁
Cached Build 15.477s 15.628s ✓ ▁▁▁▁▁
node_modules Size 458 MB 458 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **430 kB** → **430 kB** ✅ -86 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 788 B 787 B ✓
Total 788 B 787 B ✅ -1 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 451 B 450 B ✓
Total 451 B 450 B ✅ -1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2086.HASH.js gzip 169 B N/A -
2161-HASH.js gzip 5.41 kB N/A -
2747-HASH.js gzip 4.48 kB N/A -
4322-HASH.js gzip 52.3 kB N/A -
ec793fe8-HASH.js gzip 62.3 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB ✓
main-app-HASH.js gzip 251 B 253 B ✓
main-HASH.js gzip 38.6 kB 38.9 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
1596.HASH.js gzip N/A 169 B -
2658-HASH.js gzip N/A 51.9 kB -
6349-HASH.js gzip N/A 4.46 kB -
7019-HASH.js gzip N/A 5.43 kB -
b17a3386-HASH.js gzip N/A 62.3 kB -
Total 225 kB 225 kB ✅ -12 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B ✓
_error-HASH.js gzip 182 B 182 B ✓
css-HASH.js gzip 336 B 335 B ✓
dynamic-HASH.js gzip 1.8 kB 1.8 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 352 B 349 B ✓
hooks-HASH.js gzip 385 B 384 B ✓
image-HASH.js gzip 580 B 580 B ✓
index-HASH.js gzip 259 B 258 B ✓
link-HASH.js gzip 2.5 kB 2.51 kB ✓
routerDirect..HASH.js gzip 319 B 317 B ✓
script-HASH.js gzip 385 B 387 B ✓
withRouter-HASH.js gzip 316 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.96 kB ✅ -8 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 242 kB 237 kB 🟢 4.88 kB (-2%)
Total 366 kB 361 kB ✅ -4.87 kB
Middleware
Canary PR Change
middleware-b..fest.js gzip 655 B 652 B ✓
middleware-r..fest.js gzip 155 B 156 B ✓
middleware.js gzip 33.1 kB 33.2 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.8 kB 34.9 kB ⚠️ +113 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 738 B 738 B ✓
Total 738 B 738 B ✓
Build Cache
Canary PR Change
0.pack gzip 3.66 MB 3.67 MB 🔴 +8.23 kB (+0%)
index.pack gzip 100 kB 101 kB 🔴 +1.47 kB (+1%)
index.pack.old gzip 99.7 kB 100 kB ✓
Total 3.86 MB 3.87 MB ⚠️ +10.1 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 303 kB 303 kB ✓
app-page-exp..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 303 kB 303 kB ✓
app-page-tur..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 300 kB 300 kB ✓
app-page-tur..prod.js gzip 156 kB 156 kB ✓
app-page.run...dev.js gzip 300 kB 300 kB ✓
app-page.run..prod.js gzip 156 kB 156 kB ✓
app-route-ex...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-ex..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-tu..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.4 kB 68.4 kB ✓
app-route-tu..prod.js gzip 47.4 kB 47.4 kB ✓
app-route.ru...dev.js gzip 68.4 kB 68.4 kB ✓
app-route.ru..prod.js gzip 47.3 kB 47.3 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 41.2 kB 41.2 kB ✓
pages-api-tu..prod.js gzip 31.3 kB 31.3 kB ✓
pages-api.ru...dev.js gzip 41.1 kB 41.1 kB ✓
pages-api.ru..prod.js gzip 31.2 kB 31.2 kB ✓
pages-turbo....dev.js gzip 50.8 kB 50.8 kB ✓
pages-turbo...prod.js gzip 38.2 kB 38.2 kB ✓
pages.runtim...dev.js gzip 50.7 kB 50.7 kB ✓
pages.runtim..prod.js gzip 38.2 kB 38.2 kB ✓
server.runti..prod.js gzip 62.2 kB 62.2 kB ✓
Total 2.69 MB 2.69 MB ✅ -1 B

@sokra sokra marked this pull request as ready for review January 15, 2026 07:36
@sokra sokra requested a review from mischnic January 15, 2026 07:58
@sokra sokra force-pushed the sokra/selective-read-send branch from 2f6fcdc to 77dea0d Compare January 15, 2026 07:59
@sokra sokra force-pushed the sokra/remove-reverse-task-cache branch from 5b650b7 to 4d87f6c Compare January 15, 2026 07:59
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 15, 2026 •
edited
Loading

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing sokra/selective-read-send (53341fe) with sokra/remove-reverse-task-cache (9536af0)

Summary

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@sokra sokra force-pushed the sokra/selective-read-send branch from 77dea0d to ea2c9d1 Compare January 15, 2026 10:51
@sokra sokra force-pushed the sokra/remove-reverse-task-cache branch from 4d87f6c to 05fccdb Compare January 15, 2026 10:51
@sokra sokra force-pushed the sokra/selective-read-send branch from ea2c9d1 to f25f974 Compare January 15, 2026 18:37
@sokra sokra force-pushed the sokra/remove-reverse-task-cache branch from 1347646 to 9536af0 Compare January 15, 2026 19:21
@sokra sokra force-pushed the sokra/selective-read-send branch from f25f974 to 53341fe Compare January 15, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vercel vercel[bot] vercel[bot] left review comments

@mischnic mischnic mischnic approved these changes

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sokra @nextjs-bot @mischnic