Skip to content

Turbopack: Consistency for compute_async_module_info #88409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sokra wants to merge 1 commit into
base: sokra/module-graph-consistency
Choose a base branch
from
Open

Turbopack: Consistency for compute_async_module_info #88409

sokra wants to merge 1 commit into from
+21 −12

Conversation

@sokra
Copy link
Member

@sokra sokra commented Jan 12, 2026 •
edited
Loading

What?

Use strongly consistent reads for compute_async_module_info to avoid double execution.

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jan 12, 2026
This was referenced Jan 12, 2026
Merged
Open
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
@sokra Graphite App
Copy link
Member Author

sokra commented Jan 12, 2026 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 12, 2026
Draft
Open
Open
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 12, 2026

Allow CI Workflow Run

  • approve CI run for commit: 2187e6b

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 12, 2026

Allow CI Workflow Run

  • approve CI run for commit: 2187e6b

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 12, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ✓ ▁█▁▁▁
Cold (Ready in log) 439ms 440ms ✓ ▆█▆▆▅
Cold (First Request) 1.146s 1.126s ✓ ▇█▇█▇
Warm (Listen) 456ms 456ms ✓ ▁▅▁▁▁
Warm (Ready in log) 443ms 443ms ✓ ▁▃▁▁▁
Warm (First Request) 344ms 345ms ✓ ▂▆▁▆▆
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 506ms 507ms ✓ ▁▁▁▁▁
Cold (Ready in log) 464ms 462ms ✓ ▅▄▅▄▄
Cold (First Request) 1.873s 1.891s ✓ ▃▂▃▂▂
Warm (Listen) 508ms 457ms ✓ ▁▁▁▁▁
Warm (Ready in log) 465ms 459ms ✓ ▅▃▄▅▄
Warm (First Request) 1.885s 1.922s ✓ ▃▂▂▃▂

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.113s 4.136s ✓ ▁▄▁▂▁
Cached Build 4.122s 4.026s ✓ ▁▄▁▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.590s 14.556s ✓ ▁▁▁▁▁
Cached Build 14.666s 14.545s ✓ ▁▁▁▁▁
node_modules Size 458 MB 458 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **430 kB** → **430 kB** ✅ -86 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 788 B 787 B ✓
Total 788 B 787 B ✅ -1 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 451 B 450 B ✓
Total 451 B 450 B ✅ -1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2086.HASH.js gzip 169 B N/A -
2161-HASH.js gzip 5.41 kB N/A -
2747-HASH.js gzip 4.48 kB N/A -
4322-HASH.js gzip 52.3 kB N/A -
ec793fe8-HASH.js gzip 62.3 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB ✓
main-app-HASH.js gzip 251 B 254 B 🔴 +3 B (+1%)
main-HASH.js gzip 38.6 kB 38.9 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
1596.HASH.js gzip N/A 169 B -
2658-HASH.js gzip N/A 51.9 kB -
6349-HASH.js gzip N/A 4.46 kB -
7019-HASH.js gzip N/A 5.43 kB -
b17a3386-HASH.js gzip N/A 62.3 kB -
Total 225 kB 225 kB ✅ -11 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B ✓
_error-HASH.js gzip 182 B 182 B ✓
css-HASH.js gzip 336 B 335 B ✓
dynamic-HASH.js gzip 1.8 kB 1.8 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 352 B 349 B ✓
hooks-HASH.js gzip 385 B 384 B ✓
image-HASH.js gzip 580 B 580 B ✓
index-HASH.js gzip 259 B 258 B ✓
link-HASH.js gzip 2.5 kB 2.51 kB ✓
routerDirect..HASH.js gzip 319 B 317 B ✓
script-HASH.js gzip 385 B 387 B ✓
withRouter-HASH.js gzip 316 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.96 kB ✅ -8 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 242 kB 237 kB 🟢 4.86 kB (-2%)
Total 366 kB 362 kB ✅ -4.84 kB
Middleware
Canary PR Change
middleware-b..fest.js gzip 654 B 651 B ✓
middleware-r..fest.js gzip 155 B 156 B ✓
middleware.js gzip 33.2 kB 33.3 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.8 kB 34.9 kB ⚠️ +84 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 738 B 738 B ✓
Total 738 B 738 B ✓
Build Cache
Canary PR Change
0.pack gzip 3.66 MB 3.66 MB ✓
index.pack gzip 101 kB 99.4 kB 🟢 1.62 kB (-2%)
index.pack.old gzip 100 kB 98.8 kB 🟢 1.34 kB (-1%)
Total 3.86 MB 3.86 MB ⚠️ +296 B

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 303 kB 303 kB ✓
app-page-exp..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 303 kB 303 kB ✓
app-page-tur..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 300 kB 300 kB ✓
app-page-tur..prod.js gzip 156 kB 156 kB ✓
app-page.run...dev.js gzip 300 kB 300 kB ✓
app-page.run..prod.js gzip 156 kB 156 kB ✓
app-route-ex...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-ex..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-tu..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.4 kB 68.4 kB ✓
app-route-tu..prod.js gzip 47.4 kB 47.4 kB ✓
app-route.ru...dev.js gzip 68.4 kB 68.4 kB ✓
app-route.ru..prod.js gzip 47.3 kB 47.3 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 41.2 kB 41.2 kB ✓
pages-api-tu..prod.js gzip 31.3 kB 31.3 kB ✓
pages-api.ru...dev.js gzip 41.1 kB 41.1 kB ✓
pages-api.ru..prod.js gzip 31.2 kB 31.2 kB ✓
pages-turbo....dev.js gzip 50.8 kB 50.8 kB ✓
pages-turbo...prod.js gzip 38.2 kB 38.2 kB ✓
pages.runtim...dev.js gzip 50.7 kB 50.7 kB ✓
pages.runtim..prod.js gzip 38.2 kB 38.2 kB ✓
server.runti..prod.js gzip 62.2 kB 62.2 kB ✓
Total 2.69 MB 2.69 MB ✅ -1 B

@sokra sokra force-pushed the sokra/module-graph-consistency branch from 965d41d to f872016 Compare January 13, 2026 15:43
@sokra sokra force-pushed the sokra/compute-async-module-info-consistency branch from 2187e6b to dfa89fe Compare January 13, 2026 15:43
@sokra sokra mentioned this pull request Jan 13, 2026
Open
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 13, 2026 •
edited
Loading

Failing test suites

Commit: dfa89fe | About building and testing Next.js

pnpm test-dev test/e2e/app-dir/next-config-ts-native-ts/import-from-node-modules/next-config-ts-import-from-node-modules-cjs.test.ts (job)

  • next-config-ts-type-error-esm > should throw with type error on build (ESM) (DD)
Expand output

● next-config-ts-type-error-esm › should throw with type error on build (ESM)

FetchError: request to http://localhost:36383/ failed, reason: socket hang up

  at ClientRequest.<anonymous> (../node_modules/.pnpm/node-fetch@2.6.7_encoding@0.1.13/node_modules/node-fetch/lib/index.js:1491:11)

pnpm test-dev test/e2e/app-dir/next-config-ts-native-ts/export-as-default/next-config-ts-export-as-default-esm.test.ts (job)

  • next-config-ts-type-error-cjs > should throw with type error on build (CJS) (DD)
Expand output

● next-config-ts-type-error-cjs › should throw with type error on build (CJS)

FetchError: request to http://localhost:37917/ failed, reason: socket hang up

  at ClientRequest.<anonymous> (../node_modules/.pnpm/node-fetch@2.6.7_encoding@0.1.13/node_modules/node-fetch/lib/index.js:1491:11)

pnpm test-dev test/e2e/app-dir/next-config-ts-native-ts/export-default/next-config-ts-export-default-cjs.test.ts (job)

  • next-config-ts-type-error-esm > should throw with type error on build (ESM) (DD)
Expand output

● next-config-ts-type-error-esm › should throw with type error on build (ESM)

FetchError: request to http://localhost:43279/ failed, reason: socket hang up

  at ClientRequest.<anonymous> (../node_modules/.pnpm/node-fetch@2.6.7_encoding@0.1.13/node_modules/node-fetch/lib/index.js:1491:11)

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 13, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing sokra/compute-async-module-info-consistency (d431fb8) with sokra/module-graph-consistency (bf897af)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on sokra/module-graph-consistency (cea0b88) during the generation of this report, so cd51642 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@sokra sokra force-pushed the sokra/compute-async-module-info-consistency branch from dfa89fe to 979bcab Compare January 13, 2026 16:40
@sokra sokra force-pushed the sokra/module-graph-consistency branch from f872016 to 7f4e685 Compare January 13, 2026 16:40
@sokra sokra marked this pull request as ready for review January 13, 2026 16:40
@sokra sokra changed the title Consistency for compute_async_module_info Turbopack: Consistency for compute_async_module_info Jan 13, 2026
@sokra sokra force-pushed the sokra/module-graph-consistency branch from 7f4e685 to a70d6f0 Compare January 13, 2026 20:25
@sokra sokra force-pushed the sokra/compute-async-module-info-consistency branch from 979bcab to 3d7469a Compare January 13, 2026 20:25
@sokra sokra requested a review from mischnic January 13, 2026 23:35
@sokra sokra force-pushed the sokra/module-graph-consistency branch from a70d6f0 to cc11d10 Compare January 14, 2026 20:08
@sokra sokra force-pushed the sokra/compute-async-module-info-consistency branch from 3d7469a to 164804e Compare January 14, 2026 20:08
This was referenced Jan 14, 2026
Open
Open
Open
Open
@sokra sokra force-pushed the sokra/module-graph-consistency branch from cc11d10 to d8ab648 Compare January 15, 2026 07:59
@sokra sokra force-pushed the sokra/compute-async-module-info-consistency branch from 164804e to 55a43d8 Compare January 15, 2026 07:59
@sokra sokra force-pushed the sokra/module-graph-consistency branch from d8ab648 to b53ac2f Compare January 15, 2026 10:51
@sokra sokra force-pushed the sokra/compute-async-module-info-consistency branch from 55a43d8 to 5ca3a00 Compare January 15, 2026 10:51
@sokra sokra force-pushed the sokra/module-graph-consistency branch from b53ac2f to bf897af Compare January 15, 2026 18:37
@sokra sokra force-pushed the sokra/compute-async-module-info-consistency branch from 5ca3a00 to 5dc9d8d Compare January 15, 2026 18:37
@sokra sokra force-pushed the sokra/module-graph-consistency branch from bf897af to cea0b88 Compare January 15, 2026 19:19
@sokra sokra force-pushed the sokra/compute-async-module-info-consistency branch from 5dc9d8d to d431fb8 Compare January 15, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mischnic mischnic mischnic approved these changes

+1 more reviewer

@naveenkarmegam naveenkarmegam naveenkarmegam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sokra @nextjs-bot @mischnic @naveenkarmegam