Skip to content

Turbopack: replace is_reference_used with unused_references set #88304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sokra merged 1 commit into from
Jan 13, 2026
Merged

Turbopack: replace is_reference_used with unused_references set #88304

sokra merged 1 commit into from
Jan 13, 2026

Conversation

@sokra
Copy link
Member

@sokra sokra commented Jan 9, 2026 •
edited
Loading

What?

Replaces is_reference_used with unused_references and uses the new keyed invalidation. This avoid having a is_reference_used for each reference in the application

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jan 9, 2026
@sokra Graphite App
Copy link
Member Author

sokra commented Jan 9, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sokra sokra mentioned this pull request Jan 9, 2026
Merged
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 9, 2026

Allow CI Workflow Run

  • approve CI run for commit: 365dd81

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

This was referenced Jan 9, 2026
Open
Merged
Merged
Merged
Merged
vercel[bot]
vercel bot reviewed Jan 9, 2026
View reviewed changes
@sokra sokra requested a review from mischnic January 9, 2026 07:58
@sokra sokra marked this pull request as ready for review January 9, 2026 08:03
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 9, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ✓ ▁▁▁█▁
Cold (Ready in log) 436ms 437ms ✓ ▂▁▁█▁
Cold (First Request) 1.146s 1.155s ✓ ▄▁▂█▁
Warm (Listen) 456ms 456ms ✓ ▁▁▁█▁
Warm (Ready in log) 442ms 440ms ✓ ▁▁▁█▁
Warm (First Request) 339ms 338ms ✓ ▂▁▁█▂
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 456ms ✓ ▅▁▁▁▁
Cold (Ready in log) 437ms 437ms ✓ ▆▇▅▆▆
Cold (First Request) 1.821s 1.814s ✓ ▇█▆▇█
Warm (Listen) 456ms 455ms ✓ █████
Warm (Ready in log) 437ms 437ms ✓ ▇█▆██
Warm (First Request) 1.811s 1.824s ✓ ▆▇▅▇▇

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.058s 4.061s ✓ ▁▁▂█▁
Cached Build 4.088s 4.081s ✓ ▁▁▂█▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 13.957s 13.903s ✓ ▃▃▁▃▂
Cached Build 14.101s 14.101s ✓ ▃▃▁▃▃
node_modules Size 458 MB 458 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **431 kB** → **431 kB** ✅ -7 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 789 B 792 B ✓
Total 789 B 792 B ⚠️ +3 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 450 B 450 B ✓
Total 450 B 450 B ✓

📦 Webpack

Client

Main Bundles
Canary PR Change
2086.HASH.js gzip 169 B N/A -
2161-HASH.js gzip 5.41 kB N/A -
2747-HASH.js gzip 4.48 kB N/A -
4322-HASH.js gzip 52.8 kB N/A -
ec793fe8-HASH.js gzip 62.3 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB ✓
main-app-HASH.js gzip 250 B 254 B 🔴 +4 B (+2%)
main-HASH.js gzip 38.6 kB 39 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
1596.HASH.js gzip N/A 169 B -
2658-HASH.js gzip N/A 52.7 kB -
6349-HASH.js gzip N/A 4.46 kB -
7019-HASH.js gzip N/A 5.43 kB -
b17a3386-HASH.js gzip N/A 62.3 kB -
Total 225 kB 226 kB ⚠️ +246 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B ✓
_error-HASH.js gzip 182 B 182 B ✓
css-HASH.js gzip 336 B 335 B ✓
dynamic-HASH.js gzip 1.8 kB 1.8 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 352 B 349 B ✓
hooks-HASH.js gzip 385 B 384 B ✓
image-HASH.js gzip 580 B 580 B ✓
index-HASH.js gzip 259 B 258 B ✓
link-HASH.js gzip 2.5 kB 2.51 kB ✓
routerDirect..HASH.js gzip 319 B 317 B ✓
script-HASH.js gzip 385 B 387 B ✓
withRouter-HASH.js gzip 316 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.96 kB ✅ -8 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 242 kB 242 kB ✓
Total 366 kB 367 kB ⚠️ +483 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 653 B 653 B ✓
middleware-r..fest.js gzip 155 B 156 B ✓
middleware.js gzip 32.9 kB 33.3 kB 🔴 +383 B (+1%)
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.6 kB 34.9 kB ⚠️ +384 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 738 B 738 B ✓
Total 738 B 738 B ✓
Build Cache
Canary PR Change
0.pack gzip 3.67 MB 3.67 MB 🔴 +6.49 kB (+0%)
index.pack gzip 99.9 kB 99.8 kB ✓
index.pack.old gzip 101 kB 100 kB ✓
Total 3.87 MB 3.87 MB ⚠️ +5.45 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 304 kB 304 kB ✓
app-page-exp..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 304 kB 304 kB ✓
app-page-tur..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 300 kB 300 kB ✓
app-page-tur..prod.js gzip 156 kB 156 kB ✓
app-page.run...dev.js gzip 301 kB 301 kB ✓
app-page.run..prod.js gzip 156 kB 156 kB ✓
app-route-ex...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-ex..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-tu..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.4 kB 68.4 kB ✓
app-route-tu..prod.js gzip 47.4 kB 47.4 kB ✓
app-route.ru...dev.js gzip 68.4 kB 68.4 kB ✓
app-route.ru..prod.js gzip 47.3 kB 47.3 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 41.2 kB 41.2 kB ✓
pages-api-tu..prod.js gzip 31.3 kB 31.3 kB ✓
pages-api.ru...dev.js gzip 41.1 kB 41.1 kB ✓
pages-api.ru..prod.js gzip 31.2 kB 31.2 kB ✓
pages-turbo....dev.js gzip 50.8 kB 50.8 kB ✓
pages-turbo...prod.js gzip 38.2 kB 38.2 kB ✓
pages.runtim...dev.js gzip 50.7 kB 50.7 kB ✓
pages.runtim..prod.js gzip 38.2 kB 38.2 kB ✓
server.runti..prod.js gzip 62.2 kB 62.2 kB ✓
Total 2.69 MB 2.69 MB ✓

@sokra sokra changed the base branch from sokra/selective-invalidation to graphite-base/88304 January 9, 2026 08:31
This was referenced Jan 9, 2026
Merged
Merged
@sokra sokra force-pushed the graphite-base/88304 branch from 1122fbd to 860b093 Compare January 9, 2026 17:52
@sokra sokra force-pushed the sokra/selective-unused-references branch from 365dd81 to 3a85277 Compare January 9, 2026 17:52
@sokra sokra changed the base branch from graphite-base/88304 to sokra/selective-invalidation January 9, 2026 17:52
This was referenced Jan 9, 2026
Merged
Merged
Draft
Open
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 9, 2026 •
edited
Loading

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing sokra/selective-unused-references (625217c) with canary (7ec9528)

Summary

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@sokra sokra force-pushed the sokra/selective-unused-references branch from 3a85277 to e90ad21 Compare January 12, 2026 09:23
@sokra sokra force-pushed the sokra/selective-invalidation branch from 860b093 to 8456c8d Compare January 12, 2026 09:23
This was referenced Jan 12, 2026
Open
Open
Open
@sokra sokra changed the base branch from sokra/selective-invalidation to graphite-base/88304 January 13, 2026 14:28
@sokra sokra force-pushed the graphite-base/88304 branch from 8456c8d to c151034 Compare January 13, 2026 14:29
@sokra sokra force-pushed the sokra/selective-unused-references branch from e90ad21 to 6a835cc Compare January 13, 2026 14:29
@sokra sokra changed the base branch from graphite-base/88304 to sokra/selective-invalidation January 13, 2026 14:29
@sokra sokra force-pushed the sokra/selective-invalidation branch from c151034 to f351aab Compare January 13, 2026 15:43
@sokra sokra force-pushed the sokra/selective-unused-references branch from 6a835cc to 56dd65a Compare January 13, 2026 15:43
@sokra sokra mentioned this pull request Jan 13, 2026
Open
@sokra sokra changed the base branch from sokra/selective-invalidation to graphite-base/88304 January 13, 2026 16:33
@sokra sokra force-pushed the sokra/selective-unused-references branch from 56dd65a to e130ba3 Compare January 13, 2026 16:34
@sokra sokra changed the base branch from graphite-base/88304 to sokra/selective-invalidation January 13, 2026 16:34
@sokra sokra changed the base branch from sokra/selective-invalidation to graphite-base/88304 January 13, 2026 17:47
@sokra sokra force-pushed the graphite-base/88304 branch from 00704d0 to 7ec9528 Compare January 13, 2026 17:48
@sokra sokra force-pushed the sokra/selective-unused-references branch from e130ba3 to 118009e Compare January 13, 2026 17:48
@graphite-app graphite-app bot changed the base branch from graphite-base/88304 to canary January 13, 2026 17:49
@sokra sokra force-pushed the sokra/selective-unused-references branch from 118009e to 625217c Compare January 13, 2026 17:49
@sokra sokra merged commit 7fc6b94 into canary Jan 13, 2026
164 checks passed
@sokra Graphite App
Copy link
Member Author

sokra commented Jan 13, 2026

Merge activity

@sokra sokra deleted the sokra/selective-unused-references branch January 13, 2026 18:12
This was referenced Jan 14, 2026
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vercel vercel[bot] vercel[bot] left review comments

@mischnic mischnic mischnic approved these changes

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sokra @nextjs-bot @mischnic