Fix patching components#1067
Merged
arunoda merged 2 commits intovercel:masterfrom Feb 12, 2017
dbo:fix-patching-components
Merged
Fix patching components#1067arunoda merged 2 commits intovercel:masterfrom dbo:fix-patching-components
arunoda merged 2 commits intovercel:masterfrom
dbo:fix-patching-components
Conversation
* zeit/master: (109 commits) ensure not to render ErrorDebug on production (#1064) switch octal format (#1060) Write executable files to `dist/bin` (#1059) [WIP] Migrate from Gulp to Fly (#965) wrong position of babel config example (#1057) Using router example improvements (#1034) Set displayName properly when patching React locally. (#1053) add react and react-dom to devDependencies again Using styled-jsx for with-jest example. (#1052) Testing: use a better way to get a port to the test app (#753) Update table of contents (#1051) Add table of contents to README (#735) TypeScript example proposal (#845) Throw when parsedUrl is not provided (#1015) Add support to transpile import/export syntax (#1044) add next/error (#1040) fix .baberc (#1041) add react and react-dom to devDependencies Add babel-preset-latest support. (#1027) add react and react dom as peer (#1024) ...
Contributor
Author
|
@arunoda Will this issue be fixed for 2.0? The current betas are still not usable for us (in dev mode); we're still on beta-13. |
Contributor
|
Yep. We can take this in. |
Contributor
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current code still fails on non-writable
renderon the prototype. This PR should fix this.@arunoda Please have a look.