Using router example improvements#1034
Merged
arunoda merged 1 commit intovercel:masterfrom Feb 9, 2017
Merged
Conversation
albinekb
reviewed
Feb 8, 2017
| a: { | ||
| marginRight: 10 | ||
| function onClickHandler (href) { | ||
| return (e) => { |
Member
Author
There was a problem hiding this comment.
The other examples use e too, that's why I'm using it here 👍
Contributor
There was a problem hiding this comment.
Confusing! I think the examples should be as clear as possible?
Member
Author
There was a problem hiding this comment.
True, think we could update them later on.
albinekb
reviewed
Feb 8, 2017
| ) | ||
| export default class extends Component { | ||
| static getInitialProps () { | ||
| console.log(Router.pathname) |
Member
Author
There was a problem hiding this comment.
I believe it is intentionally broken to show what will happen when you use Router the wrong way.
albinekb
reviewed
Feb 8, 2017
| </div> | ||
| ) | ||
| export default class extends Component { | ||
| static getInitialProps () { |
Contributor
There was a problem hiding this comment.
Maybe remove this completely?
Contributor
|
Okay. This looks nice to me. |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This example wasn't functioning 😢