Skip to content

Switch octal format#1060

Merged
timneutkens merged 1 commit intovercel:masterfrom
lukeed:octal-type
Feb 9, 2017
Merged

Switch octal format#1060
timneutkens merged 1 commit intovercel:masterfrom
lukeed:octal-type

Conversation

@lukeed
Copy link
Copy Markdown
Contributor

@lukeed lukeed commented Feb 9, 2017

Just learned 0755 === 0o755. Cleaner 👍

@timneutkens timneutkens merged commit 15facf0 into vercel:master Feb 9, 2017
@TooTallNate
Copy link
Copy Markdown
Member

TooTallNate commented Feb 9, 2017

The 0o755 format is the newer one (as of ES6).

Also the 0755 format doesn't work in strict mode:

$ node --use-strict -e "0755"
[eval]:1
0755
^^^^
SyntaxError: Octal literals are not allowed in strict mode.

@lukeed
Copy link
Copy Markdown
Contributor Author

lukeed commented Feb 9, 2017

Ah, thanks for the info @TooTallNate! Luckily the "old version" still works in Next.js, for now(?).

@lukeed lukeed deleted the octal-type branch February 9, 2017 21:39
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lukeed @TooTallNate @timneutkens