Skip to content

Set displayName properly when patching React locally.#1053

Merged
timneutkens merged 3 commits intovercel:masterfrom
arunoda:fix-1045
Feb 9, 2017
Merged

Set displayName properly when patching React locally.#1053
timneutkens merged 3 commits intovercel:masterfrom
arunoda:fix-1045

Conversation

@arunoda
Copy link
Copy Markdown
Contributor

@arunoda arunoda commented Feb 9, 2017

Fixes #1045

Now it'll show the displayName is react-dev-tools properly.

screen shot 2017-02-09 at 7 58 28 pm

Otherwise it won't get the correct displayName if the
original component doesn't provide it by using it's function name.
Copy link
Copy Markdown
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@timneutkens timneutkens merged commit 4534c55 into vercel:master Feb 9, 2017
@arunoda arunoda deleted the fix-1045 branch February 9, 2017 16:17
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants