Skip to content

feat: support env vars in OCI secrets#88

Merged
TylerGillson merged 9 commits intomainfrom
refactor/oci-auth
Jul 21, 2024
Merged

feat: support env vars in OCI secrets#88
TylerGillson merged 9 commits intomainfrom
refactor/oci-auth

Conversation

@TylerGillson
Copy link
Member

@TylerGillson TylerGillson commented Jul 18, 2024

Description

Allow users to specify basic auth credentials OR arbitrary environment variables when configuring OCI registry secrets.

Other

  • Add automation to ensure validator versions stay up-to-date
  • Remove hacky 20s wait for plugins to being installing. Wait for plugin conditions to appear on ValidatorConfig instead.

Requires:

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson TylerGillson requested a review from a team as a code owner July 18, 2024 20:39
@TylerGillson TylerGillson requested a review from ahmad-ibra July 18, 2024 20:39
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. new-feature Net-new feature labels Jul 18, 2024
Copy link
Member

@ahmad-ibra ahmad-ibra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just wanted to double check your intentions with the secret.Data map. If what you have is actually what you intended i'll throw a ✅ on this

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
ahmad-ibra
ahmad-ibra previously approved these changes Jul 18, 2024
Copy link
Member

@ahmad-ibra ahmad-ibra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 18, 2024
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jul 21, 2024
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@codecov
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

Attention: Patch coverage is 62.85714% with 78 lines in your changes missing coverage. Please review.

@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   52.64%   52.92%   +0.27%     
==========================================
  Files          44       45       +1     
  Lines        4745     4879     +134     
==========================================
+ Hits         2498     2582      +84     
- Misses       1609     1638      +29     
- Partials      638      659      +21     
Files Coverage Δ
pkg/config/constants.go 100.00% <ø> (ø)
...integration/_validator/testcases/test_validator.go 94.89% <100.00%> (+0.08%) ⬆️
pkg/services/validator/validator_service.go 38.11% <0.00%> (ø)
pkg/utils/kind/kind.go 28.26% <50.00%> (-0.32%) ⬇️
pkg/services/env_service.go 0.00% <0.00%> (ø)
pkg/services/validator/common.go 46.52% <54.54%> (+0.09%) ⬆️
pkg/components/environment.go 0.00% <0.00%> (ø)
pkg/components/validator.go 60.06% <84.72%> (+2.86%) ⬆️
pkg/cmd/validator/validator.go 51.71% <56.25%> (-0.35%) ⬇️
pkg/services/validator/oci.go 47.76% <53.70%> (+1.92%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c69e355...cf512eb. Read the comment docs.

@TylerGillson TylerGillson merged commit 584b3c7 into main Jul 21, 2024
@TylerGillson TylerGillson deleted the refactor/oci-auth branch July 21, 2024 23:00
ahmad-ibra pushed a commit that referenced this pull request Jul 24, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.0.5](v0.0.4...v0.0.5)
(2024-07-24)


### Features

* add support for private custom image registries
([#83](#83))
([ae91659](ae91659))
* support env vars in OCI secrets
([#88](#88))
([584b3c7](584b3c7))


### Bug Fixes

* ensure passwords in helm templates are quoted
([#96](#96))
([f36383b](f36383b))


### Other

* omit EDITOR logs by default
([#76](#76))
([b3ab7ec](b3ab7ec))


### Dependency Updates

* **deps:** update anchore/sbom-action action to v0.17.0
([#75](#75))
([caf800d](caf800d))
* **deps:** update golang.org/x/exp digest to 8a7402a
([#89](#89))
([3ffda87](3ffda87))
* **deps:** update golang.org/x/exp digest to e3f2596
([#82](#82))
([a89beb6](a89beb6))
* **deps:** update module github.com/validator-labs/validator to v0.0.47
([#92](#92))
([8c359e1](8c359e1))
* **deps:** update module github.com/validator-labs/validator to v0.0.48
([#94](#94))
([743656d](743656d))
* **deps:** update module
github.com/validator-labs/validator-plugin-azure to v0.0.13
([#79](#79))
([0c2dff7](0c2dff7))
* **deps:** update module
github.com/validator-labs/validator-plugin-network to v0.0.18
([#87](#87))
([c69e355](c69e355))
* **deps:** update module
github.com/validator-labs/validator-plugin-network to v0.0.19
([#95](#95))
([e70433a](e70433a))
* **deps:** update module github.com/validator-labs/validator-plugin-oci
to v0.0.11
([#90](#90))
([a633962](a633962))
* **deps:** update module
github.com/validator-labs/validator-plugin-vsphere to v0.0.27
([#80](#80))
([feb6360](feb6360))
* **deps:** update module github.com/vmware/govmomi to v0.39.0
([#93](#93))
([2a01e95](2a01e95))
* **deps:** update softprops/action-gh-release digest to c062e08
([#85](#85))
([b8b5c62](b8b5c62))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer new-feature Net-new feature size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants