Skip to content

fix: handle basic auth for OCI client#333

Merged
TylerGillson merged 18 commits intomainfrom
feat/enhanced-oci-client
Jul 20, 2024
Merged

fix: handle basic auth for OCI client#333
TylerGillson merged 18 commits intomainfrom
feat/enhanced-oci-client

Conversation

@TylerGillson
Copy link
Member

@TylerGillson TylerGillson commented Jul 18, 2024

Description

  • Use updated OCI client from validator-plugin-oci
  • Refactor OCI auth secrets in Helm chart to support passing env vars for ECR
  • add 'make reviewable' extension to automatically update hauler-manifest.yaml and chart/validator/values.yaml
    • updated values.yaml for many plugins in the process + versions in hauler-manifest.yaml

Requires:

… env; init basic auth for OCI client

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson TylerGillson requested a review from a team as a code owner July 18, 2024 16:26
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jul 18, 2024
@TylerGillson TylerGillson requested review from ahmad-ibra and removed request for arturshadnik July 18, 2024 16:26
@dosubot dosubot bot added bug Something isn't working enhancement Enhancement to an existing feature labels Jul 18, 2024
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Jul 18, 2024
@TylerGillson TylerGillson changed the title feat: enhance OCI client fix: handle basic auth for OCI client Jul 18, 2024
ahmad-ibra
ahmad-ibra previously approved these changes Jul 18, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 18, 2024
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
ahmad-ibra
ahmad-ibra previously approved these changes Jul 18, 2024
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
ahmad-ibra
ahmad-ibra previously approved these changes Jul 18, 2024
@TylerGillson TylerGillson removed the enhancement Enhancement to an existing feature label Jul 19, 2024
@codecov
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
+ Coverage   46.38%   48.62%   +2.23%     
==========================================
  Files          23       22       -1     
  Lines        1343     1273      -70     
==========================================
- Hits          623      619       -4     
+ Misses        653      586      -67     
- Partials       67       68       +1     
Files Coverage Δ
internal/controller/validatorconfig_controller.go 66.51% <0.00%> (-3.31%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f94947...72e938e. Read the comment docs.

TylerGillson added a commit to validator-labs/validator-plugin-oci that referenced this pull request Jul 19, 2024
## Issue
Addresses #65

## Description
- add public OCI client (that handles basic auth and proxy from env in
HTTP transport)
- fail validation results if they specify invalid public key secrets
- add kv pairs from auth secrets to the environment (for ECR auth
keychain)
- add support for InsecureSkipTLSVerify

Required by:
- validator-labs/validator#333

---------

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jul 19, 2024
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson TylerGillson requested a review from ahmad-ibra July 19, 2024 21:54
ahmad-ibra
ahmad-ibra previously approved these changes Jul 19, 2024
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
ahmad-ibra
ahmad-ibra previously approved these changes Jul 19, 2024
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson TylerGillson merged commit 5041c4f into main Jul 20, 2024
@TylerGillson TylerGillson deleted the feat/enhanced-oci-client branch July 20, 2024 02:51
TylerGillson added a commit that referenced this pull request Jul 21, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.0.47](v0.0.46...v0.0.47)
(2024-07-20)


### Bug Fixes

* handle basic auth for OCI client
([#333](#333))
([5041c4f](5041c4f))
* make string utils avail externally
([#335](#335))
([81d7d46](81d7d46))


### Other

* move string utils to central location
([#334](#334))
([44c09ab](44c09ab))


### Docs

* recommend validatorctl; document Hauler
([#326](#326))
([18a8fef](18a8fef))
* Update air-gapped prereqs in README.md
([de015d9](de015d9))


### Dependency Updates

* **deps:** update golang.org/x/exp digest to 8a7402a
([#336](#336))
([8f94947](8f94947))
* **deps:** update golang.org/x/exp digest to 8a7402a
([#338](#338))
([e012a4e](e012a4e))
* **deps:** update golang.org/x/exp digest to e3f2596
([#329](#329))
([3419300](3419300))
* **deps:** update kubernetes packages to v0.30.3
([#332](#332))
([5d4486c](5d4486c))
* **deps:** update module github.com/google/go-containerregistry to
v0.20.1 ([#330](#330))
([81fd1cf](81fd1cf))
* **deps:** update module github.com/slack-go/slack to v0.13.1
([#328](#328))
([089d25d](089d25d))
* **deps:** update module github.com/validator-labs/validator-plugin-oci
to v0.0.11
([#339](#339))
([70a26e1](70a26e1))
* **deps:** update softprops/action-gh-release digest to c062e08
([#331](#331))
([c797383](c797383))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
TylerGillson added a commit to validator-labs/validatorctl that referenced this pull request Jul 21, 2024
## Description
Allow users to specify basic auth credentials _OR_ arbitrary environment
variables when configuring OCI registry secrets.

Other
- Add automation to ensure validator versions stay up-to-date
- Remove hacky 20s wait for plugins to being installing. Wait for plugin
conditions to appear on ValidatorConfig instead.

Requires:
- validator-labs/validator#333

---------

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants