feat: add support for private custom image registries#83
Merged
ahmad-ibra merged 12 commits intomainfrom Jul 22, 2024
Merged
Conversation
f11802e to
6417aad
Compare
053b983 to
a164707
Compare
f6b98b6 to
a0dc210
Compare
a4b8f99 to
4802795
Compare
4802795 to
b2c3696
Compare
7c9241d to
d5dadb8
Compare
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #83 +/- ##
==========================================
- Coverage 52.89% 52.32% -0.58%
==========================================
Files 45 45
Lines 4881 5005 +124
==========================================
+ Hits 2582 2619 +37
- Misses 1640 1725 +85
- Partials 659 661 +2
Continue to review full report in Codecov by Sentry.
|
TylerGillson
approved these changes
Jul 22, 2024
Member
TylerGillson
left a comment
There was a problem hiding this comment.
IMO the code in ensureDockerOciCaConfig needs to be moved into a separate "setup" command, but we can address that in a follow-up. It's just super invasive stuff and the expectation of having sudo is horrible.
ahmad-ibra
pushed a commit
that referenced
this pull request
Jul 24, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.5](v0.0.4...v0.0.5) (2024-07-24) ### Features * add support for private custom image registries ([#83](#83)) ([ae91659](ae91659)) * support env vars in OCI secrets ([#88](#88)) ([584b3c7](584b3c7)) ### Bug Fixes * ensure passwords in helm templates are quoted ([#96](#96)) ([f36383b](f36383b)) ### Other * omit EDITOR logs by default ([#76](#76)) ([b3ab7ec](b3ab7ec)) ### Dependency Updates * **deps:** update anchore/sbom-action action to v0.17.0 ([#75](#75)) ([caf800d](caf800d)) * **deps:** update golang.org/x/exp digest to 8a7402a ([#89](#89)) ([3ffda87](3ffda87)) * **deps:** update golang.org/x/exp digest to e3f2596 ([#82](#82)) ([a89beb6](a89beb6)) * **deps:** update module github.com/validator-labs/validator to v0.0.47 ([#92](#92)) ([8c359e1](8c359e1)) * **deps:** update module github.com/validator-labs/validator to v0.0.48 ([#94](#94)) ([743656d](743656d)) * **deps:** update module github.com/validator-labs/validator-plugin-azure to v0.0.13 ([#79](#79)) ([0c2dff7](0c2dff7)) * **deps:** update module github.com/validator-labs/validator-plugin-network to v0.0.18 ([#87](#87)) ([c69e355](c69e355)) * **deps:** update module github.com/validator-labs/validator-plugin-network to v0.0.19 ([#95](#95)) ([e70433a](e70433a)) * **deps:** update module github.com/validator-labs/validator-plugin-oci to v0.0.11 ([#90](#90)) ([a633962](a633962)) * **deps:** update module github.com/validator-labs/validator-plugin-vsphere to v0.0.27 ([#80](#80)) ([feb6360](feb6360)) * **deps:** update module github.com/vmware/govmomi to v0.39.0 ([#93](#93)) ([2a01e95](2a01e95)) * **deps:** update softprops/action-gh-release digest to c062e08 ([#85](#85)) ([b8b5c62](b8b5c62)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
#81
Description
This PR adds support for cutom image registries. Under the hood, the
Registrystruct will use Hauler if itsIsAirgappedprop is set to true.Tested by configuring artifacts in a harbor registry as shown below and installing validator with
InsecureSkipTLSVerifyset totrue(and passing in the CA cert) andfalse