Skip to content

New Merge Request #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
troglodytto wants to merge 2 commits into from
Closed

New Merge Request #52

troglodytto wants to merge 2 commits into from

Conversation

@troglodytto
Copy link

@troglodytto troglodytto commented Apr 18, 2021

No description provided.

@mistaken-pull-closer
Copy link

mistaken-pull-closer bot commented Apr 18, 2021

Thanks for your contribution! Unfortunately, we don't use GitHub pull
requests to manage code contributions to this repository. Instead, please
see https://v8.dev/docs/contribute which provides full instructions on
how to get involved.

@google-cla
Copy link

google-cla bot commented Apr 18, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Kwizatz pushed a commit to AeonGames/v8 that referenced this pull request Jul 25, 2021
Version 9.1.269.26
c8ae810 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I7ddc8df696c15169814e153f26d3b87ed64e15db
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2876683
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.1@{v8#52}
Cr-Branched-From: 0e4ac64-refs/heads/9.1.269@{#1}
Cr-Branched-From: f565e72-refs/heads/master@{#73847}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Version 9.2.230.25
cded902 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I8cbb4f5dbafe06a0dc3d12cf57db0c14794073fe
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3080684
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.2@{v8#52}
Cr-Branched-From: 5123834-refs/heads/9.2.230@{#1}
Cr-Branched-From: 587a04f-refs/heads/master@{#74656}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Version 8.9.255.25
a2d8eca 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I00ea48c106c6ba2e1e0d5a9bbbf762452cff1715
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2822626
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.9@{v8#52}
Cr-Branched-From: 16b9bbb-refs/heads/8.9.255@{#1}
Cr-Branched-From: d16a2a6-refs/heads/master@{#72039}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@verwaest
Merged: [runtime] Check if we have a pending exception before returni…
feef101 
…ng it

Revision: be55c16

BUG=chromium:1263462
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=cbruni@chromium.org

Change-Id: Ib7de676fe614403674fcd2745c574f7e91ded23f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3247033
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/branch-heads/9.4@{v8#52}
Cr-Branched-From: 3b51863-refs/heads/9.4.146@{#1}
Cr-Branched-From: 2890419-refs/heads/master@{#76233}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@mi-ac
Revert "Whitespace change to test alerts"
2bf1a23 
This reverts commit 683a462.

Reason for revert: Trigger yet another change

Original change's description:
> Whitespace change to test alerts
>
> No-try: true
> Change-Id: I9e8abd66eeb1097873d30e1dafd6e3cb71c713d2
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3256786
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
> Cr-Commit-Position: refs/branch-heads/9.5@{v8#50}
> Cr-Branched-From: 4a03d61-refs/heads/9.5.172@{#1}
> Cr-Branched-From: 9a60704-refs/heads/main@{#76741}

Change-Id: I3ed9ec01d80734560f1dbbca409abb6c35df75b4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3257822
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/branch-heads/9.5@{v8#52}
Cr-Branched-From: 4a03d61-refs/heads/9.5.172@{#1}
Cr-Branched-From: 9a60704-refs/heads/main@{#76741}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@GeorgNeis
Merged: [compiler] Fix a bug in SimplifiedLowering
c449afa 
Revision: ba1b2cc

BUG=chromium:1150649
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

(cherry picked from commit 966d0eb)

Change-Id: Ic903e61ee00b7c240bed96633d1eab582c295308
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2557985
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Original-Commit-Position: refs/branch-heads/8.8@{v8#10}
Cr-Original-Branched-From: 2dbcdc1-refs/heads/8.8.278@{#1}
Cr-Original-Branched-From: 366d30c-refs/heads/master@{#71094}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2624749
Reviewed-by: Jana Grill <janagrill@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Victor-Gabriel Savu <vsavu@google.com>
Cr-Commit-Position: refs/branch-heads/8.6@{v8#52}
Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1}
Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@backes
[M96-LTS][liftoff][x64] Fix bug in i32.atomic.sub32
c46fb3a 
{AtomicSub} on x64 first negates the {value} register, then does an
atomic addition. For that reason, {value} should be a unique register.
So far, we only checked that it's not used in the value stack, but we
should also check for overlap with the destination address or the offset
register.

Drive-by: Remove unneeded handling of non-unique register index on arm,
as that cannot happen (LiftoffCompiler ensures that the result register
is unique).

R=​thibaudm@chromium.org

(cherry picked from commit b5003a3)

Bug: chromium:1296876
Change-Id: Ie6b97eec8e8dea07b0bcc644d261f47467cc5b8e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3487987
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#79265}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3509394
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Roger Felipe Zanoni da Silva <rzanoni@google.com>
Cr-Commit-Position: refs/branch-heads/9.6@{v8#52}
Cr-Branched-From: 0b7bda0-refs/heads/9.6.180@{#1}
Cr-Branched-From: 41a5a24-refs/heads/main@{#77244}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Version 9.0.257.26
fa72908 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: Iee18375afce00cdb512afc51d14bfbc3889430ef
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2874948
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.0@{v8#52}
Cr-Branched-From: bd0108b-refs/heads/9.0.257@{#1}
Cr-Branched-From: 349bcc6-refs/heads/master@{#73001}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Version 8.7.220.26
691a7fa 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I375eab33dad1454dbcc251d08628f6580d86045f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2549106
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.7@{v8#52}
Cr-Branched-From: 0d81cd7-refs/heads/8.7.220@{#1}
Cr-Branched-From: 942c2ef-refs/heads/master@{#70196}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
Version 10.6.194.26
b80e260 
Change-Id: I8c458cd1290c53d5ad097d382c6e3c4e52df50c5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4009246
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/10.6@{v8#52}
Cr-Branched-From: 41bc743-refs/heads/10.6.194@{#1}
Cr-Branched-From: d5f29b9-refs/heads/main@{#82548}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
@isheludko
[M108-LTS][runtime] Make Error.captureStackTrace() a no-op for global…
12be50e 
… object

(cherry picked from commit fa81078)

Bug: chromium:1432210
Change-Id: I8aa4c3f1d9ecbfffce503085c2879416ff916c69
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4417690
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Auto-Submit: Igor Sheludko <ishell@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#87045}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4422621
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/branch-heads/10.8@{v8#52}
Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1}
Cr-Branched-From: 237de89-refs/heads/main@{#83672}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
@isheludko
Revert "[M108-LTS][runtime] Make Error.captureStackTrace() a no-op fo…
cc3d171 
…r global object"

This reverts commit 12be50e.

Reason for revert: Merged before the approval

Original change's description:
> [M108-LTS][runtime] Make Error.captureStackTrace() a no-op for global object
>
> (cherry picked from commit fa81078)
>
> Bug: chromium:1432210
> Change-Id: I8aa4c3f1d9ecbfffce503085c2879416ff916c69
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4417690
> Commit-Queue: Igor Sheludko <ishell@chromium.org>
> Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
> Auto-Submit: Igor Sheludko <ishell@chromium.org>
> Cr-Original-Commit-Position: refs/heads/main@{#87045}
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4422621
> Reviewed-by: Igor Sheludko <ishell@chromium.org>
> Cr-Commit-Position: refs/branch-heads/10.8@{v8#52}
> Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1}
> Cr-Branched-From: 237de89-refs/heads/main@{#83672}

Bug: chromium:1432210
Change-Id: I8d39ded536de38e400c06dc5cb1e6a042ff0c804
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4428092
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/branch-heads/10.8@{v8#54}
Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1}
Cr-Branched-From: 237de89-refs/heads/main@{#83672}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
@isheludko
Reland "[M108-LTS][runtime] Make Error.captureStackTrace() a no-op fo…
5b2a75d 
…r global object"

This is a reland of commit 12be50e

Original change's description:
> [M108-LTS][runtime] Make Error.captureStackTrace() a no-op for global object
>
> (cherry picked from commit fa81078)
>
> Bug: chromium:1432210
> Change-Id: I8aa4c3f1d9ecbfffce503085c2879416ff916c69
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4417690
> Commit-Queue: Igor Sheludko <ishell@chromium.org>
> Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
> Auto-Submit: Igor Sheludko <ishell@chromium.org>
> Cr-Original-Commit-Position: refs/heads/main@{#87045}
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4422621
> Reviewed-by: Igor Sheludko <ishell@chromium.org>
> Cr-Commit-Position: refs/branch-heads/10.8@{v8#52}
> Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1}
> Cr-Branched-From: 237de89-refs/heads/main@{#83672}

Bug: chromium:1432210
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: I4c06a76db005a61b2259b836c1f06c78eb004e16
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4459252
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Roger Felipe Zanoni da Silva <rzanoni@google.com>
Cr-Commit-Position: refs/branch-heads/10.8@{v8#56}
Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1}
Cr-Branched-From: 237de89-refs/heads/main@{#83672}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
@mi-ac
Merged: Squashed multiple commits.
1aa54d0 
Merged: Prepare renaming "V8 Linux64 TSAN - concurrent marking" bot
Revision: 165d8f5

Merged: [test] Remove entry of renamed builder
Revision: 375579f

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
TBR=neis@chromium.org

Change-Id: Ia17da2072da7f46de1ab35946ba1e5ca4458c2f9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2418096
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/branch-heads/8.5@{v8#52}
Cr-Branched-From: a7f8bc4-refs/heads/8.5.210@{#1}
Cr-Branched-From: dd58472-refs/heads/master@{#68510}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Jun 26, 2023
Version 11.4.183.26
8df6322 
Change-Id: I26cef67fe408c9966ebcc758df745934049befcc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4644756
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.4@{v8#52}
Cr-Branched-From: 8a8a1e7-refs/heads/11.4.183@{#1}
Cr-Branched-From: 5483d8e-refs/heads/main@{#87241}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Jul 5, 2023
@danleh
[regalloc] Efficient insert of UsePositions at front
118eb44 
Use the just added `DoubleEndedSplitVector` datastructure, which allows
efficient inserts at the front, as is (mostly) the case in practice
for `UsePosition`s.

This avoids reallocations and copies in pathological cases, e.g.,
- function v8#52 of 401.bzip2 benchmark (SPEC CPU 2006):
  reduces total compile time by ~47% (-118ms)
- function v8#92 of HashSet JetStream 2 benchmark:
  reduces total compile time by ~43% (-38ms)
- function #2839 of binary from v8:9529:
  reduces total compile time by ~3% (-260ms)
No regressions in terms of total or maximum Zone memory usage,
or average, median, or 99% percentile total compile time for all
Wasm functions in our benchmarks.

Bug: v8:14082, v8:9529
Change-Id: Ia7cf78ec61accccee28d1798928db760262cac69
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4650484
Commit-Queue: Daniel Lehmann <dlehmann@chromium.org>
Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#88654}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Jan 21, 2024
Version 12.1.285.26
10e0311 
Change-Id: Ifb08e6de7f18d1e2678fd53aa0e9301b45dae95b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5207112
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.1@{v8#52}
Cr-Branched-From: b74ef6f-refs/heads/12.1.285@{#1}
Cr-Branched-From: 32857fb-refs/heads/main@{#91313}
hubot pushed a commit that referenced this pull request Mar 28, 2024
@DadaIsCrazy
Merged: [runtime] Recreate enum cache on map update if any previous m…
28d69f1 
…ap had one

If any previous map in the transition tree had an enum cache, then we
recreate one when updating the map.

Bug: 330760873
(cherry picked from commit 807cf7d)

Change-Id: Ia9ea4cf17fef60166a0c037318eb539866aac37a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5401859
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Auto-Submit: Darius Mercadier <dmercadier@chromium.org>
Cr-Commit-Position: refs/branch-heads/12.2@{#52}
Cr-Branched-From: 6eb5a96-refs/heads/12.2.281@{#1}
Cr-Branched-From: 44cf56d-refs/heads/main@{#91934}
hubot pushed a commit that referenced this pull request May 15, 2024
@syg
[M120-LTS][compiler] Don't build AccessInfo for storing to module exp…
2944ee9 
…orts

(cherry picked from commit b3c01ac)

Bug: b/340221135
Change-Id: I5af35be6ebf6a69db1c4687107503575b23973c4
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5534518
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#93872}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5540772
Commit-Queue: Roger Felipe Zanoni da Silva <rzanoni@google.com>
Owners-Override: Shu-yu Guo <syg@chromium.org>
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/branch-heads/12.0@{#52}
Cr-Branched-From: ed7b4ca-refs/heads/12.0.267@{#1}
Cr-Branched-From: 210e75b-refs/heads/main@{#90651}
hubot pushed a commit that referenced this pull request Jul 15, 2024
@jakobkummerow
Merged: [wasm][multi-memory] Fix cast of memory index
01630b9 
"uint8_t" must have been a typo.

Fixed: 351327767
(cherry picked from commit bc545b1)

Change-Id: Ibd20725045ae41bfcecebcb8f27cf1d0734d1013
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5708568
Reviewed-by: Matthias Liedtke <mliedtke@chromium.org>
Commit-Queue: Matthias Liedtke <mliedtke@chromium.org>
Auto-Submit: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/branch-heads/12.6@{#52}
Cr-Branched-From: 3c9fa12-refs/heads/12.6.228@{#2}
Cr-Branched-From: 981bb15-refs/heads/main@{#93835}
hubot pushed a commit that referenced this pull request Sep 3, 2024
@devsnek
Merged: [top-level-await] fix async evaluation with errored async parent
62a670a 
Updates a CHECK to support EVALUATING-ASYNC modules.

Updates GatherAvailableAncestors to check kErrored before
calling AsyncEvaluationOrdinalCompare to prevent hitting DCHECK.

Bug: 361615555
Bug: 361603701
Bug: 361611791

(cherry picked from commit 5af53ec)

Change-Id: Ib4917468ca911dc2bfc6f5579846e0dd17ee41b8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5833740
Reviewed-by: Deepti Gandluri <gdeepti@chromium.org>
Commit-Queue: Deepti Gandluri <gdeepti@chromium.org>
Auto-Submit: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/branch-heads/12.8@{#52}
Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1}
Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
hubot pushed a commit that referenced this pull request Oct 3, 2024
Version 12.9.202.26
0a897f9 
Change-Id: I7d32297018c5d0e0e5dff41c549e0ac50037ff44
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5904987
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.9@{#52}
Cr-Branched-From: 64a21d7-refs/heads/12.9.202@{#1}
Cr-Branched-From: da4200b-refs/heads/main@{#95679}
hubot pushed a commit that referenced this pull request Jan 6, 2025
@thibaudmichaud
Merged: [wasm][arm][tail-call] Free scratch register earlier
7e36549 
In Liftoff's PrepareTailCall, we kept the UseScratchRegisterScope open
for longer than necessary. Close the scope earlier to ensure that we
don't run out of scratch registers in the last "sub" instruction if it
needs one.

R=clemensb@chromium.org

Fixed: 384565015
(cherry picked from commit 7c9e628)

Change-Id: Ic3bba6afe82ef7e1dc8a4c99bdbb4fce22e321b8
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6148649
Reviewed-by: Daniel Lehmann <dlehmann@chromium.org>
Commit-Queue: Thibaud Michaud <thibaudm@chromium.org>
Cr-Commit-Position: refs/branch-heads/13.2@{#52}
Cr-Branched-From: 24068c5-refs/heads/13.2.152@{#1}
Cr-Branched-From: 6054ba9-refs/heads/main@{#97085}
hubot pushed a commit that referenced this pull request Jul 9, 2025
Version 13.8.258.26
de9d0f8 
Version incremented at https://cr-buildbucket.appspot.com/build/8709810419964357537

Change-Id: I726eefabb53ce7182b68bcbeae67a212f3f14efd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6719512
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.8@{#52}
Cr-Branched-From: 61ddd47-refs/heads/13.8.258@{#1}
Cr-Branched-From: fdb5de2-refs/heads/main@{#100480}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@troglodytto