mirrored from https://chromium.googlesource.com/v8/v8.git
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Let’s leave mistaken-pull-closer.yml in the wrong place #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does this PR autoclose itself?
|
Thanks for your contribution! Unfortunately, we don't use GitHub pull |
Kwizatz
pushed a commit
to AeonGames/v8
that referenced
this pull request
Jul 25, 2021
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I099e9b5739ab35120dae71da615eda2ef4d53805 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2877869 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.1@{v8#54} Cr-Branched-From: 0e4ac64-refs/heads/9.1.269@{#1} Cr-Branched-From: f565e72-refs/heads/master@{#73847}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I5ba2a9b64c4c7529ea299814552c1930072959cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3083397 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.2@{v8#54} Cr-Branched-From: 5123834-refs/heads/9.2.230@{#1} Cr-Branched-From: 587a04f-refs/heads/master@{#74656}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Bug: chromium:1254189 (cherry picked from commit bdf31d5) (cherry picked from commit 5d2b5e7) Change-Id: I1d4426fee8392c7a680ad67af4bf2745d04b2e52 No-Try: true No-Presubmit: true No-Tree-Checks: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3268905 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/9.6@{v8#22} Cr-Original-Branched-From: 0b7bda0-refs/heads/9.6.180@{#1} Cr-Original-Branched-From: 41a5a24-refs/heads/main@{#77244} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3330865 Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/branch-heads/9.4@{v8#54} Cr-Branched-From: 3b51863-refs/heads/9.4.146@{#1} Cr-Branched-From: 2890419-refs/heads/master@{#76233}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
Revision: 823c44d NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=machenbach@chromium.org Change-Id: Ia2c738c677037703024f832def448dfbdce513d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306384 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/branch-heads/9.5@{v8#54} Cr-Branched-From: 4a03d61-refs/heads/9.5.172@{#1} Cr-Branched-From: 9a60704-refs/heads/main@{#76741}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
(cherry picked from commit e82a3b4) (cherry picked from commit 1162c46) No-Try: true No-Presubmit: true No-Tree-Checks: true Fixed: chromium:1151890 Change-Id: I26f5c76494a9ff3f5a141f381e1c9a543e368571 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2561618 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#71422} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565245 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/8.7@{v8#57} Cr-Original-Branched-From: 0d81cd7-refs/heads/8.7.220@{#1} Cr-Original-Branched-From: 942c2ef-refs/heads/master@{#70196} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2624611 Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/branch-heads/8.6@{v8#54} Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1} Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
(cherry picked from commit 0981e91) Bug: chromium:1309225 Change-Id: Ifd62639a2aa18b633e7cf36632677ee16c977afd No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3548458 Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#79613} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3550263 Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Lutz Vahl <vahl@chromium.org> Commit-Queue: Lutz Vahl <vahl@chromium.org> Cr-Commit-Position: refs/branch-heads/9.6@{v8#54} Cr-Branched-From: 0b7bda0-refs/heads/9.6.180@{#1} Cr-Branched-From: 41a5a24-refs/heads/main@{#77244}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: Ibad5e360cde88be2f7e72b8128c993272c72a97b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2877867 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/9.0@{v8#54} Cr-Branched-From: bd0108b-refs/heads/9.0.257@{#1} Cr-Branched-From: 349bcc6-refs/heads/master@{#73001}
cb-robot
pushed a commit
to couchbasedeps/v8-mirror
that referenced
this pull request
Aug 24, 2022
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Change-Id: I0e5746f4e3b25982607115c60ada0e391200405e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2551916 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/8.7@{v8#54} Cr-Branched-From: 0d81cd7-refs/heads/8.7.220@{#1} Cr-Branched-From: 942c2ef-refs/heads/master@{#70196}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
…r global object" This reverts commit 12be50e. Reason for revert: Merged before the approval Original change's description: > [M108-LTS][runtime] Make Error.captureStackTrace() a no-op for global object > > (cherry picked from commit fa81078) > > Bug: chromium:1432210 > Change-Id: I8aa4c3f1d9ecbfffce503085c2879416ff916c69 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4417690 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Auto-Submit: Igor Sheludko <ishell@chromium.org> > Cr-Original-Commit-Position: refs/heads/main@{#87045} > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4422621 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/branch-heads/10.8@{v8#52} > Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1} > Cr-Branched-From: 237de89-refs/heads/main@{#83672} Bug: chromium:1432210 Change-Id: I8d39ded536de38e400c06dc5cb1e6a042ff0c804 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4428092 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/branch-heads/10.8@{v8#54} Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1} Cr-Branched-From: 237de89-refs/heads/main@{#83672}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
Revision: 268490c BUG=chromium:1099623 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=machenbach@chromium.org Change-Id: I13397e3527e968c214743f326f2315a04e1d3976 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2424268 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/branch-heads/8.5@{v8#54} Cr-Branched-From: a7f8bc4-refs/heads/8.5.210@{#1} Cr-Branched-From: dd58472-refs/heads/master@{#68510}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Jul 6, 2023
Change-Id: I37a8cfb7d5407464598bb78d901947cab7cfdf99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4667373 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.4@{v8#54} Cr-Branched-From: 8a8a1e7-refs/heads/11.4.183@{#1} Cr-Branched-From: 5483d8e-refs/heads/main@{#87241}
reposynch bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Jan 28, 2024
Change-Id: Ibb6ff8b80efffe1367d5d03fa880bd5e1d65035d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5232107 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.1@{v8#54} Cr-Branched-From: b74ef6f-refs/heads/12.1.285@{#1} Cr-Branched-From: 32857fb-refs/heads/main@{#91313}
hubot
pushed a commit
that referenced
this pull request
Apr 1, 2024
The code field in the WasmInternalFunction is a code pointer since https://crrev.com/c/5110559, so it has to be scanned explicitly. Bug: 329130358 (cherry picked from commit b93975a) Change-Id: I0795d2188a8af3480c513d1dbaccfcef1da04473 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5410311 Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/branch-heads/12.2@{#54} Cr-Branched-From: 6eb5a96-refs/heads/12.2.281@{#1} Cr-Branched-From: 44cf56d-refs/heads/main@{#91934}
hubot
pushed a commit
that referenced
this pull request
May 28, 2024
…c blocks Class static blocks contain statements, don't inherit the ExpressionScope stack. (cherry picked from commit 3e037e1) Bug: b/341663589 Change-Id: Id52a60d77781201a706fcf2290d7d103f39bed83 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5553030 Commit-Queue: Shu-yu Guo <syg@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#94014} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5564223 Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Roger Felipe Zanoni da Silva <rzanoni@google.com> Cr-Commit-Position: refs/branch-heads/12.0@{#54} Cr-Branched-From: ed7b4ca-refs/heads/12.0.267@{#1} Cr-Branched-From: 210e75b-refs/heads/main@{#90651}
hubot
pushed a commit
that referenced
this pull request
Jul 31, 2024
Fixed: 355256380 (cherry picked from commit 313905c) Change-Id: I5b1ff15b146ac1054dee5f62b59af8337fca5287 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5743766 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/branch-heads/12.6@{#54} Cr-Branched-From: 3c9fa12-refs/heads/12.6.228@{#2} Cr-Branched-From: 981bb15-refs/heads/main@{#93835}
hubot
pushed a commit
that referenced
this pull request
Sep 4, 2024
When a js-to-wasm wrapper tiers up, we also set the newly compiled wrapper as the target for other exports that have the same signature. This assumed that all exports have type WasmExportedFunction, but they can also have type WasmJSFunction in the case of a re-exported WebAssembly.Function import. R=clemensb@chromium.org Fixed: 362539773 (cherry picked from commit 7860c96) Change-Id: Id685ae73a84121701729178a3a6f28dbc39648df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5835724 Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/branch-heads/12.8@{#54} Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
hubot
pushed a commit
that referenced
this pull request
Oct 7, 2024
Change-Id: Ibf8ccf575442698c24615da98dd9f05695dd1a01 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5912072 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.9@{#54} Cr-Branched-From: 64a21d7-refs/heads/12.9.202@{#1} Cr-Branched-From: da4200b-refs/heads/main@{#95679}
hubot
pushed a commit
that referenced
this pull request
Jan 9, 2025
Add the WasmTrapHandlerThrowTrap builtin to the list of wasm builtins to ensure that it switches to the central stack before calling the corresponding runtime function. R=dlehmann@chromium.org Bug: 385167053 (cherry picked from commit 91acb7e) Change-Id: I972b27d1b0f5da1a8c7b680a08d3d2ae5b3f734c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6163445 Reviewed-by: Daniel Lehmann <dlehmann@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/branch-heads/13.2@{#54} Cr-Branched-From: 24068c5-refs/heads/13.2.152@{#1} Cr-Branched-From: 6054ba9-refs/heads/main@{#97085}
hubot
pushed a commit
that referenced
this pull request
Jul 18, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8709020322121554257 Change-Id: Iee8f1cbbf2e2d46a0cc4d41da959f6c9ddfc8b51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6768581 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.8@{#54} Cr-Branched-From: 61ddd47-refs/heads/13.8.258@{#1} Cr-Branched-From: fdb5de2-refs/heads/main@{#100480}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR autoclose itself?