Skip to content

Simplified if statement #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ErdemIpek wants to merge 2 commits into from
Closed

Simplified if statement #56

ErdemIpek wants to merge 2 commits into from

Conversation

@ErdemIpek
Copy link

@ErdemIpek ErdemIpek commented May 16, 2021

Tried to simplify if statement.

@mistaken-pull-closer
Copy link

mistaken-pull-closer bot commented May 16, 2021

Thanks for your contribution! Unfortunately, we don't use GitHub pull
requests to manage code contributions to this repository. Instead, please
see https://v8.dev/docs/contribute which provides full instructions on
how to get involved.

@google-cla
Copy link

google-cla bot commented May 16, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Kwizatz pushed a commit to AeonGames/v8 that referenced this pull request Jul 25, 2021
Version 9.1.269.28
fd856ce 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I7390bb75479684dec06e77598ab188395d398588
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2882478
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.1@{v8#56}
Cr-Branched-From: 0e4ac64-refs/heads/9.1.269@{#1}
Cr-Branched-From: f565e72-refs/heads/master@{#73847}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Version 9.2.230.27
0c7b136 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I2537e1691300167da87b1a272482ea236d7dc2d9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3085584
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.2@{v8#56}
Cr-Branched-From: 5123834-refs/heads/9.2.230@{#1}
Cr-Branched-From: 587a04f-refs/heads/master@{#74656}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@LeszekSwirski
Merged: [compiler] Don't elide ChangeTaggedToInt32->ChangeInt31ToTagg…
418c276 
…edSigned

(cherry picked from commit 4fae8b1)

(cherry picked from commit f4f11c2)

Bug: chromium:1278387
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: I9b89834c094510e064988aa534ec230309996034
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3329665
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Cr-Original-Commit-Position: refs/branch-heads/9.6@{v8#40}
Cr-Original-Branched-From: 0b7bda0-refs/heads/9.6.180@{#1}
Cr-Original-Branched-From: 41a5a24-refs/heads/main@{#77244}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3335759
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Owners-Override: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/branch-heads/9.4@{v8#56}
Cr-Branched-From: 3b51863-refs/heads/9.4.146@{#1}
Cr-Branched-From: 2890419-refs/heads/master@{#76233}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@mi-ac
Merged: Remove --isolated from mb.py
c84c0ac 
Revision: 55a26dc

BUG=chromium:1271841
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=liviurau@chromium.org

Change-Id: I22ccda99a9044139390baea558b873d0c2355b4c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3312480
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/branch-heads/9.5@{v8#56}
Cr-Branched-From: 4a03d61-refs/heads/9.5.172@{#1}
Cr-Branched-From: 9a60704-refs/heads/main@{#76741}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@achuith
Merged: [deoptimizer] Stricter checks during deoptimization
ad2c5da 
Revision: 506e893

BUG=chromium:1161357
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=​mythria@chromium.org

(cherry picked from commit 44d052c)

Change-Id: I97b69ae11d85bc0acd4a0c7bd28e1b692433de80
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2616219
Reviewed-by: Mythri Alle <mythria@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Original-Commit-Position: refs/branch-heads/8.8@{v8#23}
Cr-Original-Branched-From: 2dbcdc1-refs/heads/8.8.278@{#1}
Cr-Original-Branched-From: 366d30c-refs/heads/master@{#71094}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2649571
Reviewed-by: Victor-Gabriel Savu <vsavu@google.com>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/branch-heads/8.6@{v8#56}
Cr-Branched-From: a64aed2-refs/heads/8.6.395@{#1}
Cr-Branched-From: a626bc0-refs/heads/master@{#69472}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
@isheludko
[M96-LTS][runtime] Fix handling of interceptors, pt.3
f599381 
... in JSObject::DefineOwnPropertyIgnoreAttributes().
Don't execute interceptor again if it declined to handle the operation.

(cherry picked from commit c4e66b8)

Bug: chromium:1311641
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: Ie9aef5a98959403f6a26e6bef7f4a77d312bd62a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568921
Reviewed-by: Lutz Vahl <vahl@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/branch-heads/9.6@{v8#56}
Cr-Branched-From: 0b7bda0-refs/heads/9.6.180@{#1}
Cr-Branched-From: 41a5a24-refs/heads/main@{#77244}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Version 9.0.257.28
3e9c5cc 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I1e0d6d6f5c62c6a08cd28ea69f98df916407c394
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2880134
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/9.0@{v8#56}
Cr-Branched-From: bd0108b-refs/heads/9.0.257@{#1}
Cr-Branched-From: 349bcc6-refs/heads/master@{#73001}
cb-robot pushed a commit to couchbasedeps/v8-mirror that referenced this pull request Aug 24, 2022
Version 8.7.220.28
4a35720 
TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com

Change-Id: I59662b601c8b916426c936f5828123186fa5d271
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565064
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/8.7@{v8#56}
Cr-Branched-From: 0d81cd7-refs/heads/8.7.220@{#1}
Cr-Branched-From: 942c2ef-refs/heads/master@{#70196}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request May 31, 2023
@isheludko
Reland "[M108-LTS][runtime] Make Error.captureStackTrace() a no-op fo…
5b2a75d 
…r global object"

This is a reland of commit 12be50e

Original change's description:
> [M108-LTS][runtime] Make Error.captureStackTrace() a no-op for global object
>
> (cherry picked from commit fa81078)
>
> Bug: chromium:1432210
> Change-Id: I8aa4c3f1d9ecbfffce503085c2879416ff916c69
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4417690
> Commit-Queue: Igor Sheludko <ishell@chromium.org>
> Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
> Auto-Submit: Igor Sheludko <ishell@chromium.org>
> Cr-Original-Commit-Position: refs/heads/main@{#87045}
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4422621
> Reviewed-by: Igor Sheludko <ishell@chromium.org>
> Cr-Commit-Position: refs/branch-heads/10.8@{v8#52}
> Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1}
> Cr-Branched-From: 237de89-refs/heads/main@{#83672}

Bug: chromium:1432210
No-Try: true
No-Presubmit: true
No-Tree-Checks: true
Change-Id: I4c06a76db005a61b2259b836c1f06c78eb004e16
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4459252
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Roger Felipe Zanoni da Silva <rzanoni@google.com>
Cr-Commit-Position: refs/branch-heads/10.8@{v8#56}
Cr-Branched-From: f1bc03f-refs/heads/10.8.168@{#1}
Cr-Branched-From: 237de89-refs/heads/main@{#83672}
patrik-lengweiler pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Jul 19, 2023
Version 11.4.183.28
d7561b8 
Change-Id: I74c90d49a75481b7416856216c27f70026b95e1a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4690952
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/11.4@{v8#56}
Cr-Branched-From: 8a8a1e7-refs/heads/11.4.183@{#1}
Cr-Branched-From: 5483d8e-refs/heads/main@{#87241}
reposynch bot pushed a commit to hexagon-geo-surv/v8 that referenced this pull request Feb 4, 2024
Version 12.1.285.28
1fbb988 
Change-Id: I8aa73511a33cf2cebf4eb6557cc00900e0d1bb72
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5243954
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.1@{v8#56}
Cr-Branched-From: b74ef6f-refs/heads/12.1.285@{#1}
Cr-Branched-From: 32857fb-refs/heads/main@{#91313}
hubot pushed a commit that referenced this pull request May 29, 2024
@syg
[M120-LTS][ic] Use slow stub element handler for non-JSObjects
b91805d 
(cherry picked from commit 8a69c78)

Fixed: b/339736513
Change-Id: I134a046475b0b004c3de1bacc5b2f1a7fa503d96
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5527898
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Auto-Submit: Shu-yu Guo <syg@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#93847}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5572484
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Roger Felipe Zanoni da Silva <rzanoni@google.com>
Reviewed-by: Artem Sumaneev <asumaneev@google.com>
Cr-Commit-Position: refs/branch-heads/12.0@{#56}
Cr-Branched-From: ed7b4ca-refs/heads/12.0.267@{#1}
Cr-Branched-From: 210e75b-refs/heads/main@{#90651}
hubot pushed a commit that referenced this pull request Aug 5, 2024
@syg
Merged: [parser] Fix HomeObjectScope to start at the receiver scope
7acd351 
Bug: 352690885
(cherry picked from commit af7f8f0)

Change-Id: Icabc232c03142d6f4137f6ae5fb8359c7cf1b9ee
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5762851
Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
Cr-Commit-Position: refs/branch-heads/12.6@{#56}
Cr-Branched-From: 3c9fa12-refs/heads/12.6.228@{#2}
Cr-Branched-From: 981bb15-refs/heads/main@{#93835}
hubot pushed a commit that referenced this pull request Sep 4, 2024
@Liedtke
Merged: [compiler][wasm] Fix TypeGuard on br_on_cast with null type
7929e3e 
Similar pattern to https://crrev.com/c/5826664 .

(cherry picked from commit c42a07f)

Fixed: 361862737
Change-Id: I59c3cea5d572423aa06583a1448bf7486213a233
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5829361
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Auto-Submit: Matthias Liedtke <mliedtke@chromium.org>
Commit-Queue: Matthias Liedtke <mliedtke@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#95899}
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5833495
Reviewed-by: Manos Koukoutos <manoskouk@chromium.org>
Commit-Queue: Eva Herencsárová <evih@chromium.org>
Cr-Commit-Position: refs/branch-heads/12.8@{#56}
Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1}
Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
hubot pushed a commit that referenced this pull request Oct 8, 2024
Version 12.9.202.28
f372edd 
Change-Id: Ifd75a9fb6cc54fef667c79def0b9825e8602875b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5912979
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/12.9@{#56}
Cr-Branched-From: 64a21d7-refs/heads/12.9.202@{#1}
Cr-Branched-From: da4200b-refs/heads/main@{#95679}
hubot pushed a commit that referenced this pull request Jan 9, 2025
@thibaudmichaud
Merged: [wasm] Add missing entry to wasm builtin list
d6e8638 
Add the invalid wasm-to-js signature wrapper to the list of wasm
builtins. This builtin is called from wasm and calls a runtime function,
so it needs to switch to the central stack if needed.

R=clemensb@chromium.org

Fixed: 383854201
(cherry picked from commit 0cb861f)

Change-Id: I246d0681c35f242f2875e8824ec9b13ae49db773
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6163547
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Commit-Queue: Thibaud Michaud <thibaudm@chromium.org>
Cr-Commit-Position: refs/branch-heads/13.2@{#56}
Cr-Branched-From: 24068c5-refs/heads/13.2.152@{#1}
Cr-Branched-From: 6054ba9-refs/heads/main@{#97085}
hubot pushed a commit that referenced this pull request Jul 18, 2025
Version 13.8.258.28
dcf190c 
Version incremented at https://cr-buildbucket.appspot.com/build/8709002596922352545

Change-Id: Ib984ccd1935f541b15dc0f93dd33ccd7d66566c2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6768647
Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/13.8@{#56}
Cr-Branched-From: 61ddd47-refs/heads/13.8.258@{#1}
Cr-Branched-From: fdb5de2-refs/heads/main@{#100480}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ErdemIpek