USWDS - Footer: Added styling for WHC Mode#4528
Conversation
Because currently, it is not testing anything.
The following updates have been made to remove redundancies with the updated Getting Started guidance for developers and per conversation with the dev team: –"Download and install" has been made more specific: "Download and install without npm." –"Install using npm" has been removed. References to this section have tentatively been replaced with "NEW LINK," and prior to publication, will be replaced with the link to the updated web guidance for Getting Started for devs. –Content of "Use another framework or package manager" has been moved up to appear under "Using the design system." –"Accessibility" has been updated to note a few of the tools we use to ensure USWDS is accessible.
Added link to new dev guidance
Co-authored-by: James Mejia <james.mejia@gsa.gov>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.14.7...v1.14.8) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…directs-1.14.8 Bump follow-redirects from 1.14.7 to 1.14.8
[Docs] - [CONTRIBUTING]: Fix broken "Browser Support" link
Tests: Update "Behavior" spec to test expected behavior
USWDS - Combobox: add aria-controls for 508 compliance
Icon: Remove inline style in GitHub icon to fix CSP error
…vior on primary-link
Change fractal output directory to standard Federalist setup.
USWDS Footer - bug fix: reveal hidden content at 480px window width
Use partial pixel to support high dpi
USWDS 2.13.2
Sync 2.13.2
Post Getting Started Updates_Nov 30, 2021
mejiaj
left a comment
There was a problem hiding this comment.
Good work, added some suggestions to tidy it up a bit.
thisisdano
left a comment
There was a problem hiding this comment.
LGTM once you address James's comments
|
@mahoneycm @mejiaj @thisisdano We will have to be careful of how these changes will play with the changes in PR #4476. I know we are working on merging both at around the same time, and I am concerned about the differences in markup/scss. Flagging for awareness! |
|
@mahoneycm I am concerned about the social media icon color contrast shown in your screenshots - I don't have great access to windows HC mode but I am wondering if it is possible to override either the background or icon color with |
|
Used
|
Preview
Footer →
Description
Resolves #4517 footer issues
Currently, social media icons and expand chevrons (mobile only) disappear in dark high contrast modes, causing the user to lose context and content.
This PR also fixes the disappearing chevrons in the big footer variant in mobile views.
Additional information
Social Icons
Currently:
Alternative color shows hover
Default
High Contrast
After Fix:
Mobile Chevrons
Currently:
After Fix:
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.