Skip to content

[ Website ]: Removing JavaScript from website#1368

Merged
maya merged 10 commits into
stagingfrom
website-eradicate-js
Aug 8, 2016
Merged

[ Website ]: Removing JavaScript from website#1368
maya merged 10 commits into
stagingfrom
website-eradicate-js

Conversation

@rogeruiz

@rogeruiz rogeruiz commented Aug 2, 2016

Copy link
Copy Markdown
Contributor

Description

Removing the JavaScript from the website will help with maintaining the website going forward. Take a look at the AC from #1353.

@rogeruiz rogeruiz changed the title Removing JavaScript from website [ work in progress ] [ Website ]: Removing JavaScript from website Aug 2, 2016
rogeruiz and others added 3 commits August 2, 2016 22:50
[ Website ]: Generate code snippets within gulp
This patch reverts the changes made previously here #743 which caused
the following issue and PR, Issue: #990, PR: #1285.
@rogeruiz rogeruiz assigned rogeruiz and yozlet and unassigned rogeruiz Aug 4, 2016
Remove hash for `javascript:void(0);` in examples;
@rogeruiz

rogeruiz commented Aug 5, 2016

Copy link
Copy Markdown
Contributor Author

Do we want to add some documentation for the reasoning behind #1378 in this PR? We've gone back and forth on this issue of href="#" versus href="javascript:void(0);". I'd like to remove the ambiguity here and avoid discussions around what we suggest. The latter, href="javascript:void(0);" should be what our examples use so we don't need any additional javascript to prevent href="#" from going to the top, but we should have some documentation on the UI component for links maybe that discusses:

  • why we do this in the examples
  • why your mileage may vary when setting href="#" when implementing the standards.

Thoughts on this @yozlet @maya @msecret @juliaelman @kategarklavs @jameshupp

@maya

maya commented Aug 5, 2016

Copy link
Copy Markdown
Contributor

@rogeruiz We use these in many components: footer, forms, etc so I don't think the reasoning for it would go in links since it's styleguide site specific thing. But I love the idea of explaining our reasoning, so we should do that on the issue that was originally opened for it and tag the people involved in it.

@rogeruiz rogeruiz changed the title [ work in progress ] [ Website ]: Removing JavaScript from website [ Website ]: Removing JavaScript from website Aug 8, 2016
@rogeruiz

rogeruiz commented Aug 8, 2016

Copy link
Copy Markdown
Contributor Author

This does not touch the sticky-nav.js or any of the JavaScript related to the side-navigation UI component. Those will need to be worked on in another PR.

@maya maya merged commit 83d1c22 into staging Aug 8, 2016
@rogeruiz rogeruiz deleted the website-eradicate-js branch August 8, 2016 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants