Fix "Return to top" within footer examples#1285
Merged
Merged
Conversation
This patch allows `return to top` links to return to top based on checking the text content of the element that is clicked. This closes #990.
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The issue around the "Return to top" examples not working #990 mentions that the intended behavior of those examples are to have the page return to the top. Currently the documentation site has a
handleDisabledLinksfunction which aggressively disables<a>with thehref="#"attribute. This patch updates this function to not disable links forreturn to toplinks. This allows for the examples to work as expected.This closes #990.