Skip to content

Remove hash for javascript:void(0); in examples;#1378

Merged
msecret merged 2 commits into
website-eradicate-jsfrom
website-fix-href-attr
Aug 4, 2016
Merged

Remove hash for javascript:void(0); in examples;#1378
msecret merged 2 commits into
website-eradicate-jsfrom
website-fix-href-attr

Conversation

@rogeruiz

@rogeruiz rogeruiz commented Aug 4, 2016

Copy link
Copy Markdown
Contributor

This patch reverts the changes made previously here #743 which caused
the following issue and PR, Issue: #990, PR: #1285.

Acceptance Criteria

  • refactor all the href="#" to be href="javascript:void(0);"
  • remove the handle-disabled-lints.js [sic] JavaScript file

This patch reverts the changes made previously here #743 which caused
the following issue and PR, Issue: #990, PR: #1285.
@rogeruiz

rogeruiz commented Aug 4, 2016

Copy link
Copy Markdown
Contributor Author

Merging into #1368 and addresses #1353.

@rogeruiz

rogeruiz commented Aug 4, 2016

Copy link
Copy Markdown
Contributor Author

Could you review this @yozlet

@yozlet

yozlet commented Aug 4, 2016

Copy link
Copy Markdown
Contributor

👍 :shipit:

@msecret msecret merged commit df51519 into website-eradicate-js Aug 4, 2016
@rogeruiz rogeruiz deleted the website-fix-href-attr branch August 5, 2016 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants