Skip to content

[ Website ]: Generate code snippets within gulp#1370

Merged
juliasolorzano merged 5 commits into
website-eradicate-jsfrom
website-update-code-snippets
Aug 4, 2016
Merged

[ Website ]: Generate code snippets within gulp#1370
juliasolorzano merged 5 commits into
website-eradicate-jsfrom
website-update-code-snippets

Conversation

@rogeruiz

@rogeruiz rogeruiz commented Aug 2, 2016

Copy link
Copy Markdown
Contributor

Description

Generate code snippets and preview snippets within the build pipeline instead of in the docs/ directory.

Before you hit Submit, make sure you’ve done whichever of these applies to you:

  • Follow the 18F Front End Coding Style Guide and Accessibility Guide.
  • Run npm test and make sure the tests for the files you have changed have passed.
  • Run your code through HTML_CodeSniffer and make sure it’s error free.
  • Title your pull request using this format: [Website] - [UI component]: Brief statement describing what this pull request solves.

@rogeruiz rogeruiz self-assigned this Aug 2, 2016
Comment thread docs/_components/accordions.md Outdated

@rogeruiz rogeruiz Aug 2, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files still exist in the repository, but the file names that they pull in, represented by the component="" parameter, are now generated using gulp and come in from src/html.

@rogeruiz rogeruiz force-pushed the website-update-code-snippets branch from c2af1ad to 5d02dd5 Compare August 2, 2016 23:13
@rogeruiz

rogeruiz commented Aug 3, 2016

Copy link
Copy Markdown
Contributor Author

Tied to the issue #1353 and merging into #1368 once it's reviewed.

@rogeruiz rogeruiz changed the title [ work in progress ] [ Website ]: Generate code snippets within gulp [ Website ]: Generate code snippets within gulp Aug 3, 2016
@rogeruiz

rogeruiz commented Aug 3, 2016

Copy link
Copy Markdown
Contributor Author

cc: @msecret @maya @juliaelman @yozlet

@msecret

msecret commented Aug 3, 2016

Copy link
Copy Markdown
Contributor

THis looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants