[Website] & [UI component]: Lint & fix SCSS files in site docs by yozlet · Pull Request #1180 · uswds/uswds

yozlet · 2016-05-20T22:28:27Z

Description

Pull in fixes from #987 #985 and #1063, and add lint tasks for website CSS, and fix existing errors!

(Pairing with @rogeruiz)

Still in progress, do not merge

Additional Information

Add gulp task for linting the documentation styles
Bringing in @nickjs patches from Fix 203 scss-lint warnings #987, Readd styleguide.scss linter fixes after they got lost in a merge #985, and Fix styleguide again #1063
Fix any remaining errors

maya · 2016-05-20T22:34:34Z

yay! one small thing to note, when bringing in the patches, we'll want to change this one back to the original: #985 (diff)

msecret · 2016-05-24T18:07:49Z

+    .pipe(gulp.dest('tmpdocs'));
+});
+
+gulp.task('lint-tmp-docs-scss', function (done) {


When this lint tasks finds errors, will it point to this tmpdocs directory as the path of the files with problems?

It should only include the file name and line number, so it doesn't matter where the file lives. But, the initial line of where it found the errors, will be in the tmpdocs/ directory. We could have it say that it's checking files in doc_assets/ before it outputs any errors. That way people know where to find them more easily.

Here's some output from running it locally right now.

[16:08:29] Starting 'lint-tmp-docs-scss'... [16:08:30] 13 issues found in /Users/rogerruiz/Developer/federal-front-door/web-design-standards/tmpdocs/homepage.scss [16:08:30] homepage.scss:39 [W] EmptyLineBetweenBlocks: @include declaration should be followed by an empty line [16:08:30] homepage.scss:47 [W] StringQuotes: Prefer single quoted strings [16:08:30] homepage.scss:51 [W] EmptyLineBetweenBlocks: @include declaration should be followed by an empty line [16:08:30] homepage.scss:73 [W] EmptyLineBetweenBlocks: @include declaration should be followed by an empty line [16:08:30] homepage.scss:150 [W] MergeableSelector: Merge rule `.usa-circle-block` with rule on line 130 [16:08:30] homepage.scss:154 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] homepage.scss:154 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] homepage.scss:154 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] homepage.scss:154 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] homepage.scss:154 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] homepage.scss:159 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] homepage.scss:182 [W] SpaceBeforeBrace: Opening curly brace `{` should be preceded by one space [16:08:30] homepage.scss:198 [W] MergeableSelector: Merge rule `.usa-section-examples` with rule on line 24 [16:08:30] 98 issues found in /Users/rogerruiz/Developer/federal-front-door/web-design-standards/tmpdocs/styleguide.scss [16:08:30] styleguide.scss:32 [W] EmptyLineBetweenBlocks: @include declaration should be followed by an empty line [16:08:30] styleguide.scss:40 [W] EmptyLineBetweenBlocks: @include declaration should be followed by an empty line [16:08:30] styleguide.scss:46 [W] SelectorDepth: Selector should have depth of applicability no greater than 3, but was 4 [16:08:30] styleguide.scss:49 [W] SelectorDepth: Selector should have depth of applicability no greater than 3, but was 4 [16:08:30] styleguide.scss:49 [W] NestingDepth: Nesting should be no greater than 4, but was 5 [16:08:30] styleguide.scss:61 [W] EmptyLineBetweenBlocks: @include declaration should be followed by an empty line [16:08:30] styleguide.scss:70 [W] EmptyLineBetweenBlocks: @include declaration should be followed by an empty line [16:08:30] styleguide.scss:75 [W] SelectorDepth: Selector should have depth of applicability no greater than 3, but was 4 [16:08:30] styleguide.scss:79 [W] SelectorDepth: Selector should have depth of applicability no greater than 3, but was 5 [16:08:30] styleguide.scss:79 [W] NestingDepth: Nesting should be no greater than 4, but was 5 [16:08:30] styleguide.scss:88 [W] ColorVariable: Color literals like `white` should only be used in variable declarations; they should be referred to via variable everywhere else. [16:08:30] styleguide.scss:88 [W] ColorKeyword: Color `white` should be written in hexadecimal form as `#ffffff` [16:08:30] styleguide.scss:91 [W] ColorVariable: Color literals like `#616161` should only be used in variable declarations; they should be referred to via variable everywhere else. [16:08:30] styleguide.scss:93 [W] EmptyLineBetweenBlocks: Rule declaration should be preceded by an empty line [16:08:30] styleguide.scss:95 [W] EmptyLineBetweenBlocks: Rule declaration should be followed by an empty line [16:08:30] styleguide.scss:97 [W] SelectorDepth: Selector should have depth of applicability no greater than 3, but was 4 [16:08:30] styleguide.scss:101 [W] EmptyLineBetweenBlocks: Rule declaration should be followed by an empty line [16:08:30] styleguide.scss:105 [W] EmptyLineBetweenBlocks: Rule declaration should be followed by an empty line [16:08:30] styleguide.scss:118 [W] EmptyLineBetweenBlocks: @include declaration should be followed by an empty line [16:08:30] styleguide.scss:140 [W] IdSelector: Avoid using id selectors [16:08:30] styleguide.scss:147 [W] ColorVariable: Color literals like `#fff` should only be used in variable declarations; they should be referred to via variable everywhere else. [16:08:30] styleguide.scss:152 [W] EmptyLineBetweenBlocks: Rule declaration should be preceded by an empty line [16:08:30] styleguide.scss:162 [W] ColorVariable: Color literals like `#000` should only be used in variable declarations; they should be referred to via variable everywhere else. [16:08:30] styleguide.scss:201 [W] SelectorDepth: Selector should have depth of applicability no greater than 3, but was 4 [16:08:30] styleguide.scss:223 [W] EmptyLineBetweenBlocks: @include declaration should be followed by an empty line [16:08:30] styleguide.scss:228 [W] EmptyLineBetweenBlocks: Rule declaration should be preceded by an empty line [16:08:30] styleguide.scss:234 [W] EmptyLineBetweenBlocks: Rule declaration should be preceded by an empty line [16:08:30] styleguide.scss:250 [W] EmptyLineBetweenBlocks: Rule declaration should be preceded by an empty line [16:08:30] styleguide.scss:253 [W] EmptyLineBetweenBlocks: Rule declaration should be followed by an empty line [16:08:30] styleguide.scss:268 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:271 [W] EmptyLineBetweenBlocks: @include declaration should be followed by an empty line [16:08:30] styleguide.scss:282 [W] ColorVariable: Color literals like `#fff` should only be used in variable declarations; they should be referred to via variable everywhere else. [16:08:30] styleguide.scss:285 [W] ColorVariable: Color literals like `#eeeeee` should only be used in variable declarations; they should be referred to via variable everywhere else. [16:08:30] styleguide.scss:286 [W] EmptyLineBetweenBlocks: Rule declaration should be preceded by an empty line [16:08:30] styleguide.scss:301 [W] PseudoElement: Begin pseudo elements with double colons: `::` [16:08:30] styleguide.scss:302 [W] StringQuotes: Prefer single quoted strings [16:08:30] styleguide.scss:311 [W] PseudoElement: Begin pseudo elements with double colons: `::` [16:08:30] styleguide.scss:312 [W] StringQuotes: Prefer single quoted strings [16:08:30] styleguide.scss:323 [W] ColorVariable: Color literals like `#f5f5f5` should only be used in variable declarations; they should be referred to via variable everywhere else. [16:08:30] styleguide.scss:324 [W] ColorVariable: Color literals like `#e0e0e0` should only be used in variable declarations; they should be referred to via variable everywhere else. [16:08:30] styleguide.scss:328 [W] SelectorDepth: Selector should have depth of applicability no greater than 3, but was 4 [16:08:30] styleguide.scss:333 [W] SelectorDepth: Selector should have depth of applicability no greater than 3, but was 4 [16:08:30] styleguide.scss:333 [W] NestingDepth: Nesting should be no greater than 4, but was 5 [16:08:30] styleguide.scss:344 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:415 [W] ColorVariable: Color literals like `#000` should only be used in variable declarations; they should be referred to via variable everywhere else. [16:08:30] styleguide.scss:429 [W] TrailingSemicolon: Declaration should be terminated by a semicolon [16:08:30] styleguide.scss:436 [W] ZeroUnit: `0rem` should be written without units as `0` [16:08:30] styleguide.scss:448 [W] TrailingSemicolon: Declaration should be terminated by a semicolon [16:08:30] styleguide.scss:448 [W] ColorVariable: Color literals like `#323a45` should only be used in variable declarations; they should be referred to via variable everywhere else. [16:08:30] styleguide.scss:465 [W] EmptyLineBetweenBlocks: @include declaration should be followed by an empty line [16:08:30] styleguide.scss:486 [W] EmptyLineBetweenBlocks: @include declaration should be followed by an empty line [16:08:30] styleguide.scss:491 [W] SpaceAfterPropertyColon: Colon after property should be followed by one space [16:08:30] styleguide.scss:498 [W] EmptyLineBetweenBlocks: @include declaration should be followed by an empty line [16:08:30] styleguide.scss:517 [W] EmptyLineBetweenBlocks: @include declaration should be followed by an empty line [16:08:30] styleguide.scss:536 [W] MergeableSelector: Merge rule `.usa-color-name` with rule on line 462 [16:08:30] styleguide.scss:627 [W] MergeableSelector: Merge rule `.usa-color-gray-dark` with rule on line 570 [16:08:30] styleguide.scss:631 [W] MergeableSelector: Merge rule `.usa-color-gray-light` with rule on line 574 [16:08:30] styleguide.scss:745 [W] MergeableSelector: Merge rule `.usa-color-text-gray-dark` with rule on line 741 [16:08:30] styleguide.scss:778 [W] QualifyingElement: Avoid qualifying class selectors with an element. [16:08:30] styleguide.scss:783 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:783 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:783 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:783 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:783 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:783 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:809 [W] QualifyingElement: Avoid qualifying attribute selectors with an element. [16:08:30] styleguide.scss:809 [W] QualifyingElement: Avoid qualifying attribute selectors with an element. [16:08:30] styleguide.scss:809 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:810 [W] Indentation: Line should be indented 2 spaces, but was indented 4 spaces [16:08:30] styleguide.scss:813 [W] QualifyingElement: Avoid qualifying attribute selectors with an element. [16:08:30] styleguide.scss:813 [W] QualifyingElement: Avoid qualifying attribute selectors with an element. [16:08:30] styleguide.scss:813 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:817 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:817 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:817 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:817 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:817 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:817 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:821 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:821 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:821 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:821 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:821 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:825 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:825 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:830 [W] Indentation: Line should be indented 2 spaces, but was indented 4 spaces [16:08:30] styleguide.scss:837 [W] QualifyingElement: Avoid qualifying attribute selectors with an element. [16:08:30] styleguide.scss:841 [W] MergeableSelector: Merge rule `.preview` with rule on line 280 [16:08:30] styleguide.scss:873 [W] EmptyLineBetweenBlocks: Rule declaration should be followed by an empty line [16:08:30] styleguide.scss:883 [W] EmptyLineBetweenBlocks: Rule declaration should be followed by an empty line [16:08:30] styleguide.scss:908 [W] MergeableSelector: Merge rule `.usa-font-lead.usa-font-lead-alt` with rule on line 904 [16:08:30] styleguide.scss:924 [W] MergeableSelector: Merge rule `.usa-font-lead.usa-font-lead-alt` with rule on line 920 [16:08:30] styleguide.scss:932 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:932 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:932 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:932 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:932 [W] SingleLinePerSelector: Each selector in a comma sequence should be on its own single line [16:08:30] styleguide.scss:1013 [W] EmptyLineBetweenBlocks: @include declaration should be followed by an empty line [16:08:30] Finished 'lint-tmp-docs-scss' after 1.4 s

@msecret

I added this line to the output of gulp scss-lint-docs

[16:16:54] scss-lint-docs Linting files found by `docs/doc_assets/**/*.scss`

~~On further inspection, I've also noticed that all linting line numbers are now off by three within this gulp task because of the empty lines at the top of the file without the --- triple dashes.~~ Nevermind on that. It was human error. 💫

Awesome, I think that's perfect then

[UI component]: Footer h4 semantics

[Website]: Move CONTRIBUTING file to root directory

msecret · 2016-05-24T20:47:19Z

LGTM once the conflicts are fixed.

This patch disables very stubborn rules which would require us to refactor some markup on the styleguide site. For now they're disabled.

…s into scss-linting-fix # Conflicts: # src/stylesheets/components/_footer.scss

rogeruiz · 2016-05-25T12:55:36Z

~~@yozlet, where are we at for errors and warnings? Are we at peak fixes?~~ never mind, I commented below with what I found. 👍

rogeruiz · 2016-05-25T16:16:30Z

I'm posting this here for visibility. With all the work on this branch, I ran gulp scss-lint-docs scss-lint to see what the remaining ~~errors~~ warnings are.

[12:09:55] 2 issues found in /Users/rogerruiz/Developer/federal-front-door/web-design-standards/src/stylesheets/components/_accordions.scss
[12:09:55] components/_accordions.scss:29 [W] QualifyingElement: Avoid qualifying attribute selectors with an element.
[12:09:55] components/_accordions.scss:36 [W] PropertyCount: Rule set contains (13/10) properties
[12:09:55] 8 issues found in /Users/rogerruiz/Developer/federal-front-door/web-design-standards/src/stylesheets/components/_forms.scss
[12:09:55] components/_forms.scss:12 [W] QualifyingElement: Avoid qualifying attribute selectors with an element.
[12:09:55] components/_forms.scss:12 [W] QualifyingElement: Avoid qualifying attribute selectors with an element.
[12:09:55] components/_forms.scss:25 [W] QualifyingElement: Avoid qualifying attribute selectors with an element.
[12:09:55] components/_forms.scss:25 [W] QualifyingElement: Avoid qualifying attribute selectors with an element.
[12:09:55] components/_forms.scss:54 [W] QualifyingElement: Avoid qualifying class selectors with an element.
[12:09:55] components/_forms.scss:60 [W] QualifyingElement: Avoid qualifying class selectors with an element.
[12:09:55] components/_forms.scss:134 [W] QualifyingElement: Avoid qualifying attribute selectors with an element.
[12:09:55] components/_forms.scss:134 [W] QualifyingElement: Avoid qualifying attribute selectors with an element.
[12:09:55] 2 issues found in /Users/rogerruiz/Developer/federal-front-door/web-design-standards/src/stylesheets/components/_sidenav.scss
[12:09:55] components/_sidenav.scss:37 [W] MergeableSelector: Merge rule `&.usa-current` with rule on line 32
[12:09:55] components/_sidenav.scss:58 [W] QualifyingElement: Avoid qualifying class selectors with an element.
[12:09:55] 2 issues found in /Users/rogerruiz/Developer/federal-front-door/web-design-standards/src/stylesheets/core/_base.scss
[12:09:55] core/_base.scss:21 [W] ImportantRule: !important should not be used
[12:09:55] core/_base.scss:26 [W] ImportantRule: !important should not be used
[12:09:55] 1 issues found in /Users/rogerruiz/Developer/federal-front-door/web-design-standards/src/stylesheets/core/_variables.scss
[12:09:55] core/_variables.scss:88 [W] ColorVariable: Color literals like `rgba(#000, 0.3)` should only be used in variable declarations; they should be referred to via variable everywhere else.
[12:09:55] 2 issues found in /Users/rogerruiz/Developer/federal-front-door/web-design-standards/src/stylesheets/elements/_buttons.scss
[12:09:55] elements/_buttons.scss:7 [W] PropertyCount: Rule set contains (20/10) properties
[12:09:55] elements/_buttons.scss:165 [W] SpaceBeforeBrace: Opening curly brace `{` should be preceded by one space

The styleguide files are passing the linter without an issue, but they are also disabling quite a few rules to do so. The reason being outlined in this commit. Some of the scss-lint rules in the yaml file are good for most problems, but others should maybe be ignored?

The use of !important is something that we might actually need in the core/_base.scss file. and the ProperyCount rules are also things that might need to be ignored as well. The QualifyingElement rule within the components/_forms.scss is something that we may want to ignore too, because these are targeting <form> child-elements that need to be qualified since they may/can share attributes.

I think we can either ignore some of these linting errors and warnings with scss-lint:disable comments, or fix them. And if we fix them, we might have to update some markup or we might not. But I'd rather get a consensus from the team on how to approach this issue. Because these are edge cases for sure.

cc: @yozlet @maya @juliaelman @msecret

Lint SCSS files in site docs

d4f3a27

yozlet added [Status] In progress labels May 20, 2016

yozlet self-assigned this May 20, 2016

This was referenced May 23, 2016

Fix styleguide again #1063

Closed

Fix 203 scss-lint warnings #987

Closed

Readd styleguide.scss linter fixes after they got lost in a merge #985

Closed

madmanlear and others added 10 commits May 23, 2016 08:35

wrap big footer h4 in li

648d93b

remove top margin from h4 in big footer

42c1960

fix footer primary link formatting

8373b72

src: fix primary link spacing on desktop

5c95c28

remove top margin from h4 in big footer

d727a34

fix footer primary link formatting

cb5ee11

Indent html

9656476

Fix margins

a7e8b2c

Move CONTRIBUTING file to root directory

7e99b03

Remove h4 dependency

1971c99

msecret reviewed May 24, 2016
View reviewed changes

Maya Benari and others added 5 commits May 24, 2016 11:09

Merge pull request #1183 from 18F/footer-h4-semantics

9814762

[UI component]: Footer h4 semantics

Lots of scss-lint fixes, with minor tweaks to linter config

78ec06c

Merge pull request #1185 from 18F/move-contributing

2cb7014

[Website]: Move CONTRIBUTING file to root directory

Add message around what files are being linted

0eed675

Fix various linting errors

2143af4

rogeruiz added 2 commits May 24, 2016 17:07

Disable very stubborn rules;

1fda7d9

This patch disables very stubborn rules which would require us to refactor some markup on the styleguide site. For now they're disabled.

Fix various linting errors

11ec61c

yozlet and others added 10 commits May 24, 2016 16:49

Lint SCSS files in site docs

fd660ec

Fix merge conflicts in components/_footer

d2ba608

Add message around what files are being linted

4994bf3

Fix various linting errors

fafd2c6

Disable very stubborn rules;

2d567a1

This patch disables very stubborn rules which would require us to refactor some markup on the styleguide site. For now they're disabled.

Fix various linting errors

9ade628

Merge branch 'scss-linting-fix' of github.com:18F/web-design-standard…

8d60d37

…s into scss-linting-fix # Conflicts: # src/stylesheets/components/_footer.scss

Fix missing color ref in styleguide

5c96ce5

Fix footer lint errors with selective disabling

aa733f6

Clean up styleguide.scss with fixes & more selective lint disable

201b14a

rogeruiz changed the title ~~[WIP] [Website] & [UI component]: Lint & fix SCSS files in site docs~~ [Website] & [UI component]: Lint & fix SCSS files in site docs May 25, 2016

maya merged commit fd9018f into 18f-pages-staging May 25, 2016

maya deleted the scss-linting-fix branch May 25, 2016 16:56

maya removed the [Status] In progress label May 25, 2016

yozlet mentioned this pull request May 25, 2016

[Maintenance] Fix remaining lint issues #1190

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Website] & [UI component]: Lint & fix SCSS files in site docs#1180

[Website] & [UI component]: Lint & fix SCSS files in site docs#1180
maya merged 28 commits into
18f-pages-stagingfrom
scss-linting-fix

yozlet commented May 20, 2016 •

edited by juliasolorzano

Loading

Uh oh!

maya commented May 20, 2016

Uh oh!

msecret May 24, 2016

Uh oh!

rogeruiz May 24, 2016 •

edited

Loading

Uh oh!

rogeruiz May 24, 2016

Uh oh!

rogeruiz May 24, 2016 •

edited

Loading

Uh oh!

msecret May 24, 2016

Uh oh!

msecret commented May 24, 2016

Uh oh!

rogeruiz commented May 25, 2016 •

edited

Loading

Uh oh!

rogeruiz commented May 25, 2016 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

yozlet commented May 20, 2016 • edited by juliasolorzano Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Additional Information

Uh oh!

maya commented May 20, 2016

Uh oh!

msecret May 24, 2016

Choose a reason for hiding this comment

Uh oh!

rogeruiz May 24, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rogeruiz May 24, 2016

Choose a reason for hiding this comment

Uh oh!

rogeruiz May 24, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

msecret May 24, 2016

Choose a reason for hiding this comment

Uh oh!

msecret commented May 24, 2016

Uh oh!

rogeruiz commented May 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rogeruiz commented May 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

yozlet commented May 20, 2016 •

edited by juliasolorzano

Loading

rogeruiz May 24, 2016 •

edited

Loading

rogeruiz May 24, 2016 •

edited

Loading

rogeruiz commented May 25, 2016 •

edited

Loading

rogeruiz commented May 25, 2016 •

edited

Loading