Fix 203 scss-lint warnings#987
Conversation
There was a problem hiding this comment.
There's a few of these, we should probably figure out a way forward
There was a problem hiding this comment.
Omg I must have stared at these for like 2 minutes trying to figure out why every image was duplicated. Must have just had a moment of code blindness where the two lines looked exactly the same. Totally did not notice the file extension was different. Will revert now.
However, it does cause a linter warning, because it's a duplicate property. I guess there's no way around that...
|
@nickjs Commented on one but noticed it was in many places... why are the SVGs removed? We implement SVG with PNG fallback for all of our icons. |
|
@maya Well that was embarrassing. Fixed now, my bad! |
|
LGTM |
|
Hey @nickjs. We'll need to rebase the branch onto |
bf69721 to
b38799d
Compare
|
@rogeruiz Rebased |
|
@nickjs hey there, it looks like this branch has merge conflicts that must be resolved. Let us know if you can resolve these. Thanks! |
|
Hey @nickjs, I did a rebase of your branch on what's on Thanks! diff --cc src/stylesheets/elements/_list.scss
index a6e212c,7a7b3a6..0000000
--- a/src/stylesheets/elements/_list.scss
+++ b/src/stylesheets/elements/_list.scss
@@@ -27,14 -25,8 +25,19 @@@ ol
}
}
++<<<<<<< 69a216d9378154df0c759fca72da08506e8cf491
+ul li {
+ display: table-row;
+
+ &:before {
+ content: "\2022";
+ display: table-cell;
+ padding-right: 0.4em;
+ }
++=======
+ ul li::before {
+ content: '•';
++>>>>>>> Fix some scss-lint warnings in _list.scss
}
ol li {diff --cc src/stylesheets/core/_utilities.scss
index 8462591,454ae1a..0000000
--- a/src/stylesheets/core/_utilities.scss
+++ b/src/stylesheets/core/_utilities.scss
@@@ -5,6 -5,17 +5,20 @@@
}
}
++<<<<<<< b7fbc05658138dd433c3bcd2c4fff544c3ee5ecd
++=======
+ // Clearfix helper
+ @mixin clearfix() {
+ &::after {
+ content: '.';
+ display: block;
+ height: 0;
+ clear: both;
+ visibility: hidden;
+ }
+ }
+
++>>>>>>> Fix lots of scss-lint warnings
// Screen reader only helper
.usa-sr-only {
position: absolute; |
|
Closing this PR in favor of #1180 which will |
@rogeruiz @maya
Before:
After:
