[UI component]: Footer h4 semantics#1183
Merged
Merged
Conversation
Closed
| background-position: 1.5rem center; | ||
| background-repeat: no-repeat; | ||
| background-size: 1.3rem; | ||
| margin: 0; |
Contributor
There was a problem hiding this comment.
Looks like this can be margin-left: 0
Contributor
|
I'm OK with this change for now, although I think we need to refactor the footer code in the future. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR contains the work done by @madmanlear on #1150 rebased onto
18f-pages-stagingwith the correct number of file changes. This PR removes thedist/anddocs/directory commits that were necessary when the original commits were made.Additional Information
@madmanlear, feel free to review the commits here and branch off this branch to offer any new additional changes as needed. Or you can follow the instructions on #1150 around rebasing and removing the
dist/anddocs/directories.Original comment from @madmanlear