Fix styleguide again#1063
Closed
msecret wants to merge 4 commits into
Closed
Conversation
Contributor
Contributor
Author
|
Yes @nickjs, it should. Unfortunately, it now needs to be rebased again. I'll try and take a look at some point. |
|
Moving to the backlog for now until it is rebased. |
3 tasks
Contributor
|
Closing this PR in favor of #1180 which will |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed merge conflict from here:
#985
There are additional changes here to the dist files because in #1049 we didn't commit any changes to the compiled files.
@nickjs, you can either merge this PR in, or take this branch, merge it into your forked branch and merge that PR.