-
Notifications
You must be signed in to change notification settings - Fork 565
No really, let's import a linear history of unitycatalog-ui #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦atalog-ui#5) * feat: β¨ Add CatalogsList page + ListWrapper * extract format timestamp to util + add interaction to list rows
β¦tycatalog-ui#6) * feat: β¨ Add CatalogsList page + ListWrapper * extract format timestamp to util + add interaction to list rows * feat: β¨ Add details layout + catalog-details hook
β¦catalog-ui#7) * feat: β¨ Add CatalogsList page + ListWrapper * extract format timestamp to util + add interaction to list rows * add sidebar layout + catalog sidebar
β¦itycatalog-ui#10) * feat: β¨ Add SchemaDetails Page + getSchema hook
β¦atalog/unitycatalog-ui#12) * feat: β¨ Add schema tabs for functions tables and volumes
β¦talog/unitycatalog-ui#16) * feat: β¨ Add FunctionDetails page + sidebar with details * add breadcrumbs * add icon * add code block for function def * lint
β¦tycatalog-ui#14) * feat: β¨ Add TableDetails page + Table Sidebar details + fix metadata labels * add volume icon to details header
* feat: β¨ Create catalog flow * prefer invalidate queries for refetching all catalogs
* Update README.md * Update README.md
* delete table feature * handle onSuccess callback, navigate, display notification * PR feedback * More pr feedback * change button type * tableFullName prop * memoize
* Add CONTRIBUTING.md with contribution guidelines closes unitycatalog#26 * Fix indentation
* Add code style check add style check workflow * move prettier to devDependencies
β¦atalog-ui#60) * Add Code of Conduct link to CONTRIBUTING.md * removed unnecessary indentation * Update CONTRIBUTING.md with governance and communication guidelines Add a new CODE_OF_CONDUCT.md
* delete schema functionality * prettier
β¦og-ui#63) * Add ability to edit catalog description edit modal is made to support more fields in the future if we want to edit more than just description * lint * feedback Co-authored-by: Shawn Chen <ethanloatrchen@gmail.com> --------- Co-authored-by: Shawn Chen <ethanloatrchen@gmail.com>
* start of login page * env and google auth button * merge with main, remove params reference * start of okta auth * initial commit for handling auth token (unitycatalog#67) * start of login with keycloak * handle google sign in with token * more google auth * profile dropdown * merge with main * merge with main * convert to axios * start of readme instructions * get current user endpoint (unitycatalog/unitycatalog-ui#70) clean up some other endpoints * commenting out UI until repositories are merged * clean up current user (unitycatalog/unitycatalog-ui#74) * yarn lock file * remove keycloak for now, node version error in jwt-decode dependency * commit yarn lock * remove state as useEffect dependency, comment out currentUser call for now --------- Co-authored-by: Xiang Xu <xiang.xu@databricks.com>
Updating readme.md to reflect archival process.
dennyglee
approved these changes
Sep 6, 2024
Contributor
dennyglee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @rtyler
This was referenced Sep 6, 2024
Contributor
|
Note, this addresses the issue per discussion #349 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more time with feeling. π¨βπ€
This pull request supersedes #408 and makes some of the same changes except it provides a clean linear git history which can be rebased on top of this repositories history.
Steps I followed were basically:
ui/in that repo--allow-unrelated-historiesmainto remove the merge commitPR Checklist
docsis updated