This repository was archived by the owner on Sep 6, 2024. It is now read-only.
Feat: Add CatalogDetails page + DetailsWrapper #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0fb7a5e to
7618099
Compare
yc-shawn
reviewed
Jul 11, 2024
| @@ -0,0 +1,15 @@ | |||
| import React from 'react'; | |||
|
|
|||
| export function getChildOnDisplayName( | |||
Collaborator
There was a problem hiding this comment.
It feels quite unconventional and not very straightforward, can we just pass as prop in DetailsLayout instead of inventing sub components.
Let's keep the logic simple
Collaborator
Author
There was a problem hiding this comment.
It's quite adopted for layout-ing which is what we want to achieve here and libraries like antd use it. I honestly would like to push towards this pattern for this specific use case.
yc-shawn
approved these changes
Jul 11, 2024
rtyler
pushed a commit
to rtyler/unitycatalog
that referenced
this pull request
Sep 6, 2024
…tycatalog-ui#6) * feat: ✨ Add CatalogsList page + ListWrapper * extract format timestamp to util + add interaction to list rows * feat: ✨ Add details layout + catalog-details hook
rtyler
pushed a commit
to rtyler/unitycatalog
that referenced
this pull request
Sep 6, 2024
…tycatalog-ui#6) * feat: ✨ Add CatalogsList page + ListWrapper * extract format timestamp to util + add interaction to list rows * feat: ✨ Add details layout + catalog-details hook
dennyglee
pushed a commit
to unitycatalog/unitycatalog
that referenced
this pull request
Sep 6, 2024
…tycatalog-ui#6) * feat: ✨ Add CatalogsList page + ListWrapper * extract format timestamp to util + add interaction to list rows * feat: ✨ Add details layout + catalog-details hook
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.