This repository was archived by the owner on Sep 6, 2024. It is now read-only.
feat: Add 'Delete Catalog' feature in the catalog details page #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamieknight-db
approved these changes
Jul 25, 2024
Collaborator
jamieknight-db
left a comment
There was a problem hiding this comment.
LGTM! Thank you, Robert!
Comment on lines
+30
to
+34
| { | ||
| onError: (error: Error) => { | ||
| setNotification(error.message, 'error'); | ||
| }, | ||
| } |
Collaborator
There was a problem hiding this comment.
This is nice 👍 we should do the same error handling on all the delete assets.
Romanize
approved these changes
Jul 25, 2024
Romanize
reviewed
Jul 25, 2024
| Are you sure you want to delete the catalog | ||
| </Typography.Text> | ||
| <Typography.Text strong> | ||
| {` ${catalog}`} |
Collaborator
There was a problem hiding this comment.
nit: you can use {' '} for cleaner spacing
Collaborator
Author
|
Could someone squash and merge this PR? I do not have permissions. |
rtyler
pushed a commit
to rtyler/unitycatalog
that referenced
this pull request
Sep 6, 2024
rtyler
pushed a commit
to rtyler/unitycatalog
that referenced
this pull request
Sep 6, 2024
dennyglee
pushed a commit
to unitycatalog/unitycatalog
that referenced
this pull request
Sep 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37
UC-DeleteCatalog.mov
Thanks to @jamieknight-db for providing a nice baseline with the delete table PR. 😄