Skip to content

Conversation

@abrassel
Copy link
Contributor

@abrassel abrassel commented Jun 19, 2024

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added or modified a feature, documentation in docs is updated

Description of changes

This forces the use of the Coursier cache in all circumstances. Previously, the build was sometimes a bit unreliable. It seems as though it was pulling from multiple caches and failing to resolve all transitive dependencies.

netty-transport was the specific culprit.

Addresses #66 .

Tested by running bin/start-uc-server

@abrassel abrassel force-pushed the Hack_armeria_netty_dep branch from c0d5db0 to 0ada543 Compare June 20, 2024 04:26
**PR Checklist**

- [X] A description of the changes is added to the description of this
PR.
- [ ] If there is a related issue, make sure it is linked to this PR.
- [ ] If you've fixed a bug or added code that should be tested, add
tests!
- [ ] If you've added or modified a feature, documentation in `docs` is
updated

**Description of changes**

Updating the current `code of conduct` to reference and include the
Linux Foundation Code of Conduct as the project is part of [LF AI &
Data](https://lfaidata.foundation)

<!-- Please state what you've changed and how it might affect the users.
-->
@abrassel abrassel force-pushed the Hack_armeria_netty_dep branch from 0ada543 to f0cb084 Compare June 20, 2024 04:29
@tdas
Copy link
Contributor

tdas commented Jun 20, 2024

As @ramesh-db said in the issue #66, we are all running this on a macbook and we have not seen this issue. lets first dicuss on the issue and agree whether this change is needed.

@abrassel abrassel changed the title Hack armeria netty dep to compile UC server on macbook Force coursier cache to make uc server run Jun 22, 2024
@abrassel
Copy link
Contributor Author

Thank you @ravivj-db for root causing and solving this issue.

It was due to sbt using a mix between the .m2 and Coursier caches to resolve the classpath. @ravivj-db altered the build.sbt file to only use Cousier, which I was able to test and verify as an effective solution.

@ramesh-db I believe this PR is ready for merge.

@tdas
Copy link
Contributor

tdas commented Jun 27, 2024

Thank you for fixing this @abrassel . merging this.

@tdas tdas merged commit cfdce2c into unitycatalog:main Jun 27, 2024
dennyglee pushed a commit that referenced this pull request Sep 2, 2024
* start of login page

* env and google auth button

* merge with main, remove params reference

* start of okta auth

* initial commit for handling auth token (#67)

* start of login with keycloak

* handle google sign in with token

* more google auth

* profile dropdown

* merge with main

* merge with main

* convert to axios

* start of readme instructions

* get current user endpoint (#70)

clean up some other endpoints

* commenting out UI until repositories are merged

* clean up current user (#74)

* yarn lock file

* remove keycloak for now, node version error in jwt-decode dependency

* commit yarn lock

* remove state as useEffect dependency, comment out currentUser call for now

---------

Co-authored-by: Xiang Xu <xiang.xu@databricks.com>
tdas pushed a commit that referenced this pull request Sep 5, 2024
* start of login page

* env and google auth button

* merge with main, remove params reference

* start of okta auth

* initial commit for handling auth token (#67)

* start of login with keycloak

* handle google sign in with token

* more google auth

* profile dropdown

* merge with main

* merge with main

* convert to axios

* start of readme instructions

* get current user endpoint (#70)

clean up some other endpoints

* commenting out UI until repositories are merged

* clean up current user (#74)

* yarn lock file

* remove keycloak for now, node version error in jwt-decode dependency

* commit yarn lock

* remove state as useEffect dependency, comment out currentUser call for now

---------

Co-authored-by: Xiang Xu <xiang.xu@databricks.com>
rtyler pushed a commit to rtyler/unitycatalog that referenced this pull request Sep 5, 2024
* start of login page

* env and google auth button

* merge with main, remove params reference

* start of okta auth

* initial commit for handling auth token (unitycatalog#67)

* start of login with keycloak

* handle google sign in with token

* more google auth

* profile dropdown

* merge with main

* merge with main

* convert to axios

* start of readme instructions

* get current user endpoint (unitycatalog#70)

clean up some other endpoints

* commenting out UI until repositories are merged

* clean up current user (unitycatalog#74)

* yarn lock file

* remove keycloak for now, node version error in jwt-decode dependency

* commit yarn lock

* remove state as useEffect dependency, comment out currentUser call for now

---------

Co-authored-by: Xiang Xu <xiang.xu@databricks.com>
rtyler pushed a commit to rtyler/unitycatalog that referenced this pull request Sep 6, 2024
* start of login page

* env and google auth button

* merge with main, remove params reference

* start of okta auth

* initial commit for handling auth token (unitycatalog#67)

* start of login with keycloak

* handle google sign in with token

* more google auth

* profile dropdown

* merge with main

* merge with main

* convert to axios

* start of readme instructions

* get current user endpoint (unitycatalog/unitycatalog-ui#70)

clean up some other endpoints

* commenting out UI until repositories are merged

* clean up current user (unitycatalog/unitycatalog-ui#74)

* yarn lock file

* remove keycloak for now, node version error in jwt-decode dependency

* commit yarn lock

* remove state as useEffect dependency, comment out currentUser call for now

---------

Co-authored-by: Xiang Xu <xiang.xu@databricks.com>
rtyler pushed a commit to rtyler/unitycatalog that referenced this pull request Sep 6, 2024
* start of login page

* env and google auth button

* merge with main, remove params reference

* start of okta auth

* initial commit for handling auth token (unitycatalog#67)

* start of login with keycloak

* handle google sign in with token

* more google auth

* profile dropdown

* merge with main

* merge with main

* convert to axios

* start of readme instructions

* get current user endpoint (unitycatalog/unitycatalog-ui#70)

clean up some other endpoints

* commenting out UI until repositories are merged

* clean up current user (unitycatalog/unitycatalog-ui#74)

* yarn lock file

* remove keycloak for now, node version error in jwt-decode dependency

* commit yarn lock

* remove state as useEffect dependency, comment out currentUser call for now

---------

Co-authored-by: Xiang Xu <xiang.xu@databricks.com>
dennyglee pushed a commit that referenced this pull request Sep 6, 2024
* start of login page

* env and google auth button

* merge with main, remove params reference

* start of okta auth

* initial commit for handling auth token (#67)

* start of login with keycloak

* handle google sign in with token

* more google auth

* profile dropdown

* merge with main

* merge with main

* convert to axios

* start of readme instructions

* get current user endpoint (unitycatalog/unitycatalog-ui#70)

clean up some other endpoints

* commenting out UI until repositories are merged

* clean up current user (unitycatalog/unitycatalog-ui#74)

* yarn lock file

* remove keycloak for now, node version error in jwt-decode dependency

* commit yarn lock

* remove state as useEffect dependency, comment out currentUser call for now

---------

Co-authored-by: Xiang Xu <xiang.xu@databricks.com>
vksx pushed a commit to vksx/unitycatalog that referenced this pull request Oct 7, 2024
* start of login page

* env and google auth button

* merge with main, remove params reference

* start of okta auth

* initial commit for handling auth token (unitycatalog#67)

* start of login with keycloak

* handle google sign in with token

* more google auth

* profile dropdown

* merge with main

* merge with main

* convert to axios

* start of readme instructions

* get current user endpoint (unitycatalog/unitycatalog-ui#70)

clean up some other endpoints

* commenting out UI until repositories are merged

* clean up current user (unitycatalog/unitycatalog-ui#74)

* yarn lock file

* remove keycloak for now, node version error in jwt-decode dependency

* commit yarn lock

* remove state as useEffect dependency, comment out currentUser call for now

---------

Co-authored-by: Xiang Xu <xiang.xu@databricks.com>
Signed-off-by: Vikas Sharma <master2vikas@gmail.com>
vikrantpuppala pushed a commit to vikrantpuppala/unitycatalog that referenced this pull request Oct 8, 2024
* start of login page

* env and google auth button

* merge with main, remove params reference

* start of okta auth

* initial commit for handling auth token (unitycatalog#67)

* start of login with keycloak

* handle google sign in with token

* more google auth

* profile dropdown

* merge with main

* merge with main

* convert to axios

* start of readme instructions

* get current user endpoint (unitycatalog/unitycatalog-ui#70)

clean up some other endpoints

* commenting out UI until repositories are merged

* clean up current user (unitycatalog/unitycatalog-ui#74)

* yarn lock file

* remove keycloak for now, node version error in jwt-decode dependency

* commit yarn lock

* remove state as useEffect dependency, comment out currentUser call for now

---------

Co-authored-by: Xiang Xu <xiang.xu@databricks.com>
kevinzwang pushed a commit to kevinzwang/unitycatalog that referenced this pull request Oct 10, 2024
* start of login page

* env and google auth button

* merge with main, remove params reference

* start of okta auth

* initial commit for handling auth token (unitycatalog#67)

* start of login with keycloak

* handle google sign in with token

* more google auth

* profile dropdown

* merge with main

* merge with main

* convert to axios

* start of readme instructions

* get current user endpoint (unitycatalog/unitycatalog-ui#70)

clean up some other endpoints

* commenting out UI until repositories are merged

* clean up current user (unitycatalog/unitycatalog-ui#74)

* yarn lock file

* remove keycloak for now, node version error in jwt-decode dependency

* commit yarn lock

* remove state as useEffect dependency, comment out currentUser call for now

---------

Co-authored-by: Xiang Xu <xiang.xu@databricks.com>
Signed-off-by: Kevin Wang <kevin@eventualcomputing.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants